Your message dated Tue, 21 Jul 2020 08:33:35 +0000
with message-id <[email protected]>
and subject line Bug#965255: fixed in dh-fortran-mod 0.17
has caused the Debian Bug report #965255,
regarding dh-fortran-mod: please make the output reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
965255: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=965255
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: dh-fortran-mod
Version: 0.16
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: randomness toolchain
X-Debbugs-Cc: [email protected]

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
dh-fortran-mod was not generating deterministic output. For example,
here is healpix-fortran's preinst file:

│ │ │ │ @@ -1,14 +1,14 @@
│ │ │ │  #!/bin/sh
│ │ │ │  set -e
│ │ │ │  # Automatically added by dh_fortran_mod/0.16
│ │ │ │  # May be installed multiple times for different canoncomp
│ │ │ │  multiarch="x86_64-linux-gnu"
│ │ │ │  base="gfortran-mod-15"
│ │ │ │ -canoncomp='gfortran-10'
│ │ │ │ +canoncomp='x86_64-linux-gnu-gfortran-9'
│ │ │ │
│ │ │ │  # clear cruft from old bug if present
│ │ │ │  rm -f /usr/lib/$multiarch/fortran/$base/$base
│ │ │ │
│ │ │ │  mkdir -p /usr/lib/$multiarch/fortran/$base
│ │ │ │  if ! test -x /usr/lib/$multiarch/fortran/$canoncomp ; then
│ │ │ │    ln -sf /usr/lib/$multiarch/fortran/$base 
/usr/lib/$multiarch/fortran/$canoncomp
│ │ │ │ @@ -21,15 +21,15 @@
│ │ │ │    rmdir /usr/lib/$multiarch/fortran/flang-mod-33
│ │ │ │  fi
│ │ │ │  # End automatically added section
│ │ │ │  # Automatically added by dh_fortran_mod/0.16
│ │ │ │  # May be installed multiple times for different canoncomp
│ │ │ │  multiarch="x86_64-linux-gnu"
│ │ │ │  base="gfortran-mod-15"
│ │ │ │ -canoncomp='x86_64-linux-gnu-gfortran-9'
│ │ │ │ +canoncomp='gfortran-8'
│ │ │ │
│ │ │ │  # clear cruft from old bug if present
│ │ │ │  rm -f /usr/lib/$multiarch/fortran/$base/$base
│ │ │ │
│ │ │ │  mkdir -p /usr/lib/$multiarch/fortran/$base
│ │ │ │  if ! test -x /usr/lib/$multiarch/fortran/$canoncomp ; then
│ │ │ │    ln -sf /usr/lib/$multiarch/fortran/$base 
/usr/lib/$multiarch/fortran/$canoncomp
│ │ │ │ @@ -42,15 +42,15 @@
│ │ │ │    rmdir /usr/lib/$multiarch/fortran/flang-mod-33
│ │ │ │  fi
│ │ │ │  # End automatically added section
│ │ │ │  # Automatically added by dh_fortran_mod/0.16
│ │ │ │  # May be installed multiple times for different canoncomp
│ │ │ │  multiarch="x86_64-linux-gnu"
│ │ │ │  base="gfortran-mod-15"
│ │ │ │ -canoncomp='gfortran-8'
│ │ │ │ +canoncomp='gfortran-10'
│ │ │ │
│ │ │ │  # clear cruft from old bug if present
│ │ │ │  rm -f /usr/lib/$multiarch/fortran/$base/$base
│ │ │ │
│ │ │ │  mkdir -p /usr/lib/$multiarch/fortran/$base
│ │ │ │  if ! test -x /usr/lib/$multiarch/fortran/$canoncomp ; then
│ │ │ │    ln -sf /usr/lib/$multiarch/fortran/$base 
/usr/lib/$multiarch/fortran/$canoncomp

The ordering is non-deterministic due to the main dh_fortran_mod
script iterates over a Perl dictionary in key order.

Patch attached.

  [0] https://reproducible-builds.org/


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [email protected] / chris-lamb.co.uk
       `-
diff --git a/dh_fortran_mod.in b/dh_fortran_mod.in
index 8a3a48e..79f5b3f 100755
--- a/dh_fortran_mod.in
+++ b/dh_fortran_mod.in
@@ -388,7 +388,7 @@ foreach my $package (getpackages()) {
     keys %modversions;
 
     if ($config) { # config file defined, so create scripts
-       while (my($compiler,$fcompilermod) = each %modversions) {
+       while (my($compiler,$fcompilermod) = sort each %modversions) {
            my $lnk=`readlink -f /usr/bin/$compiler`;
            my $canoncomp=`basename $lnk`;
            chomp $canoncomp;

--- End Message ---
--- Begin Message ---
Source: dh-fortran-mod
Source-Version: 0.17
Done: Alastair McKinstry <[email protected]>

We believe that the bug you reported is fixed in the latest version of
dh-fortran-mod, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Alastair McKinstry <[email protected]> (supplier of updated dh-fortran-mod 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 21 Jul 2020 08:59:11 +0100
Source: dh-fortran-mod
Architecture: source
Version: 0.17
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Team 
<[email protected]>
Changed-By: Alastair McKinstry <[email protected]>
Closes: 965255
Changes:
 dh-fortran-mod (0.17) unstable; urgency=medium
 .
   * Fix for reproducibility. Thanks to Chris Lamb. Closes: #965255
   * debhelper compat 13
Checksums-Sha1:
 4902bc7429752e53dc58225a174aa7adf89bf24f 1697 dh-fortran-mod_0.17.dsc
 8c38833f220616cbb136834042fcf689fba814b7 7888 dh-fortran-mod_0.17.tar.xz
Checksums-Sha256:
 81e10ec1eb0ea84dc705ed1726df1fac5ef038252bf6e1c4cc313b4add4095e6 1697 
dh-fortran-mod_0.17.dsc
 0ffc6b0eddb8fcd92444cbe416fac788f7e8d13b50c14daceb29f4e754b1c9f0 7888 
dh-fortran-mod_0.17.tar.xz
Files:
 cb6130b61c5793dd3b9c18fd1d2e63d7 1697 devel optional dh-fortran-mod_0.17.dsc
 63030b90f0147e64613ff000933eaf12 7888 devel optional dh-fortran-mod_0.17.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEgjg86RZbNHx4cIGiy+a7Tl2a06UFAl8WpBsACgkQy+a7Tl2a
06X3Bg/9FySKaEVd7BYQ38lw8ZUd3yysl4l+gzyHXZDCFZebPkpT1vOk3XIYrc3I
ef+dwMLUiiyKC+HaBGY+ZsOKwu1rXdBavQDtLjwbJH6Xb0Q/Md9iCyMeqHauvUfE
0NoMD0mLzplBldb0aNkk+oQuhJBTmtgFCv4Ujq8CMxS7pSA8gRf/2EQPCfmA6547
naU/gr7mD/g2EjZo0YiMfQxllGhV7DHSDZaOnCgIOY51qNI1e5dFqJK23E6yu5lu
TG8JTsTa1XQC4tfAmsD1yv9Ag2YlKO8M112wpIJCbCG9QYla6ZN1mzoF9myS/mH4
NMcmQiIw+2Lmfw+3vdQo/xCik1lHB6rnwHITy8T97ECLkc9cSEA/t4nWmPJoAsvq
j7Bnx4AzbbfN3OkkNaCi5XHH6UOsdQS8mnPehBIV8W2Ker5My1bhVaVcRKHiXplB
hfUx1Ase4osAA7g603JVUADP2mPumgPYaNX9prBk3//3+iEwY9iznMMZZ3qwp1uX
ggIhlBm01h+LnDprWlB7rHJTBfN/lKshVd1odrrZOY5xQ8pZIXVAb3O0z4Z2cSNu
/gRRrGX3ppjAHibOsB+qqgEHTyRBsbVNWoDDD4ZmEGe/CQ5mo4f4bnKCQytwbJej
K+zzCEliusO6SE9KJoaiA3KCCkznZzLjKDsH/4KrFFLk4SIigTU=
=R57F
-----END PGP SIGNATURE-----

--- End Message ---
-- 
debian-science-maintainers mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-science-maintainers

Reply via email to