G'day FTPMaster and Kartik... I've pushed HFST 3.15.4 to https://salsa.debian.org/science-team/hfst which should resolve all this.
The upstream tracking issue was https://github.com/hfst/hfst/issues/494 and there's also been some emails to the HFST authors, with Kartik on CC, to clear everything up. Specifically: - Upgraded the bundled Foma version to one that is explicitly Apache-2.0. - Removed the Bison/Flex generated Foma files from the sources uploaded to Debian, letting them be regenerated during build. - Added explicit COPYING to the bundled SFST sources, and put a comment in d/copyright to list exactly which upstream is bundled. - Sorted out the mess of libhfst/* being a mix of licenses by asking original authors and copyright holders to clarify intent, and settled on that it was always meant to be LGPLv3+ so changed the files to say so... - ...but with a final quirk: The files libhfst/src/parsers/[Ss]fst* are derived from SFST, but distributed as part of libhfst under LGPL-3+ license with written permission from Helmut Schmid. - m4/ files listed in d/c. - scripts/windows/* removed from sources uploaded to Debian. There is no rush to review changes or upload. We missed the freeze window, and that's ok. -- Tino Didriksen On Fri, 18 Dec 2020 at 22:00, Joerg Jaspert <[email protected]> wrote: > > Hi Maintainer, > > sorry, rejected this time around. > > The review notes from one trainee are below: > > Comments > ======== > > [ d/c : debian/copyright ] > > / ***** serious error *****/ > > - back-ends/foma/cpp-version/apply.cc mentions GNU General Public License > version 2 > but d/c mentions License: Apache-2.0 > > same for coaccessible.cc and many other. See Comment in the matching d/c > stanza. I went to that page and found nothing. > > The back-ends/foma/COPYING is GPL-2.0+. The README file confirms this. > > So I guess the change to Apache-2.0 is for one future version. For this > version, d/c is erroneous. > > - back-ends/foma/cpp-version/regex.cc is Copyright (C) 1984, 1989-1990, > 2000-2011 Free Software Foundation, Inc., but d/c does not mention it. > > same for back-ends/foma/regex.[ch] > > - files in back-ends/sfst/* have no copyright notice nor license notice and > there is no COPYING or LICENSE file in the directory. > > - libhfst/src/parsers/ contains files that are either GPL3 or LGPL3+ and > the > COPYING file says LGPL3 (not +) [what a mess]. > > - m4/ax_check_compile_flag.m4 is not mentioned in d/c. > same for m4/ax_check_icu.m4 > > - scripts/windows/inttypes.h is not listed in d/c > > -- > bye Joerg > > > > === > > Please feel free to respond to this email if you don't understand why > your files were rejected, or if you upload new files which address our > concerns.
-- debian-science-maintainers mailing list [email protected] https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-science-maintainers
