Your message dated Sun, 30 Jan 2022 12:48:49 +0000
with message-id <[email protected]>
and subject line Bug#940664: fixed in combblas 1.6.2-7
has caused the Debian Bug report #940664,
regarding combblas FTCBFS: uses mpicc
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
940664: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=940664
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: combblas
Version: 1.6.2-4
Tags: patch
User: [email protected]
Usertags: ftcbfs

combblas fails to cross build from source, because it uses mpicc. mpicc
is unfixable for cross compilation and the only way to make cross
building work is not using mpicc. Fortunately, much of combblas already
uses pkg-config for discovering mpi already. It's just two
subdirectories that fail to propagate the relevant compiler flags. After
doing so, there is no need to use mpicc anymore. Please consider
applying the attached patch.

Helmut
diff --minimal -Nru combblas-1.6.2/debian/changelog 
combblas-1.6.2/debian/changelog
--- combblas-1.6.2/debian/changelog     2019-09-14 16:43:46.000000000 +0200
+++ combblas-1.6.2/debian/changelog     2019-09-18 19:30:51.000000000 +0200
@@ -1,3 +1,10 @@
+combblas (1.6.2-4.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Improve cross building: Don't use mpicc. (Closes: #-1)
+
+ -- Helmut Grohne <[email protected]>  Wed, 18 Sep 2019 19:30:51 +0200
+
 combblas (1.6.2-4) unstable; urgency=medium
 
   * Standards-Version: 4.4.0
diff --minimal -Nru combblas-1.6.2/debian/patches/mpi.patch 
combblas-1.6.2/debian/patches/mpi.patch
--- combblas-1.6.2/debian/patches/mpi.patch     1970-01-01 01:00:00.000000000 
+0100
+++ combblas-1.6.2/debian/patches/mpi.patch     2019-09-18 19:30:51.000000000 
+0200
@@ -0,0 +1,20 @@
+--- combblas-1.6.2.orig/graph500-1.2/generator/CMakeLists.txt
++++ combblas-1.6.2/graph500-1.2/generator/CMakeLists.txt
+@@ -3,6 +3,7 @@
+ ADD_LIBRARY( GraphGenlib btrd_binomial_distribution.c splittable_mrg.c 
mrg_transitions.c graph_generator.c permutation_gen.c make_graph.c utils.c 
scramble_edges.c)
+ target_include_directories(GraphGenlib PUBLIC 
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include> 
$<INSTALL_INTERFACE:include>)
+ target_include_directories(GraphGenlib PRIVATE include/graph500/generator)
++target_include_directories(GraphGenlib PUBLIC "${MPI_C_INCLUDE_PATH}")
+ if(CMAKE_C_COMPILER_ID STREQUAL "Intel")
+   target_compile_options(GraphGenlib PRIVATE "-restrict")
+ endif()
+--- combblas-1.6.2.orig/usort/CMakeLists.txt
++++ combblas-1.6.2/usort/CMakeLists.txt
+@@ -3,6 +3,7 @@
+ ADD_LIBRARY( Usortlib src/parUtils.cpp src/binUtils.cpp )
+ target_include_directories(Usortlib PUBLIC 
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include> 
$<INSTALL_INTERFACE:include>)
+ target_include_directories(Usortlib PRIVATE include/usort)
++target_include_directories(Usortlib PUBLIC "${MPI_C_INCLUDE_PATH}")
+ 
+ install(DIRECTORY include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
+ install(TARGETS Usortlib EXPORT CombBLASTargets
diff --minimal -Nru combblas-1.6.2/debian/patches/series 
combblas-1.6.2/debian/patches/series
--- combblas-1.6.2/debian/patches/series        2019-09-14 16:43:46.000000000 
+0200
+++ combblas-1.6.2/debian/patches/series        2019-09-18 19:30:51.000000000 
+0200
@@ -1,2 +1,3 @@
 cmake_multiarch.patch
 sublibs_soname.patch
+mpi.patch
diff --minimal -Nru combblas-1.6.2/debian/rules combblas-1.6.2/debian/rules
--- combblas-1.6.2/debian/rules 2019-09-14 16:43:46.000000000 +0200
+++ combblas-1.6.2/debian/rules 2019-09-18 19:30:51.000000000 +0200
@@ -30,8 +30,6 @@
        dh_auto_configure -- \
             -DBUILD_SHARED_LIBS=ON \
             -DCMAKE_SKIP_RPATH=ON \
-            -DCMAKE_C_COMPILER=mpicc \
-            -DCMAKE_CXX_COMPILER=mpic++ \
             -DMPIEXEC_PREFLAGS=--allow-run-as-root
        tar xzf debian/testdata_combblas*.tgz -C $(BUILDDIR)
 

--- End Message ---
--- Begin Message ---
Source: combblas
Source-Version: 1.6.2-7
Done: Drew Parsons <[email protected]>

We believe that the bug you reported is fixed in the latest version of
combblas, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Drew Parsons <[email protected]> (supplier of updated combblas package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 30 Jan 2022 12:58:19 +0100
Source: combblas
Architecture: source
Version: 1.6.2-7
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers 
<[email protected]>
Changed-By: Drew Parsons <[email protected]>
Closes: 940664
Changes:
 combblas (1.6.2-7) unstable; urgency=medium
 .
   * combblas uses cmake to detect MPI, no need to specify mpicc as
     compiler and cross-compiling is simpler then. Closes: Bug#940664.
     - debian patch mpi_build.patch propagates cmake MPI configuration
       to subdirectories where it was missing. Thanks Helmut Grohne.
     - update debian/tests/ReleaseTests_CMakeLists.txt.patch to use
       cmake to find MPI (and OpenMP) for debian/tests (autopkgtest)
   * build tests for debian/tests (autopkgtest) with VERBOSE=1
   * Standards-Version: 4.6.0
Checksums-Sha1:
 c828639c3e1d5c493a9df3d53f46f739c1b9e0b6 2231 combblas_1.6.2-7.dsc
 99f91da3cd70d27f808e22945d482981ba2fb974 33747552 
combblas_1.6.2-7.debian.tar.xz
Checksums-Sha256:
 3471afdf89b6608eb23deac3477c709151b1ad410cfd66816c5500cbb156685d 2231 
combblas_1.6.2-7.dsc
 ab34f4c3a5c5688ca7d01ba5c92dcfe58f54ed513ab71b2f2de782235fbf1740 33747552 
combblas_1.6.2-7.debian.tar.xz
Files:
 c1dee95f547400bc6898b128342ecab3 2231 libs optional combblas_1.6.2-7.dsc
 7f31f26525582fca866351e872a665e5 33747552 libs optional 
combblas_1.6.2-7.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEI8mpPlhYGekSbQo2Vz7x5L1aAfoFAmH2hTIACgkQVz7x5L1a
AfrvdRAArOut0vDapb7XFBKSrvhSRO2PjeWoB54wiM/OcErsKHWVOyohKaWSeK36
SK6mG/PHCsSiXrtFfHnEIFuYbAf91vBeZ8mxWXcDwaDK8rtilR8kemHiLZXMo81X
C9xJrg4wNIUTSokTaLjwZCxCsX6hA+CukA/FKH/k2un5mrScumKUHCKnSz3n/WNX
XtNqGrM17grO8jiGF10ujzsrlcxMK9oUI5JXnGV7Ak8R0tFAOKc2gVat4JjAlYBr
2FdhXNRw/g7rfMp+qrAeBOw8MfCxDTh70lAS+Rnz+7LWmHqF+BXntuGYBzNWRENA
OXnvEKqJC9UyyTzhyxH81keXMB9E7j70nJpVWJbw4ofxusiDpVmrk6IFp2EMfj21
adttY5yVXuILrmuabzuDo7BLJQHY4uVnVDcV3GQwYdYsUQsy7WtW/XwdFiF+AiZn
CIEVD/JkZWjNjETSl7XtwPRWz6WCjtAJlLso1SAhkC/dwTEg1MIYypzjnKyah80Y
Y3AxAkf0eQZJ4RK9zMjlFCbPKIAd2e2s7zLwSwVwcHai2T3QXyquvZMCK9OyW/Vw
gFFErpmc3LAnkONe+euuBmiu4AnY59ImpySDe8P7BrYI/8IqW2nmzPSoqVZLkD9t
goS4+vlyxag1ls6x6pS7Lap2uWNWGfpjcpbMk5GxnxQMjQxoRAI=
=dlnJ
-----END PGP SIGNATURE-----

--- End Message ---
-- 
debian-science-maintainers mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-science-maintainers

Reply via email to