Your message dated Sat, 21 Sep 2024 22:19:56 +0000
with message-id <[email protected]>
and subject line Bug#1078097: fixed in cod-tools 3.10.0+dfsg-1.1
has caused the Debian Bug report #1078097,
regarding cod-tools: autopkgtest regression with Perl 5.40: Attempt to call
undefined import method with arguments
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1078097: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1078097
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: cod-tools
Version: 3.10.0+dfsg-1
Severity: important
User: [email protected]
Usertags: perl-5.40-transition
Tags: patch
This package fails its autopkgtest checks with Perl 5.40
(currently in experimental.)
https://ci.debian.net/packages/c/cod-tools/unstable/amd64/50041232/
69s
/tmp/autopkgtest-lxc.xs3evp70/downtmp/autopkgtest_tmp/tests/cases/cif2cod_001.inp:
FAILED:
69s 0a1
69s > Attempt to call undefined import method with arguments
("cif_cell_contents") via package "COD::CIF::Data::CellContents" (Perhaps you
forgot to load the package?) at <script_name> line <line_no>.
69s
/tmp/autopkgtest-lxc.xs3evp70/downtmp/autopkgtest_tmp/tests/cases/cif2cod_002.inp:
FAILED:
69s 0a1
69s > Attempt to call undefined import method with arguments
("cif_cell_contents") via package "COD::CIF::Data::CellContents" (Perhaps you
forgot to load the package?) at <script_name> line <line_no>.
70s
/tmp/autopkgtest-lxc.xs3evp70/downtmp/autopkgtest_tmp/tests/cases/cif2cod_003.inp:
FAILED:
[...]
The test failures are also visible in the build log, but the build still
succeeds. It looks like the subdirectory make invocations in the main
Makefile lack error checking.
https://perl.debian.net/rebuild-logs/perl-5.40/cod-tools_3.10.0%2Bdfsg-1/cod-tools_3.10.0%2Bdfsg-1%2Bb2_amd64-2024-08-03T07%3A34%3A21Z.build
Some information on this new warning can be found at
https://metacpan.org/dist/perl/view/pod/perldiag.pod#Missing-comma-after-first-argument-to-return
I think this is a case of mutually recursive modules where the assignment
to @EXPORT_OK happens too late at run time while it's needed at compile
time. See the "Playing Safe" section in Exporter(3perl).
Tentative patch attached, this fixes it for me.
--
Niko Tyni [email protected]
From: Niko Tyni <[email protected]>
Date: Tue, 6 Aug 2024 20:38:09 +0100
X-Dgit-Generated: 3.10.0+dfsg-1 5a1458da5fc72e0d208dc9baa32a05fe79a92403
Subject: Fix Exporter usage with mutually recursive modules
This fixes warnings with Perl 5.40:
Attempt to call undefined import method with arguments ("cif_cell_contents") via package "COD::CIF::Data::CellContents" (Perhaps you forgot to load the package?)
See the "Playing Safe" section in Exporter(3perl) and
https://metacpan.org/dist/perl/view/pod/perldelta.pod#Calling-the-import-method-of-an-unknown-package-produces-a-warning
---
diff --git a/src/lib/perl5/COD/CIF/Data/CellContents.pm b/src/lib/perl5/COD/CIF/Data/CellContents.pm
index 27d7ced..090d6b7 100644
--- a/src/lib/perl5/COD/CIF/Data/CellContents.pm
+++ b/src/lib/perl5/COD/CIF/Data/CellContents.pm
@@ -14,6 +14,17 @@ package COD::CIF::Data::CellContents;
use strict;
use warnings;
+
+BEGIN {
+require Exporter;
+our @ISA = qw( Exporter );
+our @EXPORT_OK = qw(
+ cif_cell_contents
+ atomic_composition
+ print_composition
+);
+}
+
use COD::AtomProperties;
use COD::Fractional qw( symop_ortho_from_fract ) ;
use COD::Spacegroups::Symop::Parse qw( symop_from_string
@@ -26,14 +37,6 @@ use COD::CIF::Data::AtomList qw( atom_array_from_cif );
use COD::CIF::Data::EstimateZ qw( cif_estimate_z );
use COD::CIF::Data::SymmetryGenerator qw( symop_generate_atoms );
-require Exporter;
-our @ISA = qw( Exporter );
-our @EXPORT_OK = qw(
- cif_cell_contents
- atomic_composition
- print_composition
-);
-
$::format = "%g";
sub atomic_composition( $$$@ );
diff --git a/src/lib/perl5/COD/CIF/Data/EstimateZ.pm b/src/lib/perl5/COD/CIF/Data/EstimateZ.pm
index 1f82159..42f1349 100644
--- a/src/lib/perl5/COD/CIF/Data/EstimateZ.pm
+++ b/src/lib/perl5/COD/CIF/Data/EstimateZ.pm
@@ -16,6 +16,15 @@ package COD::CIF::Data::EstimateZ;
use strict;
use warnings;
+BEGIN {
+require Exporter;
+our @ISA = qw( Exporter );
+our @EXPORT_OK = qw(
+ cif_estimate_z
+ cif_estimate_z_from_formula
+);
+}
+
use COD::Cell qw( cell_volume );
use COD::CIF::Data qw( get_cell get_symmetry_operators );
use COD::Precision qw( unpack_cif_number );
@@ -29,13 +38,6 @@ use COD::Spacegroups::Symop::Parse qw( symop_from_string
use COD::CIF::Data::SymmetryGenerator qw( symop_generate_atoms );
use COD::CIF::Data::CellContents qw( cif_cell_contents );
-require Exporter;
-our @ISA = qw( Exporter );
-our @EXPORT_OK = qw(
- cif_estimate_z
- cif_estimate_z_from_formula
-);
-
# Avogadro number in "CIF unit" scale:
my $N = 0.1 * 6.0221418;
--- End Message ---
--- Begin Message ---
Source: cod-tools
Source-Version: 3.10.0+dfsg-1.1
Done: gregor herrmann <[email protected]>
We believe that the bug you reported is fixed in the latest version of
cod-tools, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
gregor herrmann <[email protected]> (supplier of updated cod-tools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 16 Sep 2024 23:47:14 CEST
Source: cod-tools
Binary:
Architecture: source
Version: 3.10.0+dfsg-1.1
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers
<[email protected]>
Built-For-Profiles: nocheck
Changed-By: gregor herrmann <[email protected]>
Description:
Closes: 1078097
Changes:
cod-tools (3.10.0+dfsg-1.1) unstable; urgency=medium
.
* Non-maintainer upload.
* Fix "autopkgtest regression with Perl 5.40: Attempt to call
undefined import method with arguments": add patch from Niko Tyni to fix
Exporter(3pm) usage.
(Closes: #1078097)
Checksums-Sha256:
dfdf7d3a58c474fcad534696a1dd125e2ead46726760306bb1d7cd46bf9c496e 3516
cod-tools_3.10.0+dfsg-1.1.dsc
08c438f697fcce134301247fdd7d272db4ef936da4e323f168b08e0031bfd0c5 15268
cod-tools_3.10.0+dfsg-1.1.debian.tar.xz
b1f0239df1f4c12add031545c2c00e0cb2c86cde87d9f985ffe9bb9cb8cb4263 12390
cod-tools_3.10.0+dfsg-1.1_sourceonly.buildinfo
Checksums-Sha1:
e14a7883bc8097fe4aa2949bc8f6cbb22878128d 3516 cod-tools_3.10.0+dfsg-1.1.dsc
baa4b60b9db8e37124d2ee52f9fa0b7c044ea3d1 15268
cod-tools_3.10.0+dfsg-1.1.debian.tar.xz
788c404ea716ada5a28cef3914f15859fad8d0f4 12390
cod-tools_3.10.0+dfsg-1.1_sourceonly.buildinfo
Files:
2acaaff8362a0822e0c92e0443bb7452 3516 science optional
cod-tools_3.10.0+dfsg-1.1.dsc
7dba9d3fb03e9b38cdf39c1d0b06e3ef 15268 science optional
cod-tools_3.10.0+dfsg-1.1.debian.tar.xz
b5c77866e1a2d770d66c5044315ec76a 12390 - -
cod-tools_3.10.0+dfsg-1.1_sourceonly.buildinfo
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAmbop2JfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgZNew/7Bo74/JOVJ5J/ePNYxsDNkNBhMP8wNMmrueuwe7GSNXp+3cyuVN5pi7OO
eKM7H/KIz+YESGBlgfqrek2Zt6MXf0reooPLOALTae/jmfCID+uRsZTToAofensy
ZsY3pxAm6fFbA/CF3gfAIDusxjq7KRjorHwFVDRv4OSPnhc5i4ogplWPCYBBC9BH
2Hawbz12Uhq59Ua2ia/V5vnDEk7CIlxUzsZ9yADySNk2AvyPjj3iGdbqp/SNU8xL
Pc38Q/u23xHTspeBxRUHve8dZ7nyNz1uyQhlEQclVNs4Gwq0Z5AIoM/HwAE72x/c
bHshCvmzP6khQRLdv3mDVXC92tl3AirXEVIvwXI8Gu1sycKbILwsk3JH/wqysiZX
y/aYt9mc7wboCZQDVgtZFoYM2t3mL2ftEhIDqBCnffXPFDItHFSo8eD39k8Dwd6y
ibqIE1Ob/HLhzkSsF8FRqJbjF+9XrzQb9K+XGid27Tqw+J7LiZiIkiknJ8CKn/VU
UPbTGnkJd2KY+Kv20bcy07etjqjvco4vR2tkU2ma8OoenVsRkZEyX0RGw6DhyoeC
xaRO7spL68amjj+JIAAJ82Kq7U6n9twI/eBFg1rK0rj2sRc6NjEXaPIZT7zEKtoe
TiEKfGMmeiMHnBDRXjoidq8BPtwYBll8b9lykkFq+pX181lZrEg=
=sKAk
-----END PGP SIGNATURE-----
pgp5cT_LqCCzY.pgp
Description: PGP signature
--- End Message ---
--
debian-science-maintainers mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-science-maintainers
