Your message dated Sat, 12 Apr 2025 18:34:54 +0000
with message-id <[email protected]>
and subject line Bug#1032096: fixed in jsurf-alggeo 0.4.1+ds-6
has caused the Debian Bug report #1032096,
regarding jsurf-alggeo: Autopkgtest failure on armel
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1032096: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1032096
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: jsurf-alggeo
Version: 0.4.1+ds-3
Severity: normal
X-Debbugs-Cc: [email protected]
Dear Maintainer,
The package fails make-TestJSurf test due to the race condition
de.mfo.jsurf.test.TestJSurf creates a SwingWorker, waits 100 milliseconds,
attempts to cancel rendering tasks in stopDrawingMethod() and then asserts that
time after swing worker creation has not exceeded 200 msec. This is a flaky
assertion that depends on the host machine's performance.
See related log [1].
Would it be possible to consider a patch that retries stopDrawing() and
asserts that the rendering was interrupted instead?
Thank you for considering the patch!
[1] https://ci.debian.net/data/autopkgtest/unstable/armel/j/jsurf-
alggeo/31633915/log.gz
diff --git a/src/test/java/de/mfo/jsurf/test/TestJSurf.java b/src/test/java/de/mfo/jsurf/test/TestJSurf.java
index 4f83c0f..8b93a3f 100644
--- a/src/test/java/de/mfo/jsurf/test/TestJSurf.java
+++ b/src/test/java/de/mfo/jsurf/test/TestJSurf.java
@@ -8,6 +8,10 @@ import de.mfo.jsurf.algebra.*;
import de.mfo.jsurf.parser.*;
import de.mfo.jsurf.util.FileFormat;
import java.util.Properties;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.TimeUnit;
+
import javax.swing.SwingWorker;
public class TestJSurf
@@ -27,6 +31,8 @@ public class TestJSurf
class BackgroundRenderer extends SwingWorker< Void, Void >
{
+ public boolean interrupted = false;
+
@Override
public Void doInBackground() {
try {
@@ -35,6 +41,7 @@ public class TestJSurf
catch( RenderingInterruptedException rie )
{
System.out.println( "Rendering interrupted" );
+ interrupted = true;
}
return null;
}
@@ -45,16 +52,23 @@ public class TestJSurf
br.execute();
long t = System.currentTimeMillis();
- Thread.sleep( 100 );
-
System.out.println( "Attempting to stop rendering" );
- asr.stopDrawing();
+ for (int i = 0; i < 100; ) {
+ try
+ {
+ asr.stopDrawing();
+ br.get(100, TimeUnit.MILLISECONDS);
+ break;
+ }
+ catch (InterruptedException e) {}
+ catch (ExecutionException e) {}
+ catch (TimeoutException e) {}
+ }
- br.get();
t = System.currentTimeMillis() - t;
System.out.println( "Render method finished after " + t + "ms" );
- Assert.assertTrue( "stopDrawing must interrupt and stop the rendering process", t < 200 );
+ Assert.assertTrue( "stopDrawing must interrupt and stop the rendering process", br.interrupted );
}
@Test
--- End Message ---
--- Begin Message ---
Source: jsurf-alggeo
Source-Version: 0.4.1+ds-6
Done: Jerome Benoit <[email protected]>
We believe that the bug you reported is fixed in the latest version of
jsurf-alggeo, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jerome Benoit <[email protected]> (supplier of updated jsurf-alggeo package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 12 Apr 2025 18:21:05 +0000
Source: jsurf-alggeo
Architecture: source
Version: 0.4.1+ds-6
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers
<[email protected]>
Changed-By: Jerome Benoit <[email protected]>
Closes: 1032096
Changes:
jsurf-alggeo (0.4.1+ds-6) unstable; urgency=medium
.
* Debianization:
- d/patches/*:
- d/p/check-interrupted-status.patch, introduce
(thanks to Vladimir Petko <[email protected]>,
closes: #1032096).
Checksums-Sha1:
184e049777fc7df4ea4437f8de90d0424fc567c3 2956 jsurf-alggeo_0.4.1+ds-6.dsc
b8d217253d0acfee7b328a8c0158d22cb78849b5 16552
jsurf-alggeo_0.4.1+ds-6.debian.tar.xz
6994605baf293e1fed914e65f845e23a68ebfd97 9072
jsurf-alggeo_0.4.1+ds-6_source.buildinfo
Checksums-Sha256:
906431cee85ed82f72a70b104f093367397141b6d361495d5ae1b41600374a94 2956
jsurf-alggeo_0.4.1+ds-6.dsc
871a445ffb287102a20f8fae6bd5287b53acfd5928865cf024564f06a42ccd86 16552
jsurf-alggeo_0.4.1+ds-6.debian.tar.xz
71061893ac04c14c5c174a63b05cef2d9045b3e5008dd455417481b0e459e827 9072
jsurf-alggeo_0.4.1+ds-6_source.buildinfo
Files:
0d3ccf767a2ab4aaf7e2f9211bb3fb37 2956 math optional jsurf-alggeo_0.4.1+ds-6.dsc
20d7f77d94149b5957d5349deb35b06b 16552 math optional
jsurf-alggeo_0.4.1+ds-6.debian.tar.xz
08dc0806bfb740b672e212291b7d0fed 9072 math optional
jsurf-alggeo_0.4.1+ds-6_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQRJBAEBCgAzFiEEriiuFXEN/x2H5adiP5IZpn82xosFAmf6r6cVHGNhbGN1bHVz
QHJlem96ZXIubmV0AAoJED+SGaZ/NsaLJDggAKV4ClwcL4CmJMoJvt4POV9s3bwf
pS/q3dVB8uaLFVsI8+UA6mTn21TjoHCKom3BZnd6XsCh51Bl7wSK1eWgwPY+FF53
YBP6h5LbtyHAoIMxG1Q31fYMVwyVGhd3oexckcvcv3aaaiiUr/HjaiyOqy160CZM
YO0tG5uqmVUaiewNJvc2hTaxQG7VTyPwJ/OmUVLSy1zQRxAEBwTledNrs0SvUkG/
zpI2ZMH3SfDZGIafhxEtoRFYlfdE4klSCmoZ/J+L1qtKNnh+o6Xaxw/0SUlU5gCA
nbposRh7eV3tornwep1AEZoA96IgfiUVFrTQYy0/kdLtRsfWSO/zmDQiwHdWdJeN
fRCU6/S3d/IS7CQcghAUQvctJk2fM6ZMcPwE4lTXk9W8TcF/UhAwX8jRhEWdEYPQ
6fXesdH4slgpyNr/aInG9JwoDsMjD2414AYSs0IwMcVigz4ZTM2XgWmMvmuWByVd
Ntd4MyNVEF34pvNFW5zw43b3IAQ7yui3lC5CGln5g+gtu3vLHyPEyHjUJoiGYsSI
pJDtl3onw67OWRccu44faf8+00ikBRUcdHhEMYWj/Hwe5kE5e6KSX+bftIiqRt91
ZOR2o/h1Ldb5hSYrNYFj2v98NDctuNaLlXK9teGJJnOKnudRzg1PQo5Y2lvkIrTs
nnCHfH5rv11uN2t0DhVyMul0rSBRr2a80ubFbwIPbwU40XEt/UJICu1iQjTD3/gN
zJv+DhXbH3tnH+6wg/sWuHbGfLj6Gb1CpwgpRa6vtuhPvL7f2MZuaYW3fCBDO7X/
YokJGb/RFEQQE/ByG+m37n8VCQBS5kKn5idsZq6nyoHe6VJZvMrZYOXoVs5cHaAh
maHm3LjpQsSxGTPXaofg2jfQegbUXfSgXc9BRkSvXcV0LsaAFTTJ9Y8izJEgzrhP
RQUrGY4OwD2gUVAHxSiIJbur0GrFfA5U9rcvC3IedigpdRnCj2zsZnba4fSUad7d
mfSujcOkYTbFocXS6bSBwYpNmDPK9fCMLk/JU20jaQPVv2aooRR/AaeptAdrPYme
/mItDfil7GxHgLWrf8KMPsw+wmpaRkoEwxQ5VPicQAEXFObrq8TorfelFgrZXvsG
Wh874rqM++x/nzs4982jGySEDo7tzhLLcNd4xsXSpQr9/8ZAAJ/DEj28uuGaRhDz
S4Va7yPZR0TWNttz9giFCQuEppQXsm3n/Ohb2KW0qdT6kGJV0bf2rQGGqjXjzxmq
EeGy+twXW3cxOyS7AWhXf6SqvXhL+XLIppvOcUJFuwq3FrQ4zJCZ+8R97LLrtGgA
lRai6b5OSlFWrI74wa4lLkDyCmXZqqw3/jNPNV5sXgdBVb+dithSPv1l/80=
=LAxD
-----END PGP SIGNATURE-----
pgpkMpCcuWpQB.pgp
Description: PGP signature
--- End Message ---
--
debian-science-maintainers mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-science-maintainers
