Thanks for your diligence in preparing this update and addressing the
previous points. I've taken a look and found a few remaining DFSG
details that need addressing before we can proceed:

- The files under `packages/kokkos/` and `packages/kokkos-kernels/`
have been updated with the LLVM exception, but the actual copyright
holder string "Contributors to the Kokkos project" (which appears in
thousands of files, e.g.,
`packages/kokkos-kernels/batched/KokkosBatched_Util.cpp`) is still
entirely missing from `debian/copyright`.

- While the catch-all stanza now includes "Sandia National
Laboratories", there are still verbatim copyright notices that have
been normalized or omitted. For example, "Sandia Corporation" appears
in files like `packages/belos/tpetra/example/LSQR/LSQRTpetraExFile.cpp`
and "National Technology Engineering Solutions of Sandia, LLC"
(without the ampersand) appears in `packages/krino/` headers. These
should be mirrored verbatim.

- I noticed a slight slip in authorship for the generated EPS files.
`packages/pamgen/rtcompiler/diag1.eps` and `diag2.eps` attribute
copyright to "artofcode LLC, Benicia, CA", but this author is missing
from `debian/copyright`.

Please update the copyright file in your next upload.

-rt

Further information may be found at:
   https://dfsg-new-queue.debian.org/reviews/trilinos

Regards, Reinhard Tartler
Member of the DFSG, Licensing & New Packages Team



===

Please feel free to respond to this email if you don't understand why
your files were rejected, or if you upload new files which address our
concerns.

Attachment: pgpkVeIaL6zDk.pgp
Description: PGP signature

-- 
debian-science-maintainers mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-science-maintainers

Reply via email to