Source: eigen3
Version: 3.3~beta1-2
Severity: minor
Tags: upstream patch

Dear Maintainer,

While packaging salmon, which uses libeigen3-dev, lintian pointed out a grammer
error that I traced back to this package ("allow to" instead of "allow one
to").

I've made a patch and attached it.

Cheers,

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.3.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
commit 81c301689ffac8687b2451decb9c0eb001eb6e3e
Author: Michael R. Crusoe <[email protected]>
Date:   Sat Jan 30 09:48:16 2016 -0800

    correct grammer error

diff --git a/debian/patches/10_grammer_tweak.patch b/debian/patches/10_grammer_tweak.patch
new file mode 100644
index 0000000..8bb9682
--- /dev/null
+++ b/debian/patches/10_grammer_tweak.patch
@@ -0,0 +1,34 @@
+Author: Michael R. Crusoe <[email protected]>
+Description: Correct grammer error found by lintian which can leak into other
+projects.
+--- eigen3.orig/Eigen/src/Core/DenseBase.h
++++ eigen3/Eigen/src/Core/DenseBase.h
+@@ -246,7 +246,7 @@
+     {
+       EIGEN_ONLY_USED_FOR_DEBUG(newSize);
+       eigen_assert(newSize == this->size()
+-                && "DenseBase::resize() does not actually allow to resize.");
++                && "DenseBase::resize() does not actually allow one to resize.");
+     }
+     /** Only plain matrices/arrays, not expressions, may be resized; therefore the only useful resize methods are
+       * Matrix::resize() and Array::resize(). The present method only asserts that the new size equals the old size, and does
+@@ -258,7 +258,7 @@
+       EIGEN_ONLY_USED_FOR_DEBUG(rows);
+       EIGEN_ONLY_USED_FOR_DEBUG(cols);
+       eigen_assert(rows == this->rows() && cols == this->cols()
+-                && "DenseBase::resize() does not actually allow to resize.");
++                && "DenseBase::resize() does not actually allow one to resize.");
+     }
+ 
+ #ifndef EIGEN_PARSED_BY_DOXYGEN
+--- eigen3.orig/Eigen/src/SparseCore/SparseSelfAdjointView.h
++++ eigen3/Eigen/src/SparseCore/SparseSelfAdjointView.h
+@@ -153,7 +153,7 @@
+       EIGEN_ONLY_USED_FOR_DEBUG(rows);
+       EIGEN_ONLY_USED_FOR_DEBUG(cols);
+       eigen_assert(rows == this->rows() && cols == this->cols()
+-                && "SparseSelfadjointView::resize() does not actually allow to resize.");
++                && "SparseSelfadjointView::resize() does not actually allow one to resize.");
+     }
+     
+   protected:
diff --git a/debian/patches/series b/debian/patches/series
index 5ba5222..31dfa14 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -5,3 +5,4 @@
 07_remove_compressed_doc.patch
 08_fix_path_FindEigen3.patch
 09_fix_1144.patch
+10_grammer_tweak.patch
-- 
debian-science-maintainers mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Reply via email to