Your message dated Fri, 02 Sep 2016 10:11:36 +0000 with message-id <[email protected]> and subject line Bug#835627: fixed in ros-rospack 2.3.0-4 has caused the Debian Bug report #835627, regarding ros-rospack: FTBFS on hurd-i386 to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 835627: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=835627 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Source: ros-rospack Version: 2.3.0-3 Severity: important Tags: patch User: [email protected] Usertags: hurd HI, ros-rospack currently FTBFS on GNU/Hurd since 2.3.0-3 when the unit tests were enabled. This is due to usage of PATH_MAX in file test/test/utest.cpp. The attached patch fixes this by using getcwd(NULL, 0) to allocate space, populate path and free it after usage. As all Debian architectures support this usage of getcwd() no harm would be done. All tests succeed on GNU/Hurd too. Thanks!Index: ros-rospack-2.3.0/test/test/utest.cpp =================================================================== --- ros-rospack-2.3.0.orig/test/test/utest.cpp +++ ros-rospack-2.3.0/test/test/utest.cpp @@ -231,8 +231,8 @@ int main(int argc, char **argv) char buf[1024]; std::string rr = std::string(getcwd(buf, sizeof(buf))) + "/test2"; setenv("ROS_PACKAGE_PATH", rr.c_str(), 1); - char path[PATH_MAX]; - if(getcwd(path,sizeof(path))) + char *path = getcwd(NULL, 0); + if(path) { boost::filesystem::path p(path); p = p.parent_path(); @@ -243,6 +243,7 @@ int main(int argc, char **argv) setenv("PATH", newpath.c_str(), 1); } + free(path); testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); }
--- End Message ---
--- Begin Message ---Source: ros-rospack Source-Version: 2.3.0-4 We believe that the bug you reported is fixed in the latest version of ros-rospack, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Jochen Sprickerhof <[email protected]> (supplier of updated ros-rospack package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Fri, 02 Sep 2016 10:58:10 +0200 Source: ros-rospack Binary: librospack-dev librospack0d rospack-tools Architecture: source Version: 2.3.0-4 Distribution: unstable Urgency: medium Maintainer: Debian Science Maintainers <[email protected]> Changed-By: Jochen Sprickerhof <[email protected]> Description: librospack-dev - Robot OS package information library header files librospack0d - Robot OS package information library rospack-tools - command-line tool for retrieving information about Robot OS packa Closes: 835627 Changes: ros-rospack (2.3.0-4) unstable; urgency=medium . * Update URLs * Update my email address * Add Patch for FTBFS on hurd-i386. Thanks to Svante Signell (Closes: #835627) Checksums-Sha1: 84ef5c0c1902eea85c0fba7f8fbc4ddd05a50cc8 2374 ros-rospack_2.3.0-4.dsc 01f90e74784b2f8d5f009ef46565c9659ffedbc5 6044 ros-rospack_2.3.0-4.debian.tar.xz Checksums-Sha256: 169759a15e90e978e20a92174412cf670943019aadb9bd9e7585c58cdf1473a7 2374 ros-rospack_2.3.0-4.dsc d643eca16f9a8270f0e345b5787652485652bfaf3136e70bb25c210a8c2d3c23 6044 ros-rospack_2.3.0-4.debian.tar.xz Files: 4cf58c89e8b4f1960ca8b06dc6c0d118 2374 libs optional ros-rospack_2.3.0-4.dsc 7221da4a168bb4efd6ee47c40af8575b 6044 libs optional ros-rospack_2.3.0-4.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQIxBAEBCgAbBQJXyT9TFBxqc3ByaWNrZUBkZWJpYW4ub3JnAAoJEFv/3MJY5pQz 7ZgP/3JJr3uYnMMhusu5QR3ITrYdA1LcKilzWG0Vgdi+TbkHtJF5nRyufjltd/H+ shBGrV8L0R5Jz2QHH3ZOklb4OS9bPunn7CipnBtWGCIyvi+9HM1uu5ywqpbC0j9Y PHopHjTvLP+NDuzneb1kb0l/8czjUqnFTQGOEsQrclXD7KluhUV3c2WJ6zCFxfXV bBWnCjC6nG0ZhmGz3O5dOFQhh4QgSGWDaiIxFxqaXJuoWMiClImZP+u6dA34DYq9 Rii0hVLx9IgeWbnSDldiJZl9poU17kx39fUuXL29MzhA8EofHLC3iO71UtCUUXbl iyjTWdGNUQaV8VAdjhhHejpZCchxNDu90evenHxRuHkfopD8ec550OB6pHDMIsfH qpr7WuCD9rto/W+VkuTZ7sRwQE9Q0FaW/Uu2/ZpmDU+Rng6FNhvrOwGAVMHvUAw2 3vusJi5uPd/19rkHzfykJ71gI8bFETYYfYJl7/yXDwuDc4lwrhcBXPbZ6OlEGTNz BSTU9uPDa/HbRp23VQDsDpQ9YaeIlNSdq7SmtJ70i5Z2GAax3+DWIXu+YtC2Cqi8 xD1Q/hKhuN6xLgH7q5kSmDPwZY50vS6egIqGOD3b6HwVwWkHS+tVaEmkMsTylTEP otFgRZ77Z9aZo+7uwyjVupEy1vgXfb6Rp5gwUr3m8mDfxTVb =RsIU -----END PGP SIGNATURE-----
--- End Message ---
-- debian-science-maintainers mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
