Your message dated Sun, 08 Jan 2017 19:48:29 +0000 with message-id <[email protected]> and subject line Bug#837315: fixed in gnuplot 5.0.5+dfsg1-5 has caused the Debian Bug report #837315, regarding gnuplot-nox: possibly unnecessary patch 05_default_gd_font.diff to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 837315: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837315 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: gnuplot-nox Version: 5.0.4+dfsg1-3 Severity: minor Hi there, I believe the patch 05_default_gd_font.diff that is applied to the Debian gnuplot package is not necessary (anymore?). In turn, I believe it is even quite counter-productive. Let's have a look at the code that the patch changes: if (external_default) png_state.ttffont = gp_strdup(external_default); else /* Might as well try some plausible font; it's no orse than failing immediately */ png_state.ttffont = gp_strdup("arial"); free(png_state.default_ttffont); png_state.default_ttffont = gp_strdup(png_state.ttffont); if (png_state.default_ttfsize == 0) png_state.default_ttfsize = 2 * term->h_char - 2; /* First try the old GDFONTPATH mechanism for locating fonts */ (void)gdUseFontConfig(0); err = gdImageStringFT(NULL, &brect[0], 0, png_state.ttffont, (double)png_state.default_ttfsize*png_state.fontscale, 0.0, 0, 0, "test"); /* If that didn't work, try again using fontconfig mechanism */ if (err && gdUseFontConfig(1)) { err = gdImageStringFT(NULL, &brect[0], 0, png_state.ttffont, (double)png_state.default_ttfsize*png_state.fontscale, 0.0, 0, 0, "test"); } In the first paragraph, if the external_default variable isn't set, the png_state.ttffont pointer is set to point to the string "arial". This is the string that is replaced by the patch in question by the actual path name of the Sans Liberation Regular TTF font file. Let's ignore the second paragraph. The third paragraph attempts to locate a font by that name *without* using fontconfig. This is probably about to fail for "arial" as well as for most other fonts, as the number of font names recognized by the gd library itself is rather limited. This paragraph is probably only interesting if the external_default variable is set. In the fourth paragraph the font location is attempted again, this time using fontconfig. This is the most interesting part of the code. As the gd library in Debian is configured with fontconfig support, it will try to find the font that matches the search pattern "arial" as good as possible. On most systems which have fonts-liberation installed, it will most probably return Liberation Sans Regular, which is exactly what the patch attempts to achieve. But if you have the actual Arial font from the msttcorefonts package installed, it will find and use this. And if you have neither the original Arial nor the Liberation Sans replacement installed, it will find another font that matches Arial as closely as possible, because it has dozens of rules to determine which font is a good replacement for what. This is where the patch becomes counter-productive: By passing the full path to the Liberation font to fontconfig, you take away its ability to substitute this font for something similar and force it to fall back to the default font if the requested one is not found. TL;DR: Please consider disabling this patch. Fontconfig already does what this patch wants to achieve and acts more reasonable if the font that is hard-coded by the patch cannot be found. Thanks, Fabian -- System Information: Debian Release: stretch/sid APT prefers testing APT policy: (990, 'testing'), (500, 'experimental'), (500, 'unstable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.6.0-1-amd64 (SMP w/4 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system)
--- End Message ---
--- Begin Message ---Source: gnuplot Source-Version: 5.0.5+dfsg1-5 We believe that the bug you reported is fixed in the latest version of gnuplot, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Anton Gladky <[email protected]> (supplier of updated gnuplot package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Sun, 08 Jan 2017 20:39:38 +0100 Source: gnuplot Binary: gnuplot gnuplot-doc gnuplot-nox gnuplot-qt gnuplot-x11 gnuplot-data gnuplot5 gnuplot5-nox gnuplot5-x11 gnuplot5-qt Architecture: source Version: 5.0.5+dfsg1-5 Distribution: unstable Urgency: medium Maintainer: Debian Science Team <[email protected]> Changed-By: Anton Gladky <[email protected]> Description: gnuplot - Command-line driven interactive plotting program, version 5 gnuplot-data - Command-line driven interactive plotting program. Data-files gnuplot-doc - Command-line driven interactive plotting program. Doc-package gnuplot-nox - Command-line driven interactive plotting program. No-X package gnuplot-qt - Command-line driven interactive plotting program. QT-package gnuplot-x11 - Command-line driven interactive plotting program. X-package gnuplot5 - transitional package gnuplot5-nox - transitional package gnuplot5-qt - transitional package gnuplot5-x11 - transitional package Closes: 837315 844461 846988 Changes: gnuplot (5.0.5+dfsg1-5) unstable; urgency=medium . [ Anton Gladky ] * [82388b2] Remove outdated info-patch. (Closes: #844461) * [76f823f] Remove outdated font-patch. (Closes: #837315) . [ Rob Browning ] * [9a662e6] Change build dependency to "emacs25-nox | emacs25 | emacs24" to support and prefer emacs25. (Closes: #846988) Checksums-Sha1: d044984d907f36689c73ef6e3b75fbc17fb8bd0a 2948 gnuplot_5.0.5+dfsg1-5.dsc 88dfd851ae09b7dcb38b8d17e1a7b2bdc65c6753 28560 gnuplot_5.0.5+dfsg1-5.debian.tar.xz Checksums-Sha256: 4a6cc1e56aafbf3ad2371935ea35af331c11d88eb7766da96552701ce45148b0 2948 gnuplot_5.0.5+dfsg1-5.dsc ebb1dc9b42d53fd17834eee378c0589e47fe1e369cd38c1ce8b21f81d4b669de 28560 gnuplot_5.0.5+dfsg1-5.debian.tar.xz Files: bd49c49bf59d5a0d4dd0051265623f11 2948 math optional gnuplot_5.0.5+dfsg1-5.dsc f454edd9a6ad1ba9f313f7004788549c 28560 math optional gnuplot_5.0.5+dfsg1-5.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEu71F6oGKuG/2fnKF0+Fzg8+n/wYFAlhyla8ACgkQ0+Fzg8+n /waeiw/+OfYHRsDp1r9bTF8k01Yik5TXCzQYJxECEnTOJJYNnEMm+a5ccAaKyXOm wm5uezI+DyjCXl1FtjYyuRdR2hGWVzNhMwXEY7RX+djyI0KHixBwc9UEKjrg3gLZ ky9h608luJoNB3DGu3UY6ki4X8LDzbsS8DsihhlMlF2zUxG6TN6yc7XX75aRsRKd FX/G99ay6siGPVuBkOOoi9LCST+t49M5qSjhqI6uJMba4wLC0Q3kj0ro5vNEELs2 nvZnfKt8agMoaAaKo+747iZAoWD2rBnil4XuXrIgHV9slbnvCT2cpw5GKzH3WrQR ETTSofmU3l+1yxJ7U9ylvwSsHgVAS6CeFmynwTK7qh94t+KHjlXQOGXzhsytboL7 bTwVCTnn3zx4Op3TH6Fu1xKgsTnk2UshLgp/M6dpwS43oBmqmdsghF30t/V0h8Lz JrY1LjIlwesDAKHa8OT846UB2smjst+U8AR8T22NXvajzRkd3R52WXhiUgwu8Jmb j9A9LOUBSJqpAG8JnyMSXha7bMgbBGDjW7UX7mp4xWN1sQfh526zE0/+vD6hyWHR rzPViVKFnCtGWlP2LpXI4oqhzawhe9KyISqWSsH+4k7S5CB2jydNcrcYNKSQMNqO ubF6PcE2oPCHpvbkyY+Nt5jVFVkVhXZERHk5nUNw//uosbLQrZM= =Mp8w -----END PGP SIGNATURE-----
--- End Message ---
-- debian-science-maintainers mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
