Your message dated Sun, 13 Aug 2017 15:19:18 +0000
with message-id <[email protected]>
and subject line Bug#862090: fixed in mathicgb 1.0~git20170606-1
has caused the Debian Bug report #862090,
regarding mathicgb FTBFS on big endian architectures: test fails
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
862090: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=862090
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: mathicgb
Version: 1.0~git20170104-1
Severity: important
Tags: sid + patch
Justification: FTBFS
User: [email protected]
Usertags: mips-patch

Hello,

Package mathicgb_1.0~git20170104-1 FTBFS on mips and other big endian 
architectures with following error:

>...
> make  check-TESTS
> make[2]: Entering directory '/«PKGBUILDDIR»'
> make[3]: Entering directory '/«PKGBUILDDIR»'
> FAIL: unittest
> ====================================
>    mathicgb 1.0: ./test-suite.log
> ====================================
> 
> # TOTAL: 1
> # PASS:  0
> # SKIP:  0
> # XFAIL: 0
> # FAIL:  1
> # XPASS: 0
> # ERROR: 0
> 
> .. contents:: :depth: 2
> 
> FAIL: unittest
> ==============
> ...

Full build log:
https://buildd.debian.org/status/fetch.php?pkg=mathicgb&arch=mips&ver=1.0~git20170104-1&stamp=1486639289&raw=0

On upstream this issue is resolved with proposed commit:
https://github.com/Macaulay2/mathicgb/pull/9/commits/d8ae074c7f7655c3b85c2089cd7a05a98a70a46a

I have attached the patch.

With this patch package builds successfully on mips and mipsel.


Regards,
Radovan
--- mathicgb-1.0~git20170104.orig/src/mathicgb/MonoMonoid.hpp
+++ mathicgb-1.0~git20170104/src/mathicgb/MonoMonoid.hpp
@@ -582,13 +582,9 @@ public:
       MATHICGB_ASSERT(i == varCount() / 2 || access(a, i*2+1) >= 0);
       
       uint64 A, B, AB;
-      // We have to use std::memcpy here because just casting to a int64 breaks
-      // the strict aliasing rule which implies undefined behavior. Both MSVC and
-      // gcc don't actually call memcpy here. MSVC is a tiny bit slower for this
-      // code than for casting while GCC seems to be exactly the same speed.
-      std::memcpy(&A, ptr(a, i*2), 8);
-      std::memcpy(&B, ptr(b, i*2), 8);
-      std::memcpy(&AB, ptr(ab, i*2), 8);
+      A = *ptr(a, i*2) | (((uint64)*ptr(a, i*2 + 1)) << 32);
+      B = *ptr(b, i*2) | (((uint64)*ptr(b, i*2 + 1)) << 32);
+      AB = *ptr(ab, i*2) | (((uint64)*ptr(ab, i*2 + 1)) << 32);
       orOfXor |= AB ^ (A + B);
     }
     MATHICGB_ASSERT((orOfXor == 0) == isProductOf(a, b, ab));
@@ -608,11 +604,11 @@ public:
     uint64 orOfXor = 0;
     for (VarIndex i = varCount() / 2; i != beforeEntriesIndexBegin(); --i) {
       uint64 A1, A2, B, A1B, A2B;
-      std::memcpy(&A1, ptr(a1, i*2), 8);
-      std::memcpy(&A2, ptr(a2, i*2), 8);
-      std::memcpy(&B, ptr(b, i*2), 8);
-      std::memcpy(&A1B, ptr(a1b, i*2), 8);
-      std::memcpy(&A2B, ptr(a2b, i*2), 8);
+      A1 = *ptr(a1, i*2) | (((uint64)*ptr(a1, i*2 + 1)) << 32);
+      A2 = *ptr(a2, i*2) | (((uint64)*ptr(a2, i*2 + 1)) << 32);
+      B = *ptr(b, i*2) | (((uint64)*ptr(b, i*2 + 1)) << 32);
+      A1B = *ptr(a1b, i*2) | (((uint64)*ptr(a1b, i*2 + 1)) << 32);
+      A2B = *ptr(a2b, i*2) | (((uint64)*ptr(a2b, i*2 + 1)) << 32);
       orOfXor |= (A1B ^ (A1 + B)) | (A2B ^ (A2 + B));
     }
     MATHICGB_ASSERT

--- End Message ---
--- Begin Message ---
Source: mathicgb
Source-Version: 1.0~git20170606-1

We believe that the bug you reported is fixed in the latest version of
mathicgb, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Doug Torrance <[email protected]> (supplier of updated mathicgb package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 12 Aug 2017 18:33:51 -0400
Source: mathicgb
Binary: mathicgb libmathicgb-dev libmathicgb0
Architecture: source
Version: 1.0~git20170606-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers 
<[email protected]>
Changed-By: Doug Torrance <[email protected]>
Description:
 libmathicgb-dev - Compute Groebner bases (developer tools)
 libmathicgb0 - Compute Groebner bases (runtime library)
 mathicgb   - Compute Groebner bases (command line tool)
Closes: 862090
Changes:
 mathicgb (1.0~git20170606-1) unstable; urgency=medium
 .
   * New upstream release (git snapshot).
   * debian/compat
     - Bump debhelper compatibility level to 10.
   * debian/control
     - Set priority to optional.
     - Bump versioned dependency on debhelper to >= 10.
     - Remove dh-autoreconf from Build-Depends.
     - Bump Standards-Version to 4.0.1.
   * debian/copyright
     - Use https in Format.
   * debian/mathicgb.docs
     - Rename from just 'docs' for clarity.
   * debian/patches/big-endian.patch
     - New patch; fix tests on big-endian architectures (Closes: #862090).
   * debian/patches/link-deps.patch
     - New patch; properly link against mathic and memtailor.
   * debian/rules
     - Remove call to dh_autoreconf; now default with debhelper 10.
Checksums-Sha1:
 8863ab23a6780b1cc5e9273edde8be7a3cd9b1a6 2401 mathicgb_1.0~git20170606-1.dsc
 ce761c14b5035048f0a5c22e09b658f94f629908 699019 
mathicgb_1.0~git20170606.orig.tar.gz
 3624de4f5bd7945df6358d9fce3c2742a04877f7 5280 
mathicgb_1.0~git20170606-1.debian.tar.xz
 dde661b7bd3635594093534b450d3ae4f920530b 7263 
mathicgb_1.0~git20170606-1_amd64.buildinfo
Checksums-Sha256:
 4c4c57634946843520c2765fa276ecca6b0b1f8768b0a9257a2e7b0f074b4071 2401 
mathicgb_1.0~git20170606-1.dsc
 8e31d2c051ca39963be1f67cd01fe6d1bbab97e065d4671e1442167ee38f861a 699019 
mathicgb_1.0~git20170606.orig.tar.gz
 f54ccb45daec040fd392e521c03d3a0cb3e90d8ad62e40934fea30865ef4cc7f 5280 
mathicgb_1.0~git20170606-1.debian.tar.xz
 fa2d5f5e3c1bb56f32927c5588901f6e5801b07a4cef4a4d17ea2ff6d2f9549d 7263 
mathicgb_1.0~git20170606-1_amd64.buildinfo
Files:
 4aaa2266fbd8cfbd1f279c83b4f60c51 2401 math optional 
mathicgb_1.0~git20170606-1.dsc
 e732dc4bbd9251be50a8b6a428e57e6c 699019 math optional 
mathicgb_1.0~git20170606.orig.tar.gz
 4acee3d49d686620faf8d9cf9d5a0485 5280 math optional 
mathicgb_1.0~git20170606-1.debian.tar.xz
 23bb4d340716628ff85d75ed0713957e 7263 math optional 
mathicgb_1.0~git20170606-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEU5UdlScuDFuCvoxKLOzpNQ7OvkoFAlmQavIACgkQLOzpNQ7O
vkqCIA//avpCo9Ti21yuTfsPvgUD7SCblaQOazcYwJYjQ5y7Q1rj4sK1IP4tH1B/
K2w80KyrlQc+4idZaz2Z42OKPBqdB74b7tvWZGPZZPTz/a/OM+C4TiieBRLewdWd
1QRnROHizDhnfI5A7iJEmmAMFfA1fviF6IqvUneZaaeDSnynRIwNpyNbXgBXsflQ
5Yey03NwhZr9gBADsfhwrjMIttNHroYEn9PVVA3oT7UnHMIQ1kfDp7+GAYgkDFIN
GrC+6RsDdOtn9SMqmN/IcPxeU5/k5Q3WJkJBVUiO9WQTmJNmqOcEvJdDZMzjCe6c
nJM47WMTyY8WS6U2TFWjQLegrQCiQ4gP5BZjB54PE5mA3zfW3GytHq+Cbz8sPmeh
UfLDohg/K+eb/UHaFlLL5YPO43Q2mY5wTRn1D1HcTP+sbrvzl0VQwrtX9zw6vj3y
DG8TClVQgYR0S13M3hm8KfgVLaISyqnpeeyqihHptlAfdZZ2js8BohbbVlHLjqZJ
l1Pg+/Nn6viETFDYm4io6Gi7dyQczopd3BEMvhhIam6UQ/6uSlqQiM+s0C48HKVj
TKhEI+GUpRQ0xVsgAXDz4YcHgK1WMog6n05B3d2c41eYacAtB6Do83v57CnCap2E
UjYVl2k5vlV0c1ojszihjJCZ5P6pHhjdXQ+i9NgLnHUyGtGpsfc=
=b4qF
-----END PGP SIGNATURE-----

--- End Message ---
-- 
debian-science-maintainers mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Reply via email to