Hi Leopold, I noticed that you tried to follow my Sponsering of Blends procedure[1] and injected some data to the robotics tasks. That's great and it is really welcome. I always like to teach at these examples who to do this properly and efficiently. So let me comment your changes first:
On Wed, Oct 30, 2013 at 07:56:09AM -0000, [email protected] wrote: > Author: lepalom-guest > Date: Wed Oct 30 07:56:09 2013 > New Revision: 3898 > > URL: http://svn.debian.org/wsvn/blends/?sc=1&rev=3898 > Log: > Added ompl package to the robotics(-dev) task. > > Modified: > projects/science/trunk/debian-science/tasks/robotics > projects/science/trunk/debian-science/tasks/robotics-dev > > Modified: projects/science/trunk/debian-science/tasks/robotics > URL: > http://svn.debian.org/wsvn/blends/projects/science/trunk/debian-science/tasks/robotics?rev=3898&op=diff > ============================================================================== > --- projects/science/trunk/debian-science/tasks/robotics (original) > +++ projects/science/trunk/debian-science/tasks/robotics Wed Oct 30 > 07:56:09 2013 > @@ -212,6 +212,18 @@ > and bigger frameworks. An important target application is industrial > robotics automation. > > +Package: ompl > +Homepage: http://ompl.kavrakilab.org > +License: BSD-3-clause > +Responsible: Leopold Palomo-Avellaneda <[email protected]> > +WNPP: 706133 > +Pkg-Description: Sampling-based motion planning library > + Consists of a set of sampling-based motion planning > + algorithms. The content of the library is limited to these algorithms, > + which means there is no environment specification, no collision > + detection or visualization. The library is designed so it can be easily > + integrated into systems that provide the additional needed components. > + Comments: 1. You never should use the "Package" field when specifying package dependencies in a task file. It is always Depends / Recommends / Suggests (see [2]). 2. The specified dependency should be a binary package name which correlates to a binary package name in your debian/control file. You specified the source package name 'ompl' - but you can not depend from a source package. I changed this to ompl-demos and used "Suggests" (since this sounded appropriate to me - feel free to change this to "Depends"). 3. You have specified several fields in addition to the Suggests field. This is not necessary any more if you have injected the packaging into the team VCS. It is probably not properly documented in [2] (feel free to send a patch) but all these data are obtained automatically to safe your time in maintaining the tasks file. To demonstrate this I removed those fields that were overriden anyway by the packaging content. The only field I left untouched was WNPP. The reason is a problem in your debian/changelog file (see below for the sponsoring comments). > Suggests: libcoin60-runtime, libvtk5.4 > > > Modified: projects/science/trunk/debian-science/tasks/robotics-dev > URL: > http://svn.debian.org/wsvn/blends/projects/science/trunk/debian-science/tasks/robotics-dev?rev=3898&op=diff > ============================================================================== > --- projects/science/trunk/debian-science/tasks/robotics-dev (original) > +++ projects/science/trunk/debian-science/tasks/robotics-dev Wed Oct 30 > 07:56:09 2013 > @@ -13,3 +13,15 @@ > Depends: libcnoid-dev > > Depends: libode-dev > + > +Package: libompl-dev > +Homepage: http://ompl.kavrakilab.org > +License: BSD-3-clause > +Responsible: Leopold Palomo-Avellaneda <[email protected]> > +WNPP: 706133 > +Pkg-Description: Sampling-based motion planning library development files > + Consists of a set of sampling-based motion planning > + algorithms. The content of the library is limited to these algorithms, > + which means there is no environment specification, no collision > + detection or visualization. The library is designed so it can be easily > + integrated into systems that provide the additional needed components. Comments: 1. Same as above - I did a s/Package/Depends/. 2. Here you correctly used the binary package name libompl-dev that exists in your packaging - that's fine. 3. Same as above - I just left the WNPP bug. Now my comments to your packaging[3] debian/changelog: - You are trying to close the ITP bug in an "historic" changelog paragraph (0.12.2-Source-1). This does not work. Bugs can only be closed in recent changelog entries (here is also the answer why this information is not parsed by the Blends tools - they are only regarding the latest changelog entry). - Moreover you are mentioning unstable as target distribution of those past entries. However, there was never any upload to unstable at all but these are rather all "UNRELEASED". Generally speaking: It does not make much sense to maintain a debian/changelog before the first version is really inside Debian. The history of the packaging can be obtained from the Git log. => Please drop old entries and leave only * Initial release (Closes: #706133) in the current entry. debian/README.Debian: - Please delete this file. The information is not relevant and just contained in the metadata of debian/copyright. debian/README.source: - Please delete this empty file as well. debian/control: - Please choose "Priority: extra". I guess I did mention it several times here on this list that extra is for *-dbg packages or things like this. - Pre-Depends: dpkg (>= 1.15.6~) What is the rationale for this? Usually it should not be needed. - Please give cme fix dpkg-control a try. I guess you will like the result. pristine-tar branch is missing: - If you imoprt the orig.tar.gz please use git import-orig --pristine-tar /path/to/package_version.orig.tar.gz to make sure your sponsor / team member can easily recreate a byte identical tarball. lintian warnings: - please check `lintian -I -i` and consider to fix some lintian nitpicking issues. So far for the sponsoring request. Kind regards Andreas. PS: I'll be less responsive until Sunday - please be patient or trust on other sponsors. [1] https://wiki.debian.org/DebianPureBlends/SoB [2] http://blends.alioth.debian.org/blends/ch-sentinel.en.html#s-edittasksfiles [3] git://git.debian.org/git/debian-science/packages/ompl.git -- http://fam-tille.de -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
