2015-03-29 9:53 GMT+01:00 Ghislain Vaillant <[email protected]>: > > Le 29 mars 2015 08:43, "PICCA Frederic-Emmanuel" < > [email protected]> a écrit : > > > > Hello Gishlain > > > > In your rules file we can see this. > > > > >ifneq ($(wildcard > /usr/lib/$(DEB_HOST_MULTIARCH)/hdf5/serial/libhdf5.so),) > > > export CPPFLAGS=-I/usr/include/hdf5/serial > > > export LDFLAGS=-Wl,-L/usr/lib/$(DEB_HOST_MULTIARCH)/hdf5/serial > > >endif > > > > It seems to me fragile. > > > > what about relying on pkgconfig to provide the right flags > > > > export CFLAGS=$(shell pkg-config --cflags hdf5) > > export LDFLAGS=$(shell pkg-config --libs hdf5) > > > > > > for the clean par , I propose this sort of target. > > > > # remove the .c cython generated files > > find h5py -iname *.pyx | sed -e 's,\.pyx,\.c,g' | xargs -r rm -f > > > > cheers > > > > > > Frederic > > Thanks for you suggestion for the clean rule. That's what I had in mind > too. > > For the compile and link flags, i believe they come from the latest nmu. > Your solution is more solid indeed. > > Cheers, > Ghis >
Regarding the cleaning of the cythonized c-files, there is actually a catch. The tarball shipped in pypi includes the c-files and gets overwritten on build. That would make the build and clean process a bit trickier I guess. The one released on Github does not ship the c-files. Is that ok if I use the Github one then ? Ghis
