Hi Anton, Thanks, I have done so now and pushed! I hope I have changed "watch" correctly to account for +dfsg.
regards, Steve On Thu, Apr 12, 2018 at 4:53 PM, Anton Gladky <[email protected]> wrote: > Hi Steve, > > I am ready to upload the package. But I would propose > you to remove not used 3rd-party source, adding them > into the d/copyright under the field "Flies-Excluded". > > Also please do not forget to add +dfsg prefix to the upstream > version. > > "uscan --download --repack" will create the stripped sources. > > Regards > > Anton > > > 2018-04-02 22:50 GMT+02:00 Stephen Sinclair <[email protected]>: >> Anton, >> >> Thank you very much for the review. >> >> On Thu, Mar 29, 2018 at 5:01 PM, Anton Gladky <[email protected]> wrote: >> >>> 1) Please clarify and add in d/copyright an information about >>> license of CSparse files. It is extremely important. >> >> Copyright added (LGPL-2.1+), an oversight thank you. The reason I >> forgot this is because it's not actually used by the library, as >> upstream has made it possible to link against system-installed >> cxsparse instead, which I take advantage of in rules. So an >> alternative could be to exclude these files from the archive. Is >> there a preference? >> >>> 2) I am not able to download the tarball using watch-file: >>> uscan --force-download >> >> Fixed. >> >>> 3) Apply cme fix dpkg >> >> Done. >> >>> Please fix those issues and I will upload the package. >> >> Thank you very much! >> >> Steve >> >> >>> 2018-03-26 18:54 GMT+02:00 Stephen Sinclair <[email protected]>: >>>> Hello science team, >>>> >>>> Attached is my sponsorship request for a new package "fclib", which is >>>> a very small C library for reading and writing files in a special HDF5 >>>> format oriented towards a collection of frictional contact problems. >>>> It is an eventual dependency for my siconos package. >>>> >>>> I am looking for a sponsor review and upload it. >>>> >>>> ITP: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894120 >>>> RFS: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894128 >>>> >>>> Library home page: https://frictionalcontactlibrary.github.io/index.html >>>> Salsa repo: https://salsa.debian.org/science-team/fclib >>>> >>>> regards, >>>> Steve
