Hello Anton, Thanks for your review.
On 09/01/2021 21:19, Anton Gladky wrote: > - please go through ALL files and put license information, if the > copyright is different from default one (check files in cmake-folder > and others) Done. > - tinyxml is packaged for Debian. Please try to use the packaged > version and drop an embedded one, if it is possible. There > should be a good reason not to use a packaged version of the > software. A private TinyXML is included in the source code, but it is NOT used to build the package since `libtinyxml-dev` is in the build dependencies in d/control and the `TinyXML_FOUND` is checked in extern/CMakeLists.txt Should I remove it from the source tarball as well? > - push pristine-tar branch Done. For some reason I didn't create the pristine branch when I originally imported the code, I created it now running: gbp pristine-tar commit ../robot-testing-framework_2.0.1.orig.tar.gz Is this the right way to do it? Anyway, I just pushed the changes on the repo and updated the package on mentor. Cheers, Daniele
