Ryo IGARASHI <rigar...@gmail.com> writes: > Looking at your patch, why do you delete all the #ifndef block in the > first place? Adding just "#define EIGEN_MALLOC_ALREADY_ALIGNED 0" line > on top of the #ifndef block should do the job.
That would work, but I don't think it makes a huge difference either way. The bigger patch is maybe a bit safer against future changes: I can imagine upstream changing/adding some logic to that big block that would re-define EIGEN_MALLOC_ALREADY_ALIGNED further down, making the one-line patch ineffective. In that situation the bigger patch would create a merge conflict, requiring human review, and the human would hopefully catch that. But again, I don't care a whole lot one way or the other
