Hello Sven,
You should now switch the Vcs-* fields to the new repository
https://salsa.debian.org/pkg-security-team/arno-iptables-firewall
I beleave you should drop ~rc4 suffix after the package version (2.0.3-1).
Now, for reviewing you use git commits, instead of uploading ~rc* packages
to mentors.
Samuel,
> you also don't have to check everything, feel free to send checklists of
the parts you checked and confirmed that are ok.
I've reviewed a bit.
[x] upstream tarball is imported correctly (checksum match).
[x] checked d/watch with uscan - works as expected, although it's unusual
to see uupdate running from d/watch.
[x] fr.po and sv.po are correctly converted to uft8
[x] d/control looks sane
[x] new d/arno-iptables-firewall.logrotate looks good
autopkgtest and d/templates look dependent on existence of ppp interface,
so it should be verified.
The diff is big (>2200 lines) mostly because of two converted .po files
and modified debian/{post,pre}* scripts.
I think these scripts should be reviewed after all other changes.
Best regards,
Aleksey
On Wed, Jan 2, 2019 at 4:02 AM Samuel Henrique <[email protected]> wrote:
> Hello Sven,
>
> I started looking at the package, but as there are a lot of changes in
> there, it will take some time until I can review and confirm that all of
> them are ok and we are close to the freeze. That's why I decided to upload
> the package to experimental for now, so it's also easier for other people
> to test the package.
>
> If anybody else from the team is also available, it would be great if we
> had more people reviewing it*, so we can make sure it will be available on
> Buster. I will try my best to review all of it and sponsor the package
> before 6th January nonetheless.
>
> Thanks for your work Sven.
>
> * Note that you don't have to be a DD or DM to review the package,
> everyone is welcomed and that's a good way of learning packaging, you also
> don't have to check everything, feel free to send checklists of the parts
> you checked and confirmed that are ok.
>
> --
> Samuel Henrique <samueloph>
>
