Hello Samuel, thanks for the quick reply!
I tested the package with this patch and it performs well as far as i can tell. I also tested it with your suggestion (appending -fcommon CFLAG) and it also builds and seems to work properly. Meanwhile upstream does not adopt a solution, i would prefer to stick with this hack as the use of -fcommon flag seems to be discouraged at least by Gentoo distro devs [1] Greetings, Marcos [1] https://wiki.gentoo.org/wiki/Gcc_10_porting_notes/fno_common El jue, 06-08-2020 a las 19:04 +0100, Samuel Henrique escribió: > Hello Marcos, > > Hmm, I'm kinda wary of the patch you picked[0], it has not been > reviewed by upstream yet and it's removing the variable definition > instead of making use of a declaration with "external" on the other > instance, that's also not what Arch is doing[1] (submitter mentions > that they found the issue on Arch). > > Are you confident that this fix won't introduce any issues and have > you considered instead to fix it by making use of the "-fcommon" > CFLAG[2]? > > [0] https://github.com/nmap/ncrack/pull/83 > [1] > https://github.com/archlinux/svntogit-community/tree/packages/ncrack/trunk > [2] https://gcc.gnu.org/gcc-10/porting_to.html#common > > Thanks, > > > -- > Samuel Henrique <samueloph>
