Your message dated Sat, 20 Dec 2025 17:34:55 +0000
with message-id <[email protected]>
and subject line Bug#1123730: fixed in faudio 25.12+dfsg-2
has caused the Debian Bug report #1123730,
regarding faudio: autopkgtest fails with sdl2-compat and only has superficial 
coverage with "classic" SDL2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1123730: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1123730
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: faudio
Severity: normal
Tags: patch
User: [email protected]
Usertags: regression

After discussion with SDL upstream, I'm looking into what needs to 
happen for Debian (and indirectly Ubuntu) to replace "classic" SDL2 with 
sdl2-compat, following in the footsteps of other distros like Arch and 
Fedora. sdl2-compat is a reimplementation of the SDL 2 API using SDL 3.

One issue that I've noticed is that ci.debian.net reports that the 
automated test for faudio has regressed when used with sdl2-compat as 
the default (all packages from Debian unstable, except sdl2-compat taken 
from experimental). This appears to be because of a behaviour change in 
the ALSA driver when no hardware is available. With "classic" SDL2, it 
reports zero devices, and FAudio gracefully fails to initialize, 
resulting in the vast majority of the test being skipped (5 out of about 
a thousand tests get run).

With sdl2-compat, the ALSA driver reports a placeholder device each for 
the default playback and recording devices, but opening those devices 
fails. The FAudio test suite does not handle failure to open a device 
gracefully, and eventually crashes.

I've reported the behaviour change to SDL upstream as 
https://github.com/libsdl-org/sdl2-compat/issues/562 so that they can 
assess whether this is something they want to change.

However, even if sdl2-compat does change its behaviour, I think it would 
be better if the faudio autopkgtest explicitly used the `dummy` SDL 
audio driver. This results in *much* better test coverage: instead of

> Finished with 5 successful tests and 0 failed tests.

for the current test with "classic" SDL2, I get

> Finished with 1223 successful tests and 0 failed tests.

with `SDL_AUDIODRIVER=dummy` in the environment.

Please consider applying the attached patch. With the patch I'm 
proposing, because SDL_AUDIODRIVER isn't modified if already set, you 
could still use a command like one of these:

    SDL_AUDIODRIVER=pulseaudio sadt
    SDL_AUDIODRIVER=pipewire debian/tests/run
    autopkgtest --env SDL_AUDIODRIVER=alsa ...

to test against another audio backend that you happen to know works 
correctly on your specific system.

Thanks,
    smcv
>From ba17bfd19a3f1f4e4e5e89b7dcdbfd8bf996b3f6 Mon Sep 17 00:00:00 2001
From: Simon McVittie <[email protected]>
Date: Sat, 20 Dec 2025 15:28:07 +0000
Subject: [PATCH] d/tests/run: Use SDL's dummy audio driver by default

This driver is the most appropriate for CI environments where real audio
devices are unlikely to be available, but is not available unless
explicitly requested like this.

With "classic" SDL2, CI containers report that no audio devices are
available, and the majority of the faudio test is skipped unless
the dummy driver is explicitly used.

With sdl2-compat replacing "classic" SDL2, the ALSA driver reports that
a default device exists, but actually opening that device does not work.
The faudio test suite is not prepared for this to happen, and crashes.
Preferring the dummy driver avoids this crash.

See also https://github.com/libsdl-org/sdl2-compat/issues/562

Closes: #-1
---
 debian/tests/run | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/debian/tests/run b/debian/tests/run
index 170c6cc..4885d83 100755
--- a/debian/tests/run
+++ b/debian/tests/run
@@ -1,3 +1,17 @@
 #!/bin/sh
+
+set -eu
+
+# Use the dummy driver unless told otherwise: this is the only one that
+# can be expected to work in CI containers, but isn't selected unless
+# explicitly requested.
+#
+# Can be overridden with e.g.
+# SDL_AUDIODRIVER='pulseaudio,pipewire,alsa,dummy'
+# for manual testing.
+if [ -z "${SDL_AUDIODRIVER-}" ]; then
+    export SDL_AUDIODRIVER=dummy
+fi
+
 triplet=$(dpkg-architecture -qDEB_HOST_MULTIARCH 2>/dev/null)
 /usr/lib/$triplet/faudio/faudio_tests
-- 
2.51.0


--- End Message ---
--- Begin Message ---
Source: faudio
Source-Version: 25.12+dfsg-2
Done: Stephen Kitt <[email protected]>

We believe that the bug you reported is fixed in the latest version of
faudio, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Stephen Kitt <[email protected]> (supplier of updated faudio package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 20 Dec 2025 18:06:16 +0100
Source: faudio
Architecture: source
Version: 25.12+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Wine Team <[email protected]>
Changed-By: Stephen Kitt <[email protected]>
Closes: 1123730
Changes:
 faudio (25.12+dfsg-2) unstable; urgency=medium
 .
   * Use the dummy audio driver by default in autopkgtests; thanks to Simon
     McVittie for the patch! Closes: #1123730.
Checksums-Sha1:
 8890030f3a14ac3d806cbda011dcfc78462f0f67 2061 faudio_25.12+dfsg-2.dsc
 c85d2888c8876b4be0257be4e65f966be32c8ec0 8672 faudio_25.12+dfsg-2.debian.tar.xz
 733b2ddc1b091830bd16a04a318411b79cbff1f5 12473 
faudio_25.12+dfsg-2_source.buildinfo
Checksums-Sha256:
 5c94e920aed02af18c1279ceb0ef21061a153f6a17d07662a9410b9f21cf8947 2061 
faudio_25.12+dfsg-2.dsc
 728dfb852a65ff317938bca88ca71c7b856f6febe46213ac2c5ee5345824deb2 8672 
faudio_25.12+dfsg-2.debian.tar.xz
 4fa02b93c3f07268bf3029245cde03626f7180750143622303bd074dc86e74e7 12473 
faudio_25.12+dfsg-2_source.buildinfo
Files:
 464334367710427f1b6b15f50c57346f 2061 libs optional faudio_25.12+dfsg-2.dsc
 32babd735945f70be5913a3f5f4d8b49 8672 libs optional 
faudio_25.12+dfsg-2.debian.tar.xz
 52d7b8cca54884e3a5a5225b237c29fc 12473 libs optional 
faudio_25.12+dfsg-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmlG158ACgkQgNMC9Yht
g5xQvw/9GebMVQUS4DAbkoh1VU+BA2QVbrZhI6SR9AKyYKWilzRTBKaGqIyyeFHl
Hr8GiiBeOV4IyYl9tpB1MLZZhe0QI6ik6BaxK0uEE63z5H7eqRLy4LJtWNHfyRVU
oNQvT/XNUnOgVkEPY0ovMp7ERtEPdtTet/9NPebtB3NCH5dvwFRE213GirmQ+JUn
EgNteZlMiIAMii+ZO2kd2+biFgDFnV7ZKGIqnnt6e9itdc8rwT9TxyEMD+GVElJw
MPOAh+wERWr/Tp6Uf9ZvFxyxMg+hblAQ8k6B2SZaOgANzLPsuz4H4svvpt9QuYSh
TsaZgRiy19Kowf2lOZDsC83t8uwW1WkYv4G4OlaHDRH756Oz/J/MM2+KE1VaoovW
GkvHsgUi14xG0QMoAUQXb83HpIlI8jS6herooxVKQcVgOEAAvW1RIZ4rBflGhFOz
BarntAefHgtQNEAPyXKhpG4/XWoNH3xqYXNd+U6Dd42XdVvO0ESi924FdAY1v1Op
zFYWr3lWVQ/y2Me5DStrIUMvJDNS1c4fKY7SmuFk2bOpbcLalpRhN6vKvxLdK6+7
LEX/w/fa2brImDHxmEG1d2Q0utnG6BywgK4QAFrKFROqKtFpD5Xgm4ls3OxtvMHQ
yKGgwRTjWEhNkfcoCyfPdVtEqkHybT4MOkkPtbU4Wm5ETHU1Zmk=
=xAO0
-----END PGP SIGNATURE-----

Attachment: pgp1hYd7A8riW.pgp
Description: PGP signature


--- End Message ---

Reply via email to