On 03.09.2014 14:05, PICCA Frederic-Emmanuel wrote:
* finalized
ok, do not hesitate to use cme to fix your control file.
The Vcs-Browser wasn't up-to-date. Fixed this.
* running testsuite
nice to have a test suite. You can look at the debci and autopkgtest
infrastructure to implement also the integration continuous integration for
scoop.
All right. This is coming up.
why did you removed the virtual package ssh-client ?
I've tried it and it points to openssh-client, but o.k. that could be
different on other systems ... Restored.
* added no-adsense.patch
could you discuss with the upstream to remove these privacy breach things.
If they really want them, it should be nice to have a setup.py flag which
allow to get rid of these google analytic links, instead of carrying a
dedicated patch all the time.
Yes, that's pretty ugly. I'm going to mention/forward this to upstream.
You removed the local-options (are you using gbp-buildpackage to build scoop
?)
Yes. What's this for, useful to keep?
So I will consiede the pacakge ready for upload once
Great. Much thanks in advance.
> 1) you regenerate the -doc package (this will simplify thinks when
python3 pacakge will be possible)
> 2) re-add the ssh-client dependency (cheap)
> 3) add the autopkgtest part (will simplify a lot the maintenance of
the package, so important for me)
I've commited the changes right now. I'm going to write again when the
autopkgtest is fixed.
Greetings,
Daniel
--
https://qa.debian.org/developer.php?login=debian%40danielstender.com
PGP key: 2048R/E41BD2D0
C879 5E41 1ED7 EE80 0F2E 7D0C DBDD 4D96 E41B D2D0
--
To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/540713a8.4060...@danielstender.com
