Hi, Uploaded. And now you should be able to write in the git repo: https://salsa.debian.org/nvidia-team/nvtop
As for packaging repository, I'd personally recommend you the git-buildpackage workflow, which is also a recommended practice for Debian Science team: https://science-team.pages.debian.net/policy/#idm297 If you found something else to make you more comfortable, just go ahead. On Fri, Jan 11, 2019 at 04:42:44PM +0100, Maxime Schmitt wrote: > Yes sorry, I did not test in a clean chroot. libncurses-dev should be enough > as it pulls libncursesw as a dependency (needed for the drawing plot > characters and degree sign). > > Vcs-* : Ok, it also seemed weird because there was already the Homepage > field. I've created an account as @mschmitt-guest > I will look at other repositories in salsa and docs to see what to put in > this repository. > > On 11/01/2019 16:11, M. Zhou wrote: > > Hi Maxime, > > > > Thanks! I reviewed the code and performed some sanity tests, and > > found a new problem (in a clean chroot): > > > > | CMake Error at > > /usr/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:137 > > (message): > > | Could NOT find Curses (missing: CURSES_LIBRARY CURSES_INCLUDE_PATH) > > | Call Stack (most recent call first): > > | /usr/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:378 > > (_FPHSA_FAILURE_MESSAGE) > > | cmake/modules/FindCurses.cmake:245 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) > > | CMakeLists.txt:46 (find_package) > > > > the curses dev package is not present in Build-Depends field. > > I've added libncurses-dev to depends and started a new build test here: > > http://debomatic-amd64.debian.net/distribution#unstable/nvtop/1.0.0-1/buildlog > > > > Or it's recommended to use ncursesw instead of ncurses? No need to > > upload to mentors again if adding libncurses-dev looks good to you. > > > > > > And I overlooked something when recommending you to add the Vcs-* fields > > to the control file. They are supposed to point at the packaging > > repository (which holds the debian directory and tracks changes within > > it) instead of the upstream source code repo. > > > > For example, https://salsa.debian.org/nvidia-team/nvtop could be a good > > place for holding the packaging repo, which could be filled in to the > > Vcs-* fields. Anyone could register an account on Debian's Salsa > > service. If you are interested in this, please create an account there > > and I'll grant you necessary write permissions. If you don't want to > > do it now, or think it's not necessary, please feel free to ignore > > the Vcs-* stuff. > > > > > > On Fri, Jan 11, 2019 at 03:46:57PM +0100, Maxime Schmitt wrote: > > > I've pushed the last version, with the two fixes, on > > > https://mentors.debian.net/package/nvtop > > > Thank you for your sponsorship. > > > > > > Best regards, > > > Maxime > > > > > > On 11/01/2019 14:49, M. Zhou wrote: > > > > Hi, > > > > > > > > I've installed this utility on my workstation and I'm glad to sponsor > > > > it. > > > > Your packaging looks good except for the section field in d/control: > > > > > > > > -Section: utils > > > > +Section: contrib/utils > > > > > > > > ^ This is due to copyright issue of Nvidia drier or the CUDA toolkit. > > > > Any software that depends on non-free package, even if itself is > > > > licensed under some kind of free software license, have to enter the > > > > contrib section[1]. > > > > > > > > And please add the Vcs-Browser and Vcs-Git fields to d/control. > > > > Look up [2] for example. > > > > > > > > I'll sponsor this package when the two mentioned problem get fixed. > > > > > > > > Thank you for your contribution to Debian! > > > > > > > > [1] > > > > https://www.debian.org/doc/debian-policy/ch-archive.html#the-contrib-archive-area > > > > [2] https://codesearch.debian.net/search?q=Vcs-Browser > > > > > > > > > > > > On Fri, Jan 11, 2019 at 02:28:12PM +0100, Maxime Schmitt wrote: > > > > > Hi, > > > > > > > > > > Thanks, are you willing to sponsor this package? > > > > > Otherwise, should I open a new bug against the sponsorship-request > > > > > package > > > > > (as explained at https://mentors.debian.net/sponsors/rfs-howto) or > > > > > send a > > > > > mail to the mentor mailing list? > > > > > > > > > > I've published the source at https://mentors.debian.net/package/nvtop > > > > > > > > > > On 09/01/2019 06:08, M. Zhou wrote: > > > > > > Hi Maxime, > > > > > > > > > > > > This utility looks cool! > > > > > > > > > > > > If you intend to catch up with Buster freeze and get it into Buster > > > > > > in time, please check the release schedule here: > > > > > > > > > > > > https://release.debian.org/ > > > > > > > > > > > > Don't hesitate to ask me or the debian-mentors list if you > > > > > > encountered > > > > > > any problem. > > > > > > > > > > > > > * Package name : nvtop > > > > > > > Version : 0.3.0 > > > > > > > Upstream Author : Maxime Schmitt <maxime.schmit...@gmail.com> > > > > > > > * URL : https://github.com/Syllo/nvtop > > > > > > > * License : GPL, MIT > > > > > > > Programming Lang: C > > > > > > > Description : Interactive NVIDIA GPU process monitor > > > > > > > > > > > > > > Nvtop is a ncurses-based GPU monitoring interface which provides > > > > > > > information on the GPU states (GPU and memory utilization, > > > > > > > temperature, > > > > > > > etc) and well as information about the processes executing on the > > > > > > > GPUs. > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > This package provides a terminal-based monitoring tool for the > > > > > > > GPUs when > > > > > > > the NVIDIA proprietary drivers are installed. It provides a > > > > > > > convenient > > > > > > > interactive alternative to nvidia-smi. > > > > > > > > > > > > > > I have personally no Debian packaging experience. I am willing to > > > > > > > create > > > > > > > the package and maintain it with some help to kick-start if > > > > > > > possible.
