Bug#941016: ITP: gnome-firmware-updater -- GTK tool to upgrade, downgrade, and reinstall firmware on devices supported by fwupd

[Mike Gabriel]

Hi Jesper,
(Cc:ing Martin Wimpress from Ubuntu MATE)

I'm ok with that. Thank you for taking your time, I will do my best to
help. I've applied some upstream patches that fix
the manpage issue and i've also taken care of the lintian issues.
looking forward to hearing your review comments soon!

Here comes the review:

1.


2.
bin:pkg name: same as with src:pkg name

3.
debian/control:

  - SYNOPSIS: gtk front end for fwupd -> GTK
  - LONG_DESCRIPTION: indent the itemizations by two characters
  - LONG_DESCRIPTION: why don't you use the wording from
    upstream's README.md file? Please do.

src:pkg name: upstream names it gnome-firmware-updater, so why do you name it gnome-firmware https://gitlab.gnome.org/hughsie/gnome-firmware-updater/blob/master/README.md - Build-Depends: please add a comma after the last pkg name, it makes diffs look nicer

    one the line below Build-Depends gets changed (e.g. with another pkg name)

  - Depends: field, I recommend having one package per row.
  - Please use appropriate upper case and lower case letters

debian/copyright:


    wave it through, so...

    here as URL or even better, the GitLab repo.


  use all licenses appearing in the upstream code for debian/.


debian/changelog:

  - my spelling: "Initial release to Debian. (Closes: #941016)."
    -> thus, using full-stops

4.


There are three options now:

  (a) you work on those bits and pieces and I take a second look
  (b) you are ok with me adding some commits
  (c) a mixture of (a) and (b)







Thanks for your work!
Mike

--

DAS-NETZWERKTEAM
c\o Technik- und Ökologiezentrum Eckernförde
Mike Gabriel, Marienthaler str. 17, 24340 Eckernförde
mobile: +49 (1520) 1976 148
landline: +49 (4351) 850 8940

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de

- Vcs-*: fields are missing, we should put the pkg on salsa under the debian/ folder - personally, I don't like the "Files: *" debian/copyright style, but ftpmaster - Source: field: no URL with a release number here, I'd put the releases/ folder A general thing: you did good, but for other packages you might maintain... I normally The pristine-tar branch is not on salsa, I cannot build without that branch using gbp-buildpackage. We should created an empty Git repo (gnome-firmware-updater) under salsa.debian.org/debian (I can do that, if you agree) and push a clone of your Git repo there. Please let me know if you are ok with continueing using that repository as the official packaging VCS location. Another option would be placing the packaging Git repo onto the Debian GNOME team's namespace on GitLab, but gnome-firmware-updater has "gnome" in its name, but as I learned from upstream, it is a suitable add-on tool for all GTK-based desktop environments, so a "neutral" spot like the /debian team folder salsa is probably the better way to go. Also, Martin Wimpress from Ubuntu MATE and I would like to add ourselves as uploaders. Furthermore, I recommend adding the Debian GNOME team and the Debian+Ubuntu MATE team as uploaders, too. In old times, most Debian packages had been 1-person-maintained, which turned out to be a bad concept in case devs went missing in action (MIA). Allowing team uploads to packages makes Debian a much more flexible place to be at. Please let me know, if you are ok with this, too.

pgpqVubKY9I7G.pgp
Description: Digitale PGP-Signatur