Hello,

This message serves as a summary of an off-list interaction between Gioele Barabucci and myself regarding the packaging status of python-rembg. To ensure proper documentation I am posting the key findings here.

----- BEGIN FINDINGS -----

1. Package status

Current status of the package:

* rembg passes the entire salsa-ci pipeline [1]
* I identified pymatting as missing dependency,
  causing a ModuleNotFoundError, which I will package separately.
* The included pytest was deactivated, as it requires external models to
  run. [2]

2. Investigation on model downloads

We investigated the automatic model download to ensure DFSG compliance.

* A review confirmed that nothing triggers an automatic download during
  the build phase
* While the source code (specifically in rembg/sessions) contains
  download_models methods that use pooch.retrieve , these paths are not
  executed during the build. An example of said download method can be
  found here. [3]


----- END FINDINGS -----

Taking all findings in account we must conclude that rembg is eligible for the main repos, as no model is downloaded during build time.

Furthermore patching the download_models methods is no longer needed [4]

This bug has been blocked by the pymatting ITP to document dependencies.


References:

[1] https://salsa.debian.org/Arian-Ott/python-rembg/-/pipelines/1009987
[2] https://github.com/danielgatis/rembg/blob/4ef22cea5a32279680720d758a0755f65ecc7fb4/tests/
test_remove.py#L22-L38
[3] https://github.com/danielgatis/rembg/blob/4ef22cea5a32279680720d758a0755f65ecc7fb4/rembg/sessions/u2net.py#L62-L72 [4] For context see: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1125925#20

Best,

---
Arian Ott
[email protected]

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to