I made a tweak to d/watch and was ready to upload this to NEW when I
noticed that cols.go is generated by scripts/regenerate.go which
downloads https://jonasjacek.github.io/colors/data.json.

I think that is somewhat problematic -- please consider 1) vendor that
data.json file and run scripts/regenerate.go during build, or 2)
find/create a Debian package with that data.json file (which appears to
be DFSG-compatibly licensed) and Build-Depends on it and make
scripts/regenerate.go use it.  You probably have to patch regenerate.go
to not download things but use a local file, maybe a upstream report
about could help (or at least a bug report to make them aware of this).

If you find that too difficult, maybe try to reproduce the cols.go
output manually and document your experience in debian/README.source in
a way that convince me and the DFSG Team that this is not a problem.

/Simon

Azeez Syed <[email protected]> writes:

> Hi Simon,
>
> thanks, yes I would appreciate a sponsor.
>
> I have applied all the suggested changes on debian/sid :
>
>   - dropped debian/.gitignore
>   - migrated debian/watch to format 5
>   - bumped Standards-Version to 4.7.4
>   - dropped Priority and Rules-Requires-Root from debian/control
>   - dropped the redundant Section field from the binary stanza
>   - ran wrap-and-sort -sabtk
>   - added sign-tags = True and upstream-vcs-tag = v%(version)s to gbp.conf
>
> Pushed to
> https://salsa.debian.org/azeezalishah/golang-github-leaanthony-go-ansi-parser
>
> Validated in a sid sbuild chroot: uscan v5 finds all upstream tags and
> generates the correct tarball URL; lintian is clean apart from one
> pedantic-only message (debian-watch-does-not-check-openpgp-signature
> — upstream doesn't sign releases).
>
> I've also sent a control message to set you as Owner of #1136962.
>
> /Azeez
>
> On Mon, May 18, 2026 at 1:11 PM Simon Josefsson <[email protected]> wrote:
>>
>> Azeez Syed <[email protected]> writes:
>>
>> > Hi,
>> >
>> > I've packaged golang-github-leaanthony-go-ansi-parser (ITP: #1136962),
>> > a Go library that parses ANSI escape codes in strings, supporting ANSI
>> > 16/256/TrueColor, all common text styles, and grapheme-aware truncation.
>> >
>> > It is needed as a dependency for updating golang-github-cli-go-gh-v2
>> > to v2.12.0, which is in turn needed for updating gh (GitHub CLI) to
>> > v2.73.0 (Bug: #1119130).
>> >
>> > Packaging is at:
>> > https://salsa.debian.org/azeezalishah/golang-github-leaanthony-go-ansi-parser
>> >
>> > The package builds cleanly with lintian reporting no warnings.
>> > Would appreciate a review and adoption under the go-team namespace.
>>
>> Add 'jas' as Owner and I'll move it to the go-team package namespace if
>> you aren't able to do that.  Do you need a sponsor to upload?  I'm ready
>> to upload this if you consider this feedback:
>>
>> - Drop debian/.gitignore for tag2upload compatibility.
>>
>> - Use watch v5
>>
>> - Upgrade to Standards-Version 4.7.4, dropping Prioryt and
>>   Rules-Requires-Root
>>
>> - Consider 'wrap-and-sort -sabtk'
>>
>> - Consider gbp.conf sign-tags and upstream-vcs-tag
>>
>> /Simon
>

Attachment: signature.asc
Description: PGP signature

Reply via email to