* Martin Steigerwald <[email protected]> [20090812 21:13]: > Am Mittwoch 12 August 2009 schrieb Michael Prokop: > > * Martin Steigerwald <[email protected]> [20090812 17:18]: > > > Hi Michael! > [...] > > > Michael, please review. I am at the office again beginning next week, > > > so I subscribed to this bug report via my private address.
> > Initial reviewing done. Find fixes against git tree attached as git
> > patches. (Tip: use lintian from unstable to verify your package.)
> > Please review on your own and apply what you acknowledge, ping me if
> > you think the package is ready for upload to Debian then.
> All applied. Added a changelog entry for each one. Pushed my changes.
Thx.
> Please pull and review.
Just one minor problem: the copyright sign in your git commit isn't
UTF-8, which should be used nowadays in debian maintainer scripts.
Fix it via running:
iconv -f ISO-8859-1 -t UTF-8 debian/copyright > debian/copyright.new
mv debian/copyright.new debian/copyright
I've attached a patch (which also changes another '(C)' to '©') that
addresses the issue so you can verify the result. Then the package
should be lintian clean.
> > @Jens: the first patch
> > (0001-fio.1-fix-hyphen-used-as-minus-sign.patch) addresses a minor
> > issue in the manpage. Please feel free to apply it in your upstream
> > source.
> Since it is only one patch for upstream - except a minor patch for the
> Makefile to build in /usr - and Jens already applied it anyway I decided
> not to use quilt this time.
ACK
> You replaced dh_clean by dh_prep in
> 0003-debian-rules-drop-unnecessary-configure-target-repla.patch
> What is the reason? Is dh_clean deprecated?
You are using 'debhelper (>= 7)' in Build-Depends.
debhelper 7 deprecated dh_clean -k in favour of dh_prep.
> I forgot to add a ~/.gitconfig with my name and mail address at work. Is
> there any way to rewrite the mail address in the initial git log entries?
> If not, well its just an email address in there that won't work from
> outside of our intranet.
Demonstrating switch from grml.org to debian.org:
% git filter-branch --commit-filter '
if [ "$GIT_AUTHOR_EMAIL" = "[email protected]" ];
then
export GIT_AUTHOR_EMAIL="[email protected]";
git commit-tree "$@";
else
git commit-tree "$@";
fi' HEAD
Depending on what you'd like to set also check out
$GIT_COMMITTER_EMAIL & CO. HTH
regards,
-mika-
From 8571251a4850e86027e6ba9a73d458e9030b39fc Mon Sep 17 00:00:00 2001 From: Michael Prokop <[email protected]> Date: Wed, 12 Aug 2009 22:33:40 +0200 Subject: [PATCH] =?utf-8?q?Fix=20copyright=20unicode=20char=20and=20move=20another=20(C)=20to=20=C2=A9?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Signed-off-by: Michael Prokop <[email protected]> --- debian/copyright | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/copyright b/debian/copyright index 79ab588..1beb522 100644 --- a/debian/copyright +++ b/debian/copyright @@ -8,7 +8,7 @@ Upstream Author: Jens Axboe <[email protected]> -Copyright: © 2005-2006 by Jens Axboe +Copyright: © 2005-2006 by Jens Axboe License: @@ -75,5 +75,5 @@ Copyrights notes: Copyright (C) Andrew McDonald <[email protected]> Copyright (C) 2003 Kyle McMartin <[email protected]> -The Debian packaging is (C) 2009, Martin Steigerwald <[email protected]> and +The Debian packaging is © 2009, Martin Steigerwald <[email protected]> and is licensed under the GPL, see `/usr/share/common-licenses/GPL-2'. -- 1.6.3.3
signature.asc
Description: Digital signature
