> On Tue, Oct 21, 2003 at 05:55:11PM -0500, X Strike Force SVN Repository Admin wrote: > > * Fix build error when NOT_BUILDING_X_SERVER=yes. The "pI830" variable > > introduced in patch 056 is used unconditionaly, but only declared when > > XF86DRI macro is defined. [Robert Millan] > > - debian/patches/056_i810_make_i830_usable.diff: only access pI830 when > > XF86DRI is defined. > > Say what? > > Why is the source file > xc/programs/Xserver/hw/xfree86/drivers/i810/i830_driver.c being dealt > with at all when NOT_BUILDING_X_SERVER is defined?
I don't know, what I remember is that the error happened only when building xserver-xfree86-dbg, not the standard xc dir. > (Oh, I get it. You're using NOT_BUILDING_X_SERVER prescriptively, by > defining it when you run debian/rules or something similar, not > descriptively. I'm not sure that's a good idea. If I'd meant > NOT_BUILDING_X_SERVER to be used prescriptively, I'd have called it > DO_NOT_BUILD_X_SERVER.) I exported it as an environmental variable, before running dpkg-buildpackage. I wasn't aware there was other method, though. What is it? > Can you please post the build failure to the list? Just tried again (with -0pre1v3) on GNU/Linux (when it failed for me it was on GNU/Hurd) and the failure wasn't reproductible. It's likely that some miss-configuration in gnu.cf respect to linux.cf activates build of Xserver even when that shouldn't be built. The bug in i830_driver.c is clear though, if you look at the patched file with context: #ifdef XF86DRI I830Ptr pI830 = I830PTR(pScrn); #endif [...] /* NeedToSync is set TRUE in RefreshRing called from ResetState() */ pI830->AccelInfoRec->NeedToSync = FALSE; This code will break if ever compiled without the XF86DRI macro. > Either way, we need to come up with a better commit log and changelog > entry. Your description of the error is not meaningful in the context > of the XFree86 build itself. Ok. What else should the description say? -- Robert Millan "[..] but the delight and pride of Aule is in the deed of making, and in the thing made, and neither in possession nor in his own mastery; wherefore he gives and hoards not, and is free from care, passing ever on to some new work." -- J.R.R.T, Ainulindale (Silmarillion) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
