I have committed this without the changes that Sven pointed out were unnecessary.
Thanks Fabio for the patch. Emilio On 20/02/14 23:01, Emilio Pozuelo Monfort wrote: > On 20/02/14 19:47, Sven Joachim wrote: >> Hi, >> >> I'm not sure we want to introduce versioned (build-)dependencies when >> the required version is already in stable or there has never been an >> older version than the required one in Debian. Detailed comments on >> that below. Otherwise your patch looks good to me. > > They are not strictly necessary but they don't hurt either. If configure.ac > requires those versions, I don't see why we can't have the same in > debian/control just for clarity. I personally don't really mind one way or the > other. > > Emilio > >> >> On 2014-02-18 17:58 +0100, Fabio Pedretti wrote: >> >>> - libdrm-dev (>= 2.4.48) [!hurd-any], >>> + libdrm-dev (>= 2.4.52) [!hurd-any], >> >> Okay. >> >>> - x11proto-dri3-dev, >>> - x11proto-present-dev, >>> + x11proto-dri3-dev (>= 1.0), >>> + x11proto-present-dev (>= 1.0), >> >> There have never been pre-1.0 versions in Debian, so that part seems >> unnecessary. >> >>> linux-libc-dev (>= 2.6.31) [linux-any], >> >> This could actually be removed, even oldstable has a newer version. >> >>> + libxcb-dri2-0-dev (>= 1.8), >>> + libxcb-glx0-dev (>= 1.8.1), >> >> Already in stable. >> >>> - libxshmfence-dev, >>> + libxshmfence-dev (>= 1.1), >> >> Only 1.1 has ever been in Debian. >> >>> - libudev-dev [linux-any], >>> + libudev-dev (>= 151) [linux-any], >> >> Even oldstable has a newer version. >> >>> - llvm-3.4-dev (>= 1:3.3-4) [amd64 i386 kfreebsd-amd64 kfreebsd-i386 armhf], >>> + llvm-3.4-dev [amd64 i386 kfreebsd-amd64 kfreebsd-i386 armhf], >> >> Okay. >> >>> - libwayland-dev (>= 1.0.2) [linux-any], >>> + libwayland-dev (>= 1.2.0) [linux-any], >> >> Okay. >> >>> - libudev-dev, >>> + libudev-dev (>= 151), >> >> Already in oldstable, see above. >> >>> - libdrm-dev (>= 2.4.45) [!hurd-any], >>> - x11proto-dri2-dev (>= 2.1), >>> - x11proto-gl-dev (>= 1.4.11), >>> + libdrm-dev (>= 2.4.52) [!hurd-any], >>> + x11proto-dri2-dev (>= 2.6), >>> + x11proto-gl-dev (>= 1.4.14), >> >> Okay. >> >>> + libxcb-glx0-dev (>= 1.8.1), >>> + libxcb-dri2-0-dev (>= 1.8), >> >> Already in stable, see above. >> >>> - libwayland-dev, >>> + libwayland-dev (>= 1.2.0), >> >> Okay. >> >>> - libdrm-dev (>= 2.4.45) [!hurd-any], >>> + libdrm-dev (>= 2.4.52) [!hurd-any], >> >> Okay. >> >>> - libxcb-dri2-0-dev, >>> - libxcb-glx0-dev, >>> + libxcb-dri2-0-dev (>= 1.8), >>> + libxcb-glx0-dev (>= 1.8.1), >> >> Already in stable, see above. >> >>> - libdrm-dev (>= 2.4.45) [!hurd-any], >>> + libdrm-dev (>= 2.4.52) [!hurd-any], >> >> Okay. >> >> Cheers, >> Sven >> >> > -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
