Timo Aaltonen pushed to branch debian-unstable at X Strike Force / lib / libinput
Commits: 1e547e2b by Peter Hutterer at 2020-10-29T12:32:04+10:00 evdev: reduce the "your system is slow" warning to 5 per hour Two cases where this can happen: system is currently slow and delaying events, n which case we'll get a burst and it'll show up in the log files anyway. Or the system is generally slow and we get these warnings all the time. In the latter case, let's not spam the log. Fixes #533 Signed-off-by: Peter Hutterer <[email protected]> (cherry picked from commit 5faa3b7ae92abb7860b05e85dcdd402e2050ed72) - - - - - e84dfbb7 by Peter Hutterer at 2020-10-29T12:32:05+10:00 doc/user: update the timer offset warning for the new "too slow" message Related #533 Signed-off-by: Peter Hutterer <[email protected]> (cherry picked from commit 11d517f9694efbc625d2ea078d4b9df3e2fa8d43) - - - - - 66b2d85a by Peter Hutterer at 2020-11-03T14:14:40+10:00 libinput 1.16.3 Signed-off-by: Peter Hutterer <[email protected]> - - - - - f883ee8d by Timo Aaltonen at 2020-11-12T13:51:03+02:00 Merge branch 'upstream-unstable' into debian-unstable - - - - - 79959fa2 by Timo Aaltonen at 2020-11-12T13:51:20+02:00 bump the version - - - - - 9d6600ab by Timo Aaltonen at 2020-11-12T13:56:34+02:00 release to sid - - - - - 4 changed files: - debian/changelog - doc/user/faqs.rst - meson.build - src/evdev.c Changes: ===================================== debian/changelog ===================================== @@ -1,3 +1,9 @@ +libinput (1.16.3-1) unstable; urgency=medium + + * New upstream release. + + -- Timo Aaltonen <[email protected]> Thu, 12 Nov 2020 13:56:26 +0200 + libinput (1.16.2-1) unstable; urgency=medium * New upstream release. ===================================== doc/user/faqs.rst ===================================== @@ -287,28 +287,28 @@ details on the hwdb and how to modify it locally. .. _faq_timer_offset: ------------------------------------------------------------------------------ -What causes the "timer offset negative" warning? +What causes the "your system is too slow" warning? ------------------------------------------------------------------------------ libinput relies on the caller to call **libinput_dispatch()** whenever data is -available on the epoll-fd. Doing so will process the state of all devices -and can trigger some timers to be set (e.g. palm detection, tap-to-click, -disable-while-typing, etc.). Internally, libinput's time offsets are always -based on the event time of the triggering event. +available. **libinput_dispatch()** will process the state of all devices, +including some time-sensitive features (e.g. palm detection, tap-to-click, +disable-while-typing, etc.). -For example, a touch event with time T may trigger a timer for the time T + -180ms. When setting a timer, libinput checks the wall clock time to ensure -that this time T + offset is still in the future. If not, the warning is -logged. +If the time between the event and the call to **libinput_dispatch()** +is excessive, those features may not work correctly. For example, a delay in +touch event processing may cause wrong or missing tap-to-click events or +a palm may not be detected correctly. When this warning appears, it simply means that too much time has passed -between the event occurring (and the epoll-fd triggering) and the current -time. In almost all cases this is an indication of the caller being -overloaded and not handling events as speedily as required. +between the event occurring and the current time. In almost all cases this +is an indication of the caller being overloaded and not handling events as +speedily as required. The warning has no immediate effect on libinput's behavior but some of the -functionality that relies on the timer may be impeded (e.g. palms are not -detected as they should be). +functionality that relies on the timer may be impeded. This is not a bug in +libinput. libinput does not control how quickly **libinput_dispatch()** is +called. .. _faq_wayland: ===================================== meson.build ===================================== @@ -1,5 +1,5 @@ project('libinput', 'c', - version : '1.16.2', + version : '1.16.3', license : 'MIT/Expat', default_options : [ 'c_std=gnu99', 'warning_level=2' ], meson_version : '>= 0.45.0') ===================================== src/evdev.c ===================================== @@ -2225,8 +2225,8 @@ evdev_device_create(struct libinput_seat *seat, /* at most 5 SYN_DROPPED log-messages per 30s */ ratelimit_init(&device->syn_drop_limit, s2us(30), 5); - /* at most 5 "delayed processing" log messages per minute */ - ratelimit_init(&device->delay_warning_limit, s2us(60), 5); + /* at most 5 "delayed processing" log messages per hour */ + ratelimit_init(&device->delay_warning_limit, s2us(60 * 60), 5); /* at most 5 log-messages per 5s */ ratelimit_init(&device->nonpointer_rel_limit, s2us(5), 5); View it on GitLab: https://salsa.debian.org/xorg-team/lib/libinput/-/compare/f7df98d0fefc9127bfb7b1d83cdc550e18c8d8b3...9d6600abf083628be94a291b47c49681db4442a2 -- View it on GitLab: https://salsa.debian.org/xorg-team/lib/libinput/-/compare/f7df98d0fefc9127bfb7b1d83cdc550e18c8d8b3...9d6600abf083628be94a291b47c49681db4442a2 You're receiving this email because of your account on salsa.debian.org.

