Timo Aaltonen pushed to branch upstream-unstable at X Strike Force / lib / libxres
Commits: a90ff752 by Alan Coopersmith at 2018-11-19T21:27:37-08:00 Update README for gitlab migration Signed-off-by: Alan Coopersmith <[email protected]> - - - - - 97d312e5 by Alan Coopersmith at 2018-12-07T19:49:47-08:00 Update configure.ac bug URL for gitlab migration Signed-off-by: Alan Coopersmith <[email protected]> - - - - - 3e6bdd90 by Ray Strode at 2020-10-21T11:18:49-04:00 XRes: Use _XRead instead of _XRead32 for reading pid _XRead32 requires the output variable to be a long, but `ReadClientValues` feeds it client->value which is a 32-bit allocation. This commit changes the code to use _XRead instead, which properly handles 32-bit output variables. https://gitlab.freedesktop.org/xorg/lib/libxres/-/issues/3 - - - - - 53581bba by Keith Packard at 2021-03-30T21:05:48-07:00 Note ABI of XResQueryClientIds XResQueryClientIds is now documented to return an array of 32-bit values, not an array of longs. The previous implementation allocated space for 32-bit values but read longs into that, overflowing the array. Applications using this were expecting 32-bit values. This "worked" on little endian 64-bit systems because only one value was typically provided and the low 32-bits got stuck in the right place, although the allocation was overrun at the end. That might cause trouble if the allocator is checking carefully. Signed-off-by: Keith Packard <[email protected]> - - - - - c05c6d91 by Keith Packard at 2021-03-30T21:36:16-07:00 libXres 1.2.1 Signed-off-by: Keith Packard <[email protected]> - - - - - 5 changed files: - Makefile.am - README → README.md - configure.ac - include/X11/extensions/XRes.h - src/XRes.c Changes: ===================================== Makefile.am ===================================== @@ -37,3 +37,5 @@ ChangeLog: $(CHANGELOG_CMD) dist-hook: ChangeLog INSTALL + +EXTRA_DIST = README.md ===================================== README → README.md ===================================== @@ -3,23 +3,15 @@ libXRes - X-Resource extension client library All questions regarding this software should be directed at the Xorg mailing list: - http://lists.freedesktop.org/mailman/listinfo/xorg - -Please submit bug reports to the Xorg bugzilla: - - https://bugs.freedesktop.org/enter_bug.cgi?product=xorg + https://lists.x.org/mailman/listinfo/xorg The master development code repository can be found at: - git://anongit.freedesktop.org/git/xorg/lib/libXRes + https://gitlab.freedesktop.org/xorg/lib/libXRes - http://cgit.freedesktop.org/xorg/lib/libXRes +Please submit bug reports and requests to merge patches there. For patch submission instructions, see: - http://www.x.org/wiki/Development/Documentation/SubmittingPatches - -For more information on the git code manager, see: - - http://wiki.x.org/wiki/GitPage + https://www.x.org/wiki/Development/Documentation/SubmittingPatches ===================================== configure.ac ===================================== @@ -29,8 +29,8 @@ AC_PREREQ([2.60]) # digit in the version number to track changes which don't affect the # protocol, so XRes version l.n.m corresponds to protocol version l.n # -AC_INIT([libXres], [1.2.0], - [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg], [libXres]) +AC_INIT([libXres], [1.2.1], + [https://gitlab.freedesktop.org/xorg/lib/libXRes/issues], [libXres]) AC_CONFIG_SRCDIR([Makefile.am]) AC_CONFIG_HEADERS([config.h]) ===================================== include/X11/extensions/XRes.h ===================================== @@ -98,6 +98,7 @@ Status XResQueryClientPixmapBytes ( /* v1.2 */ +/* Returns an array of uint32_t values, not an array of long */ Status XResQueryClientIds ( Display *dpy, long num_specs, ===================================== src/XRes.c ===================================== @@ -256,11 +256,12 @@ static Bool ReadClientValues( _XRead32 (dpy, &value, 4); client->length = value; client->value = malloc(client->length); - _XRead32 (dpy, client->value, client->length); + _XRead (dpy, client->value, client->length); } return True; } +/* Returns an array of uint32_t values, not an array of long */ Status XResQueryClientIds ( Display *dpy, long num_specs, View it on GitLab: https://salsa.debian.org/xorg-team/lib/libxres/-/compare/88bdc8ddda19e4baf03a53ae3219519659a8eead...c05c6d918b0e2011d4bfa370c321482e34630b17 -- View it on GitLab: https://salsa.debian.org/xorg-team/lib/libxres/-/compare/88bdc8ddda19e4baf03a53ae3219519659a8eead...c05c6d918b0e2011d4bfa370c321482e34630b17 You're receiving this email because of your account on salsa.debian.org.
