Timo Aaltonen pushed to branch debian-unstable at X Strike Force / lib / mesa
Commits: df446200 by Timo Aaltonen at 2022-03-02T16:52:12+02:00 rules: Drop kmsro option, which was removed upstream. - - - - - 98876267 by Adam Jackson at 2022-03-06T08:36:14+00:00 meson: Add "amber" option for automatic LTS build configuration Setting amber to true changes these defaults: - glvnd defaults to enabled - the glvnd vendor name is set to "amber" - the gallium and vulkan drivers are disabled - prefer-iris defaults to false - eglQueryString(EGL_VENDOR) returns "Mesa Project (Amber)" The megadriver for the classic driver set will be installed to a file name unique from Mesa main. Beyond that no attempt is made to use filenames different from main - particularly not if glvnd is explicitly disabled - so you would still need to configure your install paths appropriately so things don't collide, if you want them to not collide. But if you have that problem, consider that glvnd already solves it. This has a quiet dependency on glapi and gbm's library API remaining stable. gbm you could fix by linking it statically, glapi is a little harder. I think the right move for glapi is to use glvnd's gldispatch more directly, but that's not public API at the moment. Reviewed-by: Emma Anholt <[email protected]> Reviewed-by: Eric Engestrom <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10557> - - - - - f2928c57 by Eric Engestrom at 2022-03-10T21:39:18+00:00 .pick_status.json: Update to 2106c3bab6bdea736c468fb1866fd0f372cc0baa - - - - - b006a020 by Eric Engestrom at 2022-03-10T21:39:22+00:00 .pick_status.json: Mark 7ec0e2b89351e6e56cb112e00e6c68c6bbc6faea as denominated - - - - - bf5ff75f by Eric Engestrom at 2022-03-10T21:39:22+00:00 .pick_status.json: Mark 0136545d169adb75e4f9f6b4de38eef0817c1241 as denominated - - - - - 46ac9150 by Eric Engestrom at 2022-03-10T21:39:22+00:00 .pick_status.json: Mark 62b8daa889daefb2f191a63f370541bf2b807e88 as denominated - - - - - e4a341cd by Eric Engestrom at 2022-03-10T21:39:22+00:00 .pick_status.json: Mark 698ae34844b7199b8acc3b4d74a9cad3b903bdef as denominated - - - - - 3d05ecc5 by Eric Engestrom at 2022-03-10T21:39:22+00:00 .pick_status.json: Mark 03a80490a47b0b616566c6f56581560694976b1a as denominated - - - - - 9aea0b61 by Eric Engestrom at 2022-03-10T21:39:22+00:00 .pick_status.json: Mark e1964e1dde7bf44ceeaf3fa8b3869e791af4a369 as denominated - - - - - f0e6486d by Eric Engestrom at 2022-03-10T23:23:55+00:00 .pick_status.json: Mark 3ef093f697ad9027ba514c7a4a6a10b7bd95bd47 as denominated - - - - - 204c7913 by Eric Engestrom at 2022-03-10T23:23:55+00:00 .pick_status.json: Mark 2d1b506acfe55165511a2bb83acb013353e531ab as denominated - - - - - 09fc6515 by Eric Engestrom at 2022-03-10T23:23:55+00:00 .pick_status.json: Mark 204ea77b0674fb611155bd3ba2e6169cc8646b3f as denominated - - - - - 9b043263 by Eric Engestrom at 2022-03-10T23:23:55+00:00 .pick_status.json: Mark a5c7d34fdf8403b0115d5eead7ca67027e93efc7 as denominated - - - - - a9e47e3a by Eric Engestrom at 2022-03-10T23:23:56+00:00 .pick_status.json: Mark 432700fc61a33e0c040d47d9b7bd8cfe970d35cc as denominated - - - - - 52a36a45 by Eric Engestrom at 2022-03-10T23:23:56+00:00 .pick_status.json: Mark 4ed7329236a576b6b6f615787bb722b960f32c6b as denominated - - - - - 2d12eb32 by Eric Engestrom at 2022-03-10T23:23:56+00:00 .pick_status.json: Mark 3f7da0c58447979976eb2928625b1f93154f6c57 as denominated - - - - - 23094f01 by Paulo Zanoni at 2022-03-10T23:23:56+00:00 iris: fix register spilling on compute shaders on XeHP XeHP scratch space is handled differently. Commit ae18e1e707c4 implemented support for it, but handled it differently between render and compute shaders: it calculates scratch_addr differently and doesn't pin the buffer on compute. Make it work on compute shaders by calling pin_scratch_space() from iris_compute_walker(), which fixes both the address and the pinning. This commit can be verified by the two-year-old-but-still-unreviewed Piglit MR 234. You can also verify this by running a very simple compute shader with INTEL_DEBUG=spill_fs. References: https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/234 Fixes: ae18e1e707c4 ("iris: Add support for scratch on XeHP") Reviewed-by: Lionel Landwerlin <[email protected]> Signed-off-by: Paulo Zanoni <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15070> (cherry picked from commit d10fd5b7c9a695565c009c446882bed49bc20fdd) - - - - - 38c023e1 by Lionel Landwerlin at 2022-03-10T23:23:56+00:00 anv: fix conditional render for vkCmdDrawIndirectByteCountEXT We just forgot about conditional render for this entry point. Signed-off-by: Lionel Landwerlin <[email protected]> Fixes: 2be89cbd826f9a ("anv: Implement vkCmdDrawIndirectByteCountEXT") Tested-By: Mike Blumenkrantz <[email protected]> Reviewed-by: Tapani Pälli <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14891> (cherry picked from commit 93a90fc85d037e2c6834fb969562391310ae9cd0) - - - - - 8d920d52 by Jason Ekstrand at 2022-03-10T23:23:56+00:00 anv: Don't assume depth/stencil attachments have depth If a secondary command buffer is used and the client provides a framebuffer and that framebuffer has a stencil-only attchment, we would try to get the aux usage for the depth component of that attachment and crash. Check the aspects of the image before looking at aux usage. This fixes at least the following SkQP tests on my Tigerlake: - vk_circular-clips - vk_filterfastbounds - vk_innershapes_bw - vk_lineclosepath - vk_multipicturedraw_rrectclip_simple - vk_pathinvfill - vk_quadclosepath - vk_rrect_clip_bw - vk_windowrectangles Fixes: 0d8b9c529ce3 ("anv: Allow PMA optimization to be enabled in secondary command buffers") Reviewed-by: Lionel Landwerlin <[email protected]> Tested-by: Matt Turner <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15048> (cherry picked from commit df0e2a1565587cec47a8074f0d4a597e21e99783) - - - - - ea8391a8 by Danylo Piliaiev at 2022-03-10T23:23:56+00:00 turnip: Use LATE_Z when there might be depth/stencil feedback loop Otherwise a shader invocation would read the value which should have been set AFTER this shader invocation. Fixes tests: dEQP-VK.rasterization.rasterization_order_attachment_access.depth.samples_1.multi_draw_barriers dEQP-VK.rasterization.rasterization_order_attachment_access.stencil.samples_1.multi_draw_barriers Fixes: 71595a189a0c372efd520ad51866ca57aa83298c ("tu: Fix feedback loops in sysmem mode") Signed-off-by: Danylo Piliaiev <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15106> (cherry picked from commit dab34bd5c80b7daf4c54efd457eafeec5dc2caa7) - - - - - 0e61e327 by Rhys Perry at 2022-03-10T23:23:56+00:00 anv: Enable nir_opt_access This commit will enable pass for searching readonly / writeonly access when it's missing. We don't support shaderStorageImageReadWithoutFormat and the optimization pass causes those shaders to take the write-only path which does support formatless. Following games are affected with positive result: - Wolfenstein: Youngblood - Wolfenstein II: The New Colossus https://gitlab.freedesktop.org/mesa/mesa/-/issues/3138 - Rage 2 https://gitlab.freedesktop.org/mesa/mesa/-/issues/5791 - The Surge 2 https://gitlab.freedesktop.org/mesa/mesa/-/issues/5805 - Metro Exodus https://gitlab.freedesktop.org/mesa/mesa/-/issues/4703 - DOOM Eternal https://gitlab.freedesktop.org/mesa/mesa/-/issues/4273 Cc: mesa-stable Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3138,https://gitlab.freedesktop.org/mesa/mesa/-/issues/5791,https://gitlab.freedesktop.org/mesa/mesa/-/issues/4273 Signed-off-by: Mykhailo Skorokhodov <[email protected]> Reviewed-by: Kenneth Graunke <[email protected]> Reviewed-by: Jason Ekstrand <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15082> (cherry picked from commit ded9cb904f02cfe4206f88f8a41f49258f09f2b0) - - - - - 6ae28c43 by Dave Airlie at 2022-03-10T23:23:56+00:00 draw/so: don't use pre clip pos if we have a tes either. This check for geom shader needed to be expanded for tess support. dEQP-VK.transform_feedback.simple.depth_clip_control_tese with lvp Fixes: dacf8f5f5c82 ("draw: hook up final bits of tessellation") Acked-by: Mike Blumenkrantz <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15128> (cherry picked from commit b77ef4dd60d1d8fad0cb4d50740f1b8afc9e02f9) - - - - - f6a56847 by Erik Faye-Lund at 2022-03-10T23:23:56+00:00 docs: remove incorrect drivers from extension This extension isn't wired up in Gallium, so there's just no way a Gallium driver like Panfrost exposes it. While there were support in i965 for this for the cancelled Broxton GPU, thre's no such support in the Iris driver. And since Broxton has been cancelled, it's unlikely to be wired up any time soon. Fixes: da23a31726f ("docs/features: Update ASTC entries for Panfrost") Acked-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15145> (cherry picked from commit 834db3aa8d0f9c6c7587dff1a632223c38e7602c) - - - - - 237197ee by Jonathan Gray at 2022-03-10T23:23:57+00:00 util: unbreak non-linux mips64 build Put linux specific path inside an ifdef. Unbreaks mips64 build on OpenBSD and likely other systems without Elf64_auxv_t. Fixes: 88b234d7a7c ("gallivm: add basic mips64 support and set mcpu to mips64r5 on ls3a4000") Reviewed-by: Ilia Mirkin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15166> (cherry picked from commit 7d609431d4f69903648f6bbb5b3bfc87b807ab17) - - - - - e1a35767 by Jonathan Gray at 2022-03-10T23:23:57+00:00 util: fix util_cpu_detect_once() build on OpenBSD Correct type for sysctl argument to fix the build. ../src/util/u_cpu_detect.c:631:29: error: incompatible pointer types passing 'int *' to parameter of type 'size_t *' (aka 'unsigned long *') [-Werror,-Wincompatible-pointer-types] sysctl(mib, 2, &ncpu, &len, NULL, 0); ^~~~ Fixes: 5623c75e40b ("util: Fix setting nr_cpus on some BSD variants") Signed-off-by: Jonathan Gray <[email protected]> Reviewed-by: Ilia Mirkin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13448> (cherry picked from commit afece589dc6c5227ac61502f809184090fe83da1) - - - - - 28afbf38 by Jonathan Gray at 2022-03-10T23:23:57+00:00 util/u_atomic: fix build on clang archs without 64-bit atomics Make this build on clang architectures that don't have 64-bit atomic instructions. Clang doesn't allow redeclaration (and therefore redefinition) of the __sync_* builtins. Use #pragma redefine_extname to work around that restriction. Clang also turns __sync_add_and_fetch into __sync_fetch_and_add (and __sync_sub_and_fetch into __sync_fetch_and_sub) in certain cases, so provide these functions as well. Fixes: a6a38a038bd ("util/u_atomic: provide 64bit atomics where they're missing") patch from Mark Kettenis Signed-off-by: Jonathan Gray <[email protected]> Reviewed-by: Ilia Mirkin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6511> (cherry picked from commit f12c107b030b0aacc0c8b11c99fdce13f38bc98f) - - - - - c9afc6a0 by Jonathan Gray at 2022-03-10T23:23:57+00:00 util: fix build with clang 10 on mips64 On mips64, the compiler does not allow use of non-zero argument with __builtin_frame_address(). However, the returned frame address is only used when PIPE_ARCH_X86 is defined. The compile error can be avoided by making #ifdef PIPE_ARCH_X86 cover the getting of frame address too. The argument checking of __builtin_frame_address() has been present as a debug assert in clang 8. In clang 10, there is a proper runtime check for the argument. This is why the build has not failed before. Fixes: dc94a0506f1 ("gallium: Do not add -Wframe-address option for gcc <= 4.4.") from Visa Hankala Signed-off-by: Jonathan Gray <[email protected]> Reviewed-by: Ilia Mirkin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6511> (cherry picked from commit 0536b691338f2759b850f9ec94634033a5d1f9e1) - - - - - 63885e71 by Jonathan Gray at 2022-03-10T23:23:57+00:00 util: use correct type in sysctl argument Fixes build on OpenBSD/macppc powerpc error: incompatible pointer types passing 'int *' to parameter of type 'size_t *' (aka 'unsigned long *') [-Werror,-Wincompatible-pointer-types] Fixes: 01bd21eef8f ("gallium: Import Dennis Smit cpu detection code.") Signed-off-by: Jonathan Gray <[email protected]> Reviewed-by: Ilia Mirkin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6511> (cherry picked from commit 6250a3bc18d06b6f609dc1eff8599432edbfc3c8) - - - - - 3af00d06 by Connor Abbott at 2022-03-10T23:23:57+00:00 ir3: Don't always set bindless_tex with readonly images Fixes: 274f381 ("ir3: Plumb through bindless support") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15114> (cherry picked from commit 21ac044c3e25888eb9f1bc72ed09da825e257ae7) - - - - - 1e233de9 by Connor Abbott at 2022-03-10T23:23:57+00:00 ir3/nir: Fix 1d array readonly images ncoords includes the array index, and the NIR source has the array index as its last component, so we have to insert the extra y coordinate in the middle in this case. Fixes: 0bb0cac ("freedreno/ir3: handle image buffer") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15114> (cherry picked from commit 58d72f45e58969dcd45e953487b1bd2338dbb05a) - - - - - f4213683 by Lionel Landwerlin at 2022-03-10T23:23:57+00:00 anv: fix fast clear type value with external images Disable fast clear if not supported by the external modifier. v2: Set fast_clear value to NONE in case of import/export from/to external v3: Move logic next to existing acquire/release checks (Nanley) Signed-off-by: Lionel Landwerlin <[email protected]> Cc: mesa-stable Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6056 Reviewed-by: Nanley Chery <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15096> (cherry picked from commit 214092da879252c3935eaee47b0b2ac42b682268) - - - - - f2ff1142 by Lionel Landwerlin at 2022-03-10T23:23:57+00:00 intel/fs: fix total_scratch computation We only have a single prog_data::total_scratch for all shader variants (SIMD 8, 16, 32). Therefore we should always max the total_scratch on top of existing variant. We probably haven't run into that issue before because we compile by increasing SIMD size and higher SIMD size is more likely to spill. But for bindless shaders with return shaders, if the last return part doesn't spill, we completely ignore the previous parts' scratch computation. Signed-off-by: Lionel Landwerlin <[email protected]> Cc: mesa-stable Reviewed-by: Tapani Pälli <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15193> (cherry picked from commit 96c8880900e3351dfb88c43b0e3e324539436bc0) - - - - - ddcecb54 by Dave Airlie at 2022-03-10T23:23:57+00:00 crocus: change the line width workaround for gfx4/5 This fixes piglit line-flat-clip-color and the hud fps counter. Fixes: 6b7a68b7c21e ("crocus: add missing line smooth bits.") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15229> (cherry picked from commit a10b5d7086b92a681c657d7ad24d49d30b072a36) - - - - - 293e3692 by Xiaohui Gu at 2022-03-10T23:23:57+00:00 iris: Mark a dirty update when vs_needs_sgvs_element value changed Add vs_needs_sgvs_element value check when updating vertex element dirty state in iris_update_compiled_vs to solve render error of Android game "Genshin Impact". Signed-off-by: Xiaohui Gu <[email protected]> Reviewed-by: Tapani Pälli <[email protected]> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15142> (cherry picked from commit 4d81c60e11e3b73b6e2f52637291858ac08cf982) - - - - - 3e1d5797 by Alyssa Rosenzweig at 2022-03-10T23:23:58+00:00 panfrost: Fix FD resource_get_handle When handle->type is WINSYS_HANDLE_TYPE_FD, the caller wants a file descriptor for the BO backing the resource. We previously had two paths for this: 1. If rsrc->scanout is available, we prime the GEM handle from the KMS device (rsrc->scanout->handle) to a file descriptor via the KMS device. 2. If rsrc->scanout is not available, we prime the GEM handle from the GPU (bo->gem_handle) to a file descriptor via the GPU device. In both cases, the caller passes in a resource (with BO) and expects out a file descriptor. There are no direct GEM handles in the function signature; the caller doesn't care which GEM handle we prime to get the file descriptor. In principle, both paths produce the same file descriptor for the same BO, since both GEM handles represent the same underlying resource (viewed from different devices). On grounds of redundancy alone, it makes sense to remove the rsrc->scanout path. Why have a path that only works sometimes, when we have another path that works always? In fact, the issues with the rsrc->scanout path are deeper. rsrc->scanout is populated by renderonly_create_gpu_import_for_resource, which does the following: 1. Get a file descriptor for the resource by resource_get_handle with WINSYS_HANDLE_TYPE_FD 2. Prime the file descriptor to a GEM handle via the KMS device. Here comes strike number 2: in order to get a file descriptor via the KMS device, we had to /already/ get a file descriptor via the GPU device. If we go down the KMS device path, we effectively round trip: GPU handle -> fd -> KMS handle -> fd There is no good reason to do this; if everything works, the fd is the same in each case. If everything works. If. The lifetimes of the GPU handle and the KMS handle are not necessarily bound. In principle, a resource can be created with scanout (constructing a KMS handle). Then the KMS view can be destroyed (invalidating the GEM handle for the KMS device), even though the underlying resource is still valid. Notice the GPU handle is still valid; its lifetime is tied to the resource itself. Then a caller can ask for the FD for the resource; as the resource is still valid, this is sensible. Under the scanout path, we try to get the FD by priming the GEM handle on the KMS device... but that GEM handle is no longer valid, causing the PRIME ioctl to fail with ENOENT. On the other hand, if we primed the GPU GEM handle, everything works as expected. These edge cases are not theoretical; recent versions of Xwayland trigger this ENOENT, causing issue #5758 on all Panfrost devices. As far as I can tell, no other kmsro driver has this 'special' kmsro path; the only part of resource_get_handle that needs special handling for kmsro is getting a KMS handle. Let's remove the broken, useless path, fix Xwayland, bring us in line with other drivers, and delete some code. Thank you for coming to my ted talk. Closes: #5758 Fixes: 7da251fc721 ("panfrost: Check in sources for command stream") Signed-off-by: Alyssa Rosenzweig <[email protected]> Reported-and-tested-by: Jan Palus <[email protected]> Reviewed-by: Simon Ser <[email protected]> Reviewed-by: James Jones <[email protected]> Acked-by: Daniel Stone <[email protected]> Tested-by: Dan Johansen <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15120> (cherry picked from commit b5734cc1c4666b4f21446649d2aba85c0c19350e) - - - - - 67e2cd9e by Alyssa Rosenzweig at 2022-03-10T23:23:58+00:00 panfrost: Handle NULL sampler views Fixes a NULL dereference in Piglit fp-fragment-position. Signed-off-by: Alyssa Rosenzweig <[email protected]> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13203> (cherry picked from commit 53ef20f08d4340c1bad0b45a2501f4daba7fb479) - - - - - 74ff12b0 by Alyssa Rosenzweig at 2022-03-10T23:23:58+00:00 panfrost: Handle NULL samplers Fixes a NULL dereference in Piglit fp-fragment-position, getting the test to pass. Signed-off-by: Alyssa Rosenzweig <[email protected]> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13203> (cherry picked from commit 5536852d60e59dad52feb63e1e88150ece1fec15) - - - - - 673f8128 by Alyssa Rosenzweig at 2022-03-10T23:23:58+00:00 panfrost: Flush resources when shadowing When we shadow a resource, the backing BO is changed; as such, existing references to the resource become invalid. So batches accessing the resource need to be flushed (or otherwise have their references invalidated). The wrong behaviour change (not flushing) was introduced when we started tracking resources instead of BOs. The issue manifested as a severe performance regression in glmark2's -bbuffer test, particular the subdata subtest. The issue is magnified on slow CPUs; without the fix, the test becomes completely CPU bound Relevant glmark2 -bbuffer test from 43fps to 84fps. Apparently, this causes functional issues too -- this performance-minded change also fixes a few piglits. Fixes: cecb889481d ("panfrost: Do tracking of resources, not BOs") Signed-off-by: Alyssa Rosenzweig <[email protected]> Reported-by: Chris Healy <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13502> (cherry picked from commit 988d5aae74d61d1416b369172ef286b4aac933d0) - - - - - 7e569dd5 by Alyssa Rosenzweig at 2022-03-10T23:23:58+00:00 panfrost: Push twice as many uniforms The limit for Bifrost is twice as high as previously thought -- the limit is 64 *slots* of FAU, not 64 words. Each slot is 2 words. We can push twice as much, saving a considerable number of cycles in some cases. total instructions in shared programs: 2454260 -> 2431502 (-0.93%) instructions in affected programs: 845176 -> 822418 (-2.69%) helped: 3376 HURT: 304 helped stats (abs) min: 1.0 max: 60.0 x̄: 7.92 x̃: 6 helped stats (rel) min: 0.13% max: 45.45% x̄: 4.60% x̃: 4.11% HURT stats (abs) min: 1.0 max: 60.0 x̄: 13.06 x̃: 8 HURT stats (rel) min: 0.16% max: 35.09% x̄: 7.58% x̃: 6.52% 95% mean confidence interval for instructions value: -6.50 -5.87 95% mean confidence interval for instructions %-change: -3.75% -3.43% Instructions are helped. total tuples in shared programs: 1963383 -> 1951560 (-0.60%) tuples in affected programs: 638622 -> 626799 (-1.85%) helped: 2959 HURT: 573 helped stats (abs) min: 1.0 max: 54.0 x̄: 5.61 x̃: 4 helped stats (rel) min: 0.15% max: 28.57% x̄: 3.61% x̃: 3.12% HURT stats (abs) min: 1.0 max: 50.0 x̄: 8.35 x̃: 6 HURT stats (rel) min: 0.25% max: 27.34% x̄: 6.24% x̃: 4.92% 95% mean confidence interval for tuples value: -3.61 -3.08 95% mean confidence interval for tuples %-change: -2.18% -1.85% Tuples are helped. total clauses in shared programs: 387817 -> 365111 (-5.85%) clauses in affected programs: 135527 -> 112821 (-16.75%) helped: 3489 HURT: 25 helped stats (abs) min: 1.0 max: 43.0 x̄: 6.52 x̃: 5 helped stats (rel) min: 0.82% max: 58.33% x̄: 17.48% x̃: 15.87% HURT stats (abs) min: 1.0 max: 3.0 x̄: 1.56 x̃: 1 HURT stats (rel) min: 2.94% max: 11.11% x̄: 6.87% x̃: 6.67% 95% mean confidence interval for clauses value: -6.67 -6.26 95% mean confidence interval for clauses %-change: -17.65% -16.96% Clauses are helped. total cycles in shared programs: 201842.21 -> 168754.04 (-16.39%) cycles in affected programs: 84035.50 -> 50947.33 (-39.37%) helped: 3547 HURT: 136 helped stats (abs) min: 0.041665999999999315 max: 54.0 x̄: 9.33 x̃: 8 helped stats (rel) min: 0.17% max: 80.77% x̄: 36.10% x̃: 36.84% HURT stats (abs) min: 0.041665999999999315 max: 1.0 x̄: 0.12 x̃: 0 HURT stats (rel) min: 0.18% max: 12.24% x̄: 1.18% x̃: 0.61% 95% mean confidence interval for cycles value: -9.26 -8.71 95% mean confidence interval for cycles %-change: -35.34% -34.11% Cycles are helped. total arith in shared programs: 74918.46 -> 75022.62 (0.14%) arith in affected programs: 22471.04 -> 22575.21 (0.46%) helped: 1571 HURT: 1492 helped stats (abs) min: 0.041665999999999315 max: 1.125 x̄: 0.17 x̃: 0 helped stats (rel) min: 0.17% max: 40.00% x̄: 2.50% x̃: 1.96% HURT stats (abs) min: 0.041665999999999315 max: 2.375 x̄: 0.25 x̃: 0 HURT stats (rel) min: 0.16% max: 100.00% x̄: 5.35% x̃: 2.37% 95% mean confidence interval for arith value: 0.02 0.05 95% mean confidence interval for arith %-change: 1.08% 1.56% Arith are HURT. total ldst in shared programs: 174812 -> 137889 (-21.12%) ldst in affected programs: 81319 -> 44396 (-45.41%) helped: 3722 HURT: 0 helped stats (abs) min: 1.0 max: 62.0 x̄: 9.92 x̃: 8 helped stats (rel) min: 1.82% max: 100.00% x̄: 47.18% x̃: 43.75% 95% mean confidence interval for ldst value: -10.20 -9.64 95% mean confidence interval for ldst %-change: -47.97% -46.39% Ldst are helped. total quadwords in shared programs: 1757124 -> 1714130 (-2.45%) quadwords in affected programs: 584065 -> 541071 (-7.36%) helped: 3474 HURT: 173 helped stats (abs) min: 1.0 max: 90.0 x̄: 12.66 x̃: 9 helped stats (rel) min: 0.26% max: 34.18% x̄: 8.78% x̃: 8.33% HURT stats (abs) min: 1.0 max: 26.0 x̄: 5.76 x̃: 4 HURT stats (rel) min: 0.45% max: 20.66% x̄: 4.48% x̃: 2.63% 95% mean confidence interval for quadwords value: -12.21 -11.37 95% mean confidence interval for quadwords %-change: -8.36% -7.95% Quadwords are helped. total threads in shared programs: 52898 -> 53142 (0.46%) threads in affected programs: 262 -> 506 (93.13%) helped: 250 HURT: 6 helped stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1 helped stats (rel) min: 100.00% max: 100.00% x̄: 100.00% x̃: 100.00% HURT stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1 HURT stats (rel) min: 50.00% max: 50.00% x̄: 50.00% x̃: 50.00% 95% mean confidence interval for threads value: 0.92 0.99 95% mean confidence interval for threads %-change: 93.69% 99.28% Threads are helped. total spills in shared programs: 161 -> 107 (-33.54%) spills in affected programs: 54 -> 0 helped: 27 HURT: 0 total fills in shared programs: 1386 -> 796 (-42.57%) fills in affected programs: 590 -> 0 helped: 27 HURT: 0 Fixes: d4dccea0ba3 ("panfrost: Add UBO push data structure") Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15239> (cherry picked from commit 7bda838c56111bde0d27d208a725abf215ed85bb) - - - - - 2872f752 by Marek Olšák at 2022-03-10T23:23:58+00:00 amd: add a workaround for an SQ perf counter bug Cc: [email protected] Acked-by: Pierre-Eric Pelloux-Prayer <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15098> (cherry picked from commit 197467c23847793950c9b6e482a0b7f45478da88) - - - - - 4d16399e by Timur Kristóf at 2022-03-10T23:23:58+00:00 ac/nir/ngg: Fix mixed up primitive ID after culling. When NGG culling is enabled, make sure that the correct primitive ID is exported by each lane. Fixes: e97f0463a8f55d5d407178f74b0cdb916a42aef8 "ac/nir: Implement NGG deferred attribute culling in NIR." Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6050 Signed-off-by: Timur Kristóf <[email protected]> Reviewed-by: Rhys Perry <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15055> (cherry picked from commit 3759a16d8a883355effa435f46867951ce712dbe) - - - - - df8cd7d8 by Jonathan Gray at 2022-03-10T23:23:58+00:00 radv: use MAJOR_IN_SYSMACROS for sysmacros.h include fixes build on OpenBSD ../src/amd/vulkan/radv_device.c:35:10: fatal error: 'sys/sysmacros.h' file not found Fixes: 7aaa54feb53 ("radv: implement VK_EXT_physical_device_drm") Signed-off-by: Jonathan Gray <[email protected]> Reviewed-by: Ilia Mirkin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13448> (cherry picked from commit f0398180a592e12eefc58e9580d7c0d71fbae450) - - - - - 513aac74 by Samuel Pitoiset at 2022-03-10T23:23:58+00:00 radv,drirc: move RADV workarounds to 00-radv-defaults.conf Because we have to maintain two different packages of Mesa, one specific to RADV and another one for RadeonSI and such, it's a bit annoying to have to synchronize the drirc entries. Currently, only our Mesa package installs 00-mesa-defaults.conf which means we have to backport the drirc RADV changes. This splits 00-mesa-defaults.conf in two to move the drirc RADV entries to src/amd/vulkan/00-radv-defaults.conf. Meson will install the file only if RADV is built. There is still a caveat for common drirc workarounds like for WSI but they are rare enough and we could still duplicate them if needed. Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15152> (cherry picked from commit 53ca85ac2a1acf1476c4b494f5fdfa2cc39c644c) - - - - - 7bd9a727 by Samuel Pitoiset at 2022-03-10T23:23:59+00:00 radv: disable DCC for Fable Anniversary, Dragons Dogma, GTA IV and more Also Starcraft 2 and The Force Unleashed II. These games are known to be affected by the feedback loop issue. We will fix this properly soon but as a hotfix disabling DCC should be enough. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4424 Cc: mesa-stable Signed-off-by: Samuel Pitoiset <[email protected]> Reviewed-by: Bas Nieuwenhuizen <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15203> (cherry picked from commit 4380916b761d2ebbe5b1d36b9162810b66a727fc) - - - - - 1fe2b1c7 by Marek Olšák at 2022-03-10T23:23:59+00:00 radeonsi: fix an assertion failure with register shadowing The problem is that dirty_states must be 0 for any state that is NULL in "queued". This code was flagging dirty_states for such states because it was only looking at "emitted". It should have been looking at "queued". Cc: [email protected] Reviewed-by: Pierre-Eric Pelloux-Prayer <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15209> (cherry picked from commit a02dd17cb36efe9bc2ff2d675357988ded914a02) - - - - - 418c6ba1 by Rhys Perry at 2022-03-10T23:23:59+00:00 radv: include adjust_frag_coord_z in key Fixes potential pipeline caching bug. Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Samuel Pitoiset <[email protected]> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15175> (cherry picked from commit feb7e30e2d40e1ab06823120288de131a86f88c5) [Eric: the disable_aniso_single_level part of the original commit was dropped in the backport as it didn't apply] - - - - - d178bc81 by Mike Blumenkrantz at 2022-03-10T23:23:59+00:00 gallivm: avoid division by zero when computing cube face this is illegal and produces NaNs which blow up the sample instr cc: mesa-stable fixes (llvmpipe and zink): KHR-GL45.incomplete_texture_access.sampler dEQP-GLES31.functional.program_uniform.by_pointer.render.array_in_struct.sampler2D_samplerCube_both dEQP-GLES31.functional.program_uniform.by_pointer.render.array_in_struct.sampler2D_samplerCube_fragment dEQP-GLES31.functional.program_uniform.by_pointer.render.array_in_struct.sampler2D_samplerCube_vertex dEQP-GLES31.functional.program_uniform.by_pointer.render.basic.samplerCube_both dEQP-GLES31.functional.program_uniform.by_pointer.render.basic.samplerCube_fragment dEQP-GLES31.functional.program_uniform.by_pointer.render.basic.samplerCube_vertex dEQP-GLES31.functional.program_uniform.by_pointer.render.basic_struct.sampler2D_samplerCube_both dEQP-GLES31.functional.program_uniform.by_pointer.render.basic_struct.sampler2D_samplerCube_fragment dEQP-GLES31.functional.program_uniform.by_pointer.render.nested_structs_arrays.sampler2D_samplerCube_both dEQP-GLES31.functional.program_uniform.by_pointer.render.nested_structs_arrays.sampler2D_samplerCube_fragment dEQP-GLES31.functional.program_uniform.by_pointer.render.nested_structs_arrays.sampler2D_samplerCube_vertex dEQP-GLES31.functional.program_uniform.by_pointer.render.struct_in_array.sampler2D_samplerCube_both dEQP-GLES31.functional.program_uniform.by_pointer.render.struct_in_array.sampler2D_samplerCube_fragment dEQP-GLES31.functional.program_uniform.by_pointer.render.struct_in_array.sampler2D_samplerCube_vertex dEQP-GLES31.functional.program_uniform.by_value.render.array_in_struct.sampler2D_samplerCube_both dEQP-GLES31.functional.program_uniform.by_value.render.array_in_struct.sampler2D_samplerCube_fragment dEQP-GLES31.functional.program_uniform.by_value.render.array_in_struct.sampler2D_samplerCube_vertex dEQP-GLES31.functional.program_uniform.by_value.render.basic.samplerCube_both dEQP-GLES31.functional.program_uniform.by_value.render.basic.samplerCube_fragment dEQP-GLES31.functional.program_uniform.by_value.render.basic.samplerCube_vertex dEQP-GLES31.functional.program_uniform.by_value.render.basic_struct.sampler2D_samplerCube_both dEQP-GLES31.functional.program_uniform.by_value.render.basic_struct.sampler2D_samplerCube_fragment dEQP-GLES31.functional.program_uniform.by_value.render.nested_structs_arrays.sampler2D_samplerCube_both dEQP-GLES31.functional.program_uniform.by_value.render.nested_structs_arrays.sampler2D_samplerCube_fragment dEQP-GLES31.functional.program_uniform.by_value.render.nested_structs_arrays.sampler2D_samplerCube_vertex dEQP-GLES31.functional.program_uniform.by_value.render.struct_in_array.sampler2D_samplerCube_both dEQP-GLES31.functional.program_uniform.by_value.render.struct_in_array.sampler2D_samplerCube_fragment dEQP-GLES31.functional.program_uniform.by_value.render.struct_in_array.sampler2D_samplerCube_vertex Reviewed-by: Roland Scheidegger <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15246> (cherry picked from commit c82dcdf598f7b78c4a0106a71e008b482cf8f70b) - - - - - c627a2d2 by Icecream95 at 2022-03-10T23:23:59+00:00 panfrost: Set PIPE_CAP_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION Fixes arb-provoking-vertex-render Piglit test. Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15250> (cherry picked from commit d54efebf04313d7fb6e5971aa89f10442a2bc0a7) - - - - - 65021851 by Icecream95 at 2022-03-10T23:23:59+00:00 pan/bi: Check dependencies of both destinations of instructions TEXC can have two destinations; the value for neither of them can be used in the same bundle, so extend the code to check for this to iterate over both destinations. Fixes artefacts in the game "LIMBO". Fixes: a303076c1ab ("pan/bi: Add bi_instr_schedulable predicate") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15250> (cherry picked from commit cb8c47b15e4acecd0cacda8a3d9d20b578f1b4f2) - - - - - 8770ff56 by Icecream95 at 2022-03-10T23:23:59+00:00 panfrost: Set dirty state in set_shader_buffers Otherwise the pointer (which is uploaded as a sysval) won't be updated when a new SSBO is bound. Fixes: c34b760b9f9 ("panfrost: Dirty track constant buffers") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15250> (cherry picked from commit b164ee0d7b1777f40bb3c5b26236ee5dde53536d) - - - - - 215ee9b8 by Icecream95 at 2022-03-10T23:23:59+00:00 panfrost: Re-emit descriptors after resource shadowing This could be made slightly more efficient by only setting the dirty state that is needed, but eventually you reach a point where it's cheaper to re-emit everything than work out what can or can't be kept.. Fixes rendering issues in Duckstation. Fixes: cd2c1ef9da6 ("panfrost: Dirty track textures/samplers") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15250> (cherry picked from commit d6c431c2e3eecc6de73bc302f93290766c4c4f04) - - - - - 26d8573c by Icecream95 at 2022-03-10T23:23:59+00:00 pan/bi: Make disassembler build reproducibly Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15250> (cherry picked from commit 42caddcf6ba9b358e26258eb195161d948c99bac) - - - - - 2e061263 by Icecream95 at 2022-03-10T23:23:59+00:00 panfrost: Fix ubo_mask calculation BITSET_MASK returns ~0 when given an input of zero, when we need it to return 0 instead. Fixes shaders with only sysvals but no UBOs when push constants are disabled. This breaks when 31 or 32 UBOs are used, but PAN_MAX_CONST_BUFFERS is currently set to 16. Fixes: c246af0dd80 ("panfrost: Only upload UBOs when needed") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15250> (cherry picked from commit 9d4441c71aa60b275ae1fccfc11b37705b02c118) - - - - - 7e57cfd1 by Alyssa Rosenzweig at 2022-03-10T23:23:59+00:00 panfrost: Fix set_sampler_views for big GL Roughly use the freedreno logic to handle all the extra things that will come up in our Piglit sooner than later. Signed-off-by: Alyssa Rosenzweig <[email protected]> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13203> (cherry picked from commit 304851422a4610170e870a5315fefaa5ec42917f) - - - - - 2579355e by Mike Blumenkrantz at 2022-03-10T23:24:00+00:00 zink: always update shader variants when rebinding a gfx program the variant data may have changed in the meanwhile, so do a pass to ensure that the correct variant is used cc: mesa-stable fixes caselist: dEQP-GLES31.functional.shaders.sample_variables.sample_mask.discard_half_per_two_samples.multisample_texture_4 dEQP-GLES31.functional.shaders.sample_variables.sample_mask.discard_half_per_two_samples.singlesample_rbo Acked-by: Emma Anholt <[email protected]> Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15226> (cherry picked from commit 9a6c58b2f7da74c5c20258f9a0b2c3681e79ef17) - - - - - 969b7b4a by Mike Blumenkrantz at 2022-03-10T23:24:00+00:00 zink: use a fence for pipeline cache update jobs otherwise there's nothing to wait on cc: mesa-stable Acked-by: Emma Anholt <[email protected]> Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15226> (cherry picked from commit 382798ddbde040b4900f47cbc2509a6338add011) - - - - - ffee4657 by Mike Blumenkrantz at 2022-03-10T23:24:00+00:00 zink: wait on program cache fences before destroying programs if these still have outstanding cache jobs, deleting the object now will cause a crash maybe fixes some cts flakiness? cc: mesa-stable Acked-by: Emma Anholt <[email protected]> Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15226> (cherry picked from commit c5f585f45afdde8c453c57dad744fd51caf6a699) - - - - - 7efd9443 by Mike Blumenkrantz at 2022-03-10T23:24:00+00:00 zink: fix descriptor cache pointer array allocation this got mixed up during some refactor and started indexing based on the number of bindings instead of the number of descriptors, which means that array descriptor bindings would have overlapping array memory cc: mesa-stable Acked-by: Emma Anholt <[email protected]> Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15226> (cherry picked from commit ab3725f533ecb0d4ecf7cefc6511fbcf15214b62) - - - - - 35790418 by Mike Blumenkrantz at 2022-03-10T23:24:00+00:00 zink: mark fbfetch push sets as non-cached these can't be cached, so ensure the value isn't uninitialized Test case 'KHR-GL46.blend_equation_advanced.blend_all.GL_HARDLIGHT_KHR_all_qualifier'.. ==1193311== Conditional jump or move depends on uninitialised value(s) ==1193311== at 0x634EF05: update_push_ubo_descriptors (zink_descriptors.c:1230) ==1193311== by 0x634FCC5: zink_descriptors_update (zink_descriptors.c:1412) ==1193311== by 0x63A5EA1: void zink_draw<(zink_multidraw)1, (zink_dynamic_state)3, true, false>(pipe_context*, pipe_draw_info const*, unsigned int, pipe_draw_indirect_info const*, pipe_draw_start_count_bias const*, unsigned int, pipe_vertex_state*, unsigned int) (zink_draw.cpp:788) ==1193311== by 0x635A0AF: void zink_draw_vbo<(zink_multidraw)1, (zink_dynamic_state)3, true>(pipe_context*, pipe_draw_info const*, unsigned int, pipe_draw_indirect_info const*, pipe_draw_start_count_bias const*, unsigned int) (zink_draw.cpp:907) ==1193311== by 0x6174397: tc_call_draw_single (u_threaded_context.c:3150) ==1193311== by 0x616C403: tc_batch_execute (u_threaded_context.c:211) ==1193311== by 0x616CA44: _tc_sync (u_threaded_context.c:362) ==1193311== by 0x61725E9: tc_texture_map (u_threaded_context.c:2274) ==1193311== by 0x5A9DAE9: pipe_texture_map_3d (u_inlines.h:572) ==1193311== by 0x5A9EB80: st_ReadPixels (st_cb_readpixels.c:530) ==1193311== by 0x5A0647A: read_pixels (readpix.c:1178) ==1193311== by 0x5A0647A: _mesa_ReadnPixelsARB (readpix.c:1195) ==1193311== by 0x5A06517: _mesa_ReadPixels (readpix.c:1210) cc: mesa-stable Acked-by: Emma Anholt <[email protected]> Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15226> (cherry picked from commit 9a91a520de76df3c192eeefbbcba6f955a9d5672) - - - - - 3cca717b by Mike Blumenkrantz at 2022-03-10T23:24:00+00:00 zink: stop leaking descriptor sets when migrating a recycled set here, the set was previously invalid and in the recycled table, meaning it can be reused directly so long as it's first invalidated the previous code would instead pop a different set off the allocation array, leaking this one cc: mesa-stable Acked-by: Emma Anholt <[email protected]> Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15226> (cherry picked from commit d63f3c31b74f26217cc8f8be9baff91043cde85c) - - - - - 1aba006c by Mike Blumenkrantz at 2022-03-10T23:24:00+00:00 zink: invalidate non-punted recycled descriptor sets that are not valid these sets may contain refs from the descriptors which need to be removed to avoid invalid memory access if the ref is leaked cc: mesa-stable Acked-by: Emma Anholt <[email protected]> Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15226> (cherry picked from commit e0030bc39f87dde018add3dfb256d2cfd1a7859e) - - - - - 45e0a5dd by Pierre-Eric Pelloux-Prayer at 2022-03-10T23:24:00+00:00 radeonsi: change rounding mode to round to even Use ROUND_TO_EVEN instead of TRUNCATE; this matches what pal and radv do. This fixes the spec@ext_framebuffer_multisample@turn-on-off tests. Cc: mesa-stable Reviewed-by: Marek Olšák <[email protected]> Reviewed-by: Mihai Preda <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15240> (cherry picked from commit 9c49550163ffd0753c55117f7ac2e800b1691e1c) - - - - - 129966c7 by Dave Airlie at 2022-03-10T23:24:00+00:00 gallivm/nir: extract a valid texture index according to exec_mask. When using indirect textures, some lanes may not be active, particularly in a loop, so as with some other areas, extracting the correct lane is needed here. This extracts the last valid one. KHR-GL45.texture_barrier.* on zink. Fixes: e168d148d76d ("gallivm/nir: handle non-uniform texture offsets") Acked-By: Mike Blumenkrantz <[email protected]> Reviewed-by: Roland Scheidegger <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15259> (cherry picked from commit 8346983775499119b8534d829c1db75e23c4097d) - - - - - 35f4051a by Mike Blumenkrantz at 2022-03-10T23:24:00+00:00 zink: fix 64bit float shader ops this was being set from back before zink actually supported 64bit natively and only 32bit was functional, but it breaks 64bit support cc: mesa-stable fixes (lavapipe): KHR-GL46.gpu_shader_fp64.builtin.mod_dvec2 KHR-GL46.gpu_shader_fp64.builtin.mod_dvec3 KHR-GL46.gpu_shader_fp64.builtin.mod_dvec4 Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15274> (cherry picked from commit 5fae35fb17d6d89c4fe1d9d5a19d827caf25b9fc) - - - - - 752af746 by Mike Blumenkrantz at 2022-03-10T23:24:01+00:00 llvmpipe: fix debug print iterating in set_framebuffer_state this would potentially access garbage memory by checking the existing state using the incoming state's iterator values cc: mesa-stable Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14857> (cherry picked from commit 4c76a19ca35ded99a2f13eef59a0cd161e3c43b0) - - - - - 7fc10535 by Mike Blumenkrantz at 2022-03-10T23:24:01+00:00 llvmpipe: clamp surface clear geometry avoid oob writes to avoid crashing cc: mesa-stable Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14655> (cherry picked from commit 165a880f1ae1f528d597bf3de138a29445b01a48) - - - - - c31de8e0 by Mike Blumenkrantz at 2022-03-10T23:24:01+00:00 lavapipe: update multisample state after blend state null blend pipeline state will zero the blend struct, which would cause values set here to be overwritten cc: mesa-stable Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15282> (cherry picked from commit 7114490115f1f1c95b647a0c400274f6f886ebf5) - - - - - 983da310 by Mike Blumenkrantz at 2022-03-10T23:24:01+00:00 aux/trace: rzalloc the context struct this has problems if pointers are garbage cc: mesa-stable Reviewed-by: Adam Jackson <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14854> (cherry picked from commit 8142fc5a455e010abf2ce55d0ad938f7ae88bb32) - - - - - eb7534ab by Pierre-Eric Pelloux-Prayer at 2022-03-10T23:24:01+00:00 util/slab: add slab_zalloc A a variant that clears the allocated object to 0. Cc: mesa-stable Acked-By: Mike Blumenkrantz <[email protected]> Reviewed-by: Rob Clark <[email protected]> Reviewed-by: Christian Gmeiner <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15298> (cherry picked from commit caeec6262df31fd0f5e9c0be233c2b1aed5380c0) - - - - - 0bef7767 by Pierre-Eric Pelloux-Prayer at 2022-03-10T23:24:01+00:00 gallium/tc: zero alloc transfers Otherwise this causes trouble with unitialized memory, eg with: struct si_transfer { struct threaded_transfer b; struct si_resource *staging; }; 'staging' will not be initialized and this causes #6109. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6109 Cc: mesa-stable Acked-By: Mike Blumenkrantz <[email protected]> Reviewed-by: Rob Clark <[email protected]> Reviewed-by: Christian Gmeiner <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15298> (cherry picked from commit 3c3a8f853dd8b43bfd51794f2a7d632feda396c4) - - - - - 434fabe2 by Erik Faye-Lund at 2022-03-10T23:24:01+00:00 docs: fixup zink gl 4.3 requirements The multiViewport feature isn't required for GL 4.3, it's required for GL 4.1. Technically speaking, we could have just dropped it because we already list the maxViewports requirement. But it seems better to be very clear here to me. Fixes: 29f8f21bff6 ("docs: document zink GL 4.3 requirements") Acked-by: Mike Blumenkrantz <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15300> (cherry picked from commit e66613497567026ce421057939d027e5913462b5) - - - - - e16f7f45 by Mike Blumenkrantz at 2022-03-10T23:24:01+00:00 zink: lower dmod on AMD hardware this hardware won't return the correct value from dmod instructions, so lower it to ensure that cts passes nobody else will ever hit this, so perf isn't an issue and regular fmod can be left alone fixes (amd): KHR-GL46.gpu_shader_fp64.builtin.mod_d* Fixes: 5fae35fb17d6d89c4fe1d9d5a19d827caf25b9fc ('zink: fix 64bit float shader ops ') Reviewed-by: Daniel Schürmann <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15306> (cherry picked from commit c24bca2d3a0e4255dbe155cfb7d942bfb104a2ad) - - - - - e3ff6df7 by Rob Clark at 2022-03-10T23:24:01+00:00 mesa: Fix discard_framebuffer for fbo vs winsys GL is annoying when it comes to having different enums for winsys vs fbo. Note that the issue this closes was only accidentially exposed by a change the resulted in sysmem vs GMEM path taken. Fixes: db2ae511210 ("mesa: Skip partial InvalidateFramebuffer of packed depth/stencil.") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6103 Signed-off-by: Rob Clark <[email protected]> Reviewed-by: Matt Turner <[email protected]> Reviewed-by: Emma Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15308> (cherry picked from commit f4ec900953ba61188ecf58c3f648b11f8ef64764) - - - - - 85c83203 by Jason Ekstrand at 2022-03-10T23:24:01+00:00 lavapipe: Reset the free_cmd_buffers list in TrimCommandPool We delete all the command buffers but they're still in the list so future allocations may try to re-use them post-free and another trim will re-delete them. Fixes: b38879f8c5f5 ("vallium: initial import of the vulkan frontend") Reviewed-by: Boris Brezillon <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15311> (cherry picked from commit 66cb64c8ad339848e7538faa24800755dc6221f8) - - - - - 0f739214 by Connor Abbott at 2022-03-10T23:24:02+00:00 ir3/ra: Sanitize parallel copy flags better For pcopies we only care about the register's type, i.e. whether its a half-register and whether it's an array (plus its size). Copying over other flags like IR3_REG_RELATIV just leads to sadness and validator assertions. Fixes: 0ffcb19b9d9 ("ir3: Rewrite register allocation") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14107> (cherry picked from commit ab0ed4ff3f2eed6610597a0f0b42b8ca829790f9) - - - - - de9ad8b0 by Connor Abbott at 2022-03-10T23:24:02+00:00 util/bitset: Fix off-by-one in __bitset_set_range Fixes: b3b03e33c9f ("util/bitset: add BITSET_SET_RANGE(..)") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14107> (cherry picked from commit 410e746198b498efdb9c37a63a0b8aad67469a4c) - - - - - bb8f6811 by Dave Airlie at 2022-03-10T23:24:02+00:00 zink: workaround depth texture mode alpha. Since spir-v only has single channel depth sampling, it breaks with the old school GL_ALPHA depth mode swizzle, so just detect that case and smash all the channels. Cc: mesa-stable Reviewed-By: Mike Blumenkrantz <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15297> (cherry picked from commit 30cb63bead12ad0d7ff66a6a267400c3a07c4f86) - - - - - 444c93f6 by Dave Airlie at 2022-03-10T23:24:02+00:00 lavapipe: remove broken workaround for zink depth texturing. Cc: mesa-stable Reviewed-By: Mike Blumenkrantz <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15297> (cherry picked from commit 938488f43986e21a22be5c8b8c7be4fcc60af989) - - - - - 282b323e by Mike Blumenkrantz at 2022-03-10T23:24:02+00:00 lavapipe: skip format checks for EXTENDED_USAGE we can effectively skip any kind of checks here and just assume that one of two scenarios is in effect: * the user is about to attempt some incredibly illegal behavior that VVL will catch * the user is about to attempt a pro gamer move and we'll be fine in either case, it's EXTENDED_USAGE, so hopefully we're about to make a texture view from a compatible and supported format cc: mesa-stable fixes: dEQP-VK.image.extended_usage_bit_compatibility.image_format_properties* Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15320> (cherry picked from commit 6a4c7ef7286f50b5396ffc68bcf6ad33eb67de07) - - - - - 2e8d69c0 by Mike Blumenkrantz at 2022-03-10T23:24:02+00:00 lavapipe: run nir_opt_copy_prop_vars during optimization loop this enables better elimination of operations fixes: dEQP-VK.graphicsfuzz.spv-stable-mergesort-flatten-selection-dead-continues fixes #5458 cc: mesa-stable Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15322> (cherry picked from commit cf5c32a4b2d839305ef2104ab0acf973e63b940a) - - - - - 722a83ae by Eric Engestrom at 2022-03-18T19:26:42+00:00 docs: add release notes for 21.3.8 - - - - - 813ee839 by Eric Engestrom at 2022-03-18T19:26:47+00:00 VERSION: bump for 21.3.8 - - - - - f900eaf2 by Timo Aaltonen at 2022-04-09T15:56:53+03:00 Merge tag 'mesa-21.3.8' into debian-unstable mesa-21.3.8 - - - - - 55ba7d86 by Timo Aaltonen at 2022-04-10T10:11:56+03:00 version bump - - - - - 8953e7d5 by Timo Aaltonen at 2022-04-10T10:18:16+03:00 install: Add radv defaults dri conf. - - - - - afc47715 by Timo Aaltonen at 2022-04-10T10:18:27+03:00 release to sid - - - - - 0 changed files: The diff was not included because it is too large. View it on GitLab: https://salsa.debian.org/xorg-team/lib/mesa/-/compare/d4361358ae4e81a63fdf1129538c4050f0ca5f0b...afc47715d346b5d6ef12f0583fbd96d50fa0c0b8 -- View it on GitLab: https://salsa.debian.org/xorg-team/lib/mesa/-/compare/d4361358ae4e81a63fdf1129538c4050f0ca5f0b...afc47715d346b5d6ef12f0583fbd96d50fa0c0b8 You're receiving this email because of your account on salsa.debian.org.
