Timo Aaltonen pushed to branch debian-unstable at X Strike Force / lib / mesa
Commits: 276f31c6 by Eric Engestrom at 2023-01-26T17:36:37+00:00 docs/relnotes: add sha256sum for 22.3.4 - - - - - 8b883564 by Eric Engestrom at 2023-02-08T20:34:26+00:00 .pick_status.json: Update to 6390953fa5c0e0a001ce6c07f704366c18f85ccf - - - - - c6d2afcc by Corentin Noël at 2023-02-08T20:34:39+00:00 kopper: Do not free the given screen in initScreen implementation The given screen is already freed by the caller in case a NULL-pointer is returned by the implementation. Cc: mesa-stable Signed-off-by: Corentin Noël <[email protected]> Reviewed-By: Mike Blumenkrantz <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20933> (cherry picked from commit dd3730f8bdd7afdbc7fb0e9dd200951f9d713a34) - - - - - 987e4f54 by Kenneth Graunke at 2023-02-08T20:34:39+00:00 loader: Add infrastructure for tracking active CRTC resources This provides a cached view of the current screen resources, with the coordinates and refresh rate for every active CRTC. It's currently only implemented for X11/XCB. Fixes: 47526556494 ("egl/x11: implement ANGLE_sync_control_rate") Reviewed-by: Adam Jackson <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20665> (cherry picked from commit 3170b63314f14f0031cb95bd5ee3a4726f26b43b) - - - - - b52fbf71 by Kenneth Graunke at 2023-02-08T20:34:39+00:00 egl: Rewrite eglGetMscRateANGLE to avoid probes and handle multi-monitor RRGetScreenInfo re-probes connector status, which may result in an EDID transfer for every output, which according to Adam Jackson can be on the order of 100ms for a single EDID block. So our previous implementation of this eglGetMscRateANGLE was blocking for excessive periods of time instead of being a quick query of the refresh rate like users expect. This changes our eglGetMscRateANGLE implementation from using RRGetScreenInfo to RRGetScreenResourcesCurrent and RRGetCrtcInfo. This obtains the same monitor info without re-probing connectors. Fixes a severe performance regression in Chromium WebGL performance. While we're re-implementing the extension, we also implement proper multi-monitor support: if there are multiple active CRTCs, we determine which contains the largest portion of the surface, as specified in the EGL_ANGLE_sync_control_rate extension. We also now report fractional refresh rates correctly rather than rounding to the nearest Hz. Fixes: 47526556494 ("egl/x11: implement ANGLE_sync_control_rate") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6996 Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7038 Reviewed-by: Adam Jackson <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20665> (cherry picked from commit 41d5f0ee09ccc6406d9b57351fa95edf30b03298) - - - - - 68246581 by Samuel Pitoiset at 2023-02-08T20:34:39+00:00 radv: add a layer for fixing rendering issues with RAGE2 This game seems to incorrectly set the render area and since we switched to full dynamic rendering, the framebuffer dimensions is no longer used. Forcing the render area to be the framebuffer dimensions restore the previous logic and it fixes rendering issues. Fixes: c7d0d328d56 ("radv: Set the window scissor to the render area, not framebuffer") Signed-off-by: Samuel Pitoiset <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20900> (cherry picked from commit 1a93cd15563a5d0bb6faf12c5d4c852cb3534415) - - - - - c02ae859 by Rhys Perry at 2023-02-08T20:34:39+00:00 aco: set has_color_exports with GPL Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Samuel Pitoiset <[email protected]> Fixes: 192486b7aa5 ("aco/gfx11: export mrtz in discard early exit for non-color shaders") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20937> (cherry picked from commit 695cf75266f43c0f9d123c5030b136bbdf061d4c) - - - - - bd723283 by Mike Blumenkrantz at 2023-02-08T20:34:39+00:00 Revert "zink: allow direct memory mapping for any COHERENT+CACHED buffer" This reverts commit a3552048c7e7b8afebfc99caac6d555439ddf2bc. on some drivers this catches qbos, which then hits the below assert. needs more investigation Fixes: a3552048c7e ("zink: allow direct memory mapping for any COHERENT+CACHED buffer") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20912> (cherry picked from commit 07809c45271a25066c583ca90b7365e0d88daf0d) - - - - - 18af0f23 by Mike Blumenkrantz at 2023-02-08T20:34:40+00:00 zink: add VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT for buffers if ext is enabled cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20912> (cherry picked from commit c545300f30bc1d6558c066466052ec6a0acb3bed) - - - - - 2105b352 by Mike Blumenkrantz at 2023-02-08T20:34:40+00:00 zink: set vkusage/vkflags for buffer resource objects this needs to be populated for other places in the driver that need it cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20912> (cherry picked from commit 3c562cfc06417ca52738460bbe63ad972f26f4c5) - - - - - 9267c30f by Eric Engestrom at 2023-02-08T20:34:40+00:00 .pick_status.json: Mark cc9fa060ee1b232e5e72077232d7b90c92dfc1bd as denominated - - - - - a4c42697 by Eric Engestrom at 2023-02-08T20:34:40+00:00 .pick_status.json: Mark 6f7b752fdd2f5f33139dbc105da433ef6f11f112 as denominated - - - - - ae63d102 by Eric Engestrom at 2023-02-08T20:34:40+00:00 .pick_status.json: Mark ac339d97978e96c80d43688566717d4c4f6fa7f3 as denominated - - - - - 552902a4 by Lionel Landwerlin at 2023-02-08T20:34:40+00:00 anv: fix null descriptors When writing descriptor with a null buffer/image we expect that writing 0 will point to the null surface. For that to work the null surface has to be in the bindless surface heap. This fixes some new failures in dEQP-VK.robustness.* tests once rewritten from the NV_ray_tracing to KHR_ray_tracing extension. Signed-off-by: Lionel Landwerlin <[email protected]> Fixes: 4ceaed7839 ("anv: split internal surface states from descriptors") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7762 Reviewed-by: Jason Ekstrand <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20953> (cherry picked from commit 0d7f8aa2499104b1d16deba32e4c25c342d1ce7d) - - - - - d5d88aa1 by Lucas Stach at 2023-02-08T20:34:40+00:00 etnaviv: drm: fix BO array leaks Free the both arrays tracking BOs when the etna_cmd_stream is destroyed. CC: mesa-stable Signed-off-by: Lucas Stach <[email protected]> Reviewed-by: Christian Gmeiner <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20940> (cherry picked from commit 3156b15f70c83d954db9d8ffac90988c7b71a194) - - - - - 480b9ff4 by Lucas Stach at 2023-02-08T20:34:40+00:00 etnaviv: free pm queries dynarray on screen destroy CC: mesa-stable Signed-off-by: Lucas Stach <[email protected]> Reviewed-by: Christian Gmeiner <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20940> (cherry picked from commit c59369005bf42c2981561643d8b0eb15b1b52581) - - - - - 8459995e by Lucas Stach at 2023-02-08T20:34:40+00:00 etnaviv: drm: fix check if BO is on a deferred destroy list list_is_linked() isn't the right function to use in order to check if the BO is on a cache bucket or the zombie list, as this checks if the next pointer of the list isn't NULL. This is always the case with the BO list item as it's always initialized, so the next pointer points to the list head itself when the BO isn't on any list. Use list_is_empty() to check if the BO is actually linked into one of the deferred destroy lists. Fixes: 1b1f8592c03c ("etnaviv: drm: properly handle reviving BOs via a lookup") Signed-off-by: Lucas Stach <[email protected]> Reviewed-by: Christian Gmeiner <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20940> (cherry picked from commit 196882a1477a69ba1593db8bdaaf6726fe914fca) - - - - - 30218695 by Hyunjun Ko at 2023-02-08T20:34:41+00:00 vulkan/runtime: match the spec when taking pipeline subsets. Signed-off-by: Hyunjun Ko <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21006> (cherry picked from commit c489b3eadb1570762fe2362b9c0e78090ee8c127) - - - - - eca296b0 by Eric Engestrom at 2023-02-08T20:34:41+00:00 .pick_status.json: Mark 4b841cfec8b502a8290cd67356d811933d318c2b as denominated - - - - - 14483d16 by Bas Nieuwenhuizen at 2023-02-08T20:34:41+00:00 radv: Set FDCC_CONTROL SAMPLE_MASK_TRACKER_WATERMARK Might cause hangs according to comments. Syncs with radeonsi/PAL. Fixes: e210ffb4d0d ("radv: update framebuffer registers on GFX11") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20979> (cherry picked from commit d321bc1323b02de92a095397830c9296996e16b3) - - - - - 7689e2df by Bas Nieuwenhuizen at 2023-02-08T20:34:41+00:00 radv: Shift left the tile swizzle more on GFX11. ac/surface puts the raw pip_bank_xor there, which needs the extra shift for the actual tile_swizzle. (I think long term we should refactor this in ac/surface but for now lets fix like radeonsi to avoid race conditions.) CC: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20979> (cherry picked from commit b0a9772cc6154e29ba6e3d21a91096dd891ef302) - - - - - 9db2229a by Eric Engestrom at 2023-02-08T20:34:41+00:00 .pick_status.json: Mark 47852b9ff45e73f8f6773a1598cf872c6ee6207f as denominated - - - - - f7aba11a by Samuel Pitoiset at 2023-02-08T20:34:41+00:00 radv: fix RB+ for SRGB formats This should be set for linear colorspace only. Ported from RadeonSI. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20982> (cherry picked from commit c8a575eb3098282f495948b728abd45768dc5d01) - - - - - 732beb96 by Mike Blumenkrantz at 2023-02-08T20:34:41+00:00 zink: don't add dmabuf export type if dmabuf isn't supported avoid trying to create dmabuf-exportable resources too cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20791> (cherry picked from commit 01d2e7afce562013a8cb9b6b9fd1190e317e896a) - - - - - adf5b07f by Mike Blumenkrantz at 2023-02-08T20:34:41+00:00 zink: stop leaking push descriptor templates templates[ZINK_DESCRIPTOR_TYPE_UNIFORMS] needs to be deleted, which requires a larger iterator cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20867> (cherry picked from commit dd733034aa117294be0f06b5b973b18d1c341666) - - - - - 986cd349 by Mike Blumenkrantz at 2023-02-08T20:34:42+00:00 zink: always unref old images when adding new binds at some point this was correct, but refactoring has since occurred, and this ends up leaking storage image objects cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20867> (cherry picked from commit d745e3b0ab4614136f1c8d93feb54b612fd58d3f) - - - - - 36ded4ae by Eric Engestrom at 2023-02-08T20:34:42+00:00 .pick_status.json: Mark 13de23ea07dd7e1340fd9b72367996fa3c2433ee as denominated - - - - - 4710d25a by Rhys Perry at 2023-02-08T20:34:42+00:00 aco: end reduce tmp after control flow, when used within control flow In the case of: v0 = start_linear_vgpr if (...) { } else { use_linear_vgpr(v0) } v0 = phi We need a p_end_linear_vgpr to ensure that the phi does not use the same VGPR as the linear VGPR. fossil-db (gfx1100): Totals from 3763 (2.80% of 134574) affected shaders: MaxWaves: 90296 -> 90164 (-0.15%) Instrs: 6857726 -> 6856608 (-0.02%); split: -0.03%, +0.01% CodeSize: 35382188 -> 35377688 (-0.01%); split: -0.02%, +0.01% VGPRs: 234864 -> 235692 (+0.35%); split: -0.01%, +0.36% Latency: 47471923 -> 47474965 (+0.01%); split: -0.03%, +0.04% InvThroughput: 5640320 -> 5639736 (-0.01%); split: -0.04%, +0.03% VClause: 93098 -> 93107 (+0.01%); split: -0.01%, +0.02% SClause: 214137 -> 214130 (-0.00%); split: -0.00%, +0.00% Copies: 369895 -> 369305 (-0.16%); split: -0.31%, +0.15% Branches: 164996 -> 164504 (-0.30%); split: -0.30%, +0.00% PreVGPRs: 210655 -> 211438 (+0.37%) Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Daniel Schürmann <[email protected]> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20621> (cherry picked from commit 44fdd2ebcb271011665dd100ba9ef6852cddb22e) - - - - - b8ae5882 by Rhys Perry at 2023-02-08T20:34:42+00:00 aco/spill: always end spill vgpr after control flow To fix a hypothetical issue: v0 = start_linear_vgpr if (...) { } else { use_linear_vgpr(v0) } v0 = phi We need a p_end_linear_vgpr to ensure that the phi does not use the same VGPR as the linear VGPR. This is also much simpler. fossil-db (gfx1100): Totals from 1195 (0.89% of 134574) affected shaders: Instrs: 4123856 -> 4123826 (-0.00%); split: -0.00%, +0.00% CodeSize: 21461256 -> 21461100 (-0.00%); split: -0.00%, +0.00% Latency: 62816001 -> 62812999 (-0.00%); split: -0.00%, +0.00% InvThroughput: 9339049 -> 9338564 (-0.01%); split: -0.01%, +0.00% Copies: 304028 -> 304005 (-0.01%); split: -0.02%, +0.01% PreVGPRs: 115761 -> 115762 (+0.00%) Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Daniel Schürmann <[email protected]> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20621> (cherry picked from commit bbc5247bf71cebfdb2ee79646bd2231a909a74eb) - - - - - 52b984e5 by José Roberto de Souza at 2023-02-08T20:34:42+00:00 intel/ds: Nuke intel_ds_queue::queue_id queue_id is not used anywhere. Signed-off-by: José Roberto de Souza <[email protected]> Reviewed-by: Marcin Ślusarz <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20888> (cherry picked from commit 5ccc2049fae591d1baf6f581bbd0e3953c0ee5fa) - - - - - 58a32018 by José Roberto de Souza at 2023-02-08T20:34:42+00:00 intel/ds: Fix crash when allocating more intel_ds_queues than u_vector was initialized u_vector_add() don't keep the returned pointers valid. After the initial size allocated in u_vector_init() is reached it will allocate a bigger buffer and copy data from older buffer to the new one and free the old buffer, making all the previous pointers returned by u_vector_add() invalid and crashing the application when trying to access it. This is reproduced when running dEQP-VK.synchronization.signal_order.timeline_semaphore.* in DG2 SKUs that has 4 CCS engines, INTEL_COMPUTE_CLASS=1 is set and of course perfetto build is enabled. To fix this issue here I'm moving the storage/allocation of struct intel_ds_queue to struct anv_queue/iris_batch and using struct list_head to maintain a chain of intel_ds_queue of the intel_ds_device. This allows us to append or remove queues dynamically in future if necessary. Fixes: e760c5b37be9 ("anv: add perfetto source") Reviewed-by: Lionel Landwerlin <[email protected]> Signed-off-by: José Roberto de Souza <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20977> (cherry picked from commit 8092bc2158ebb8a5f85e0ec569387c5dcd0d1627) - - - - - 444fc67a by Rhys Perry at 2023-02-08T20:34:42+00:00 aco: limit VALUPartialForwardingHazard search Complicated CFG and lots of SALU can cause this to take an extremely long time to finish. Fixes dEQP-VK.graphicsfuzz.cov-value-tracking-selection-dag-negation-clamp-loop and Monster Hunter Rise demo compile times. fossil-db (gfx1100): Totals from 57 (0.04% of 134574) affected shaders: Instrs: 170919 -> 171165 (+0.14%) CodeSize: 860144 -> 861128 (+0.11%) Latency: 961466 -> 961505 (+0.00%) InvThroughput: 127598 -> 127608 (+0.01%) Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Timur Kristóf <[email protected]> Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8153 Fixes: 5806f0246fd ("aco/gfx11: workaround VALUPartialForwardingHazard") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20941> (cherry picked from commit bfd4ac4581bae0d36b2c58524131f91c7c0d27ce) - - - - - 773e3cb7 by Eric Engestrom at 2023-02-08T20:34:42+00:00 .pick_status.json: Mark a568a5492f1dd7eb8c08247b74df2aae498b0863 as denominated - - - - - 390d4c7e by Sagar Ghuge at 2023-02-08T20:34:43+00:00 intel/fs: Always stall between the fences on Gen11+ Be conservative in Gfx11+ and always stall in a fence. Since there are two different fences, and shader might want to synchronize between them. This change also brings back the original code block for the stall between the fence and comment from the commit b390ff35170fdc2b7f1fb1709a79d81edcd56981. v2: (Caio) - Re-arrange code block. - Adjust comment. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6958 Fixes: f7262462 ("intel/fs: Rework fence handling in brw_fs_nir.cpp") Signed-off-by: Sagar Ghuge <[email protected]> Tested-by: Mark Janes <[email protected]> Reviewed-by: Caio Oliveira <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20996> (cherry picked from commit 0c083d29a55bf20a993eab82786d583403582c8c) - - - - - 62858c93 by Eric Engestrom at 2023-02-08T20:34:43+00:00 .pick_status.json: Mark d23b3a13943576bbb8dd0fea12ac717c40b376e1 as denominated - - - - - 00da41e6 by Marek Olšák at 2023-02-08T20:34:43+00:00 Revert "radeonsi: enable glthread by default" This reverts commit d6fabe49cd72fb7f7087b12efd8a9e3371e36c01. It has issues that are not worth fixing in this release branch in my opinion. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21087> - - - - - 2dbe1e8e by Lucas Stach at 2023-02-08T20:34:43+00:00 etnaviv: fix double scanout import of multiplanar resources etna_resource_from_handle() is called for each plane of a multiplanar resource, so there is no point in looping over all planes to do the renderonly scanout import. In fact that will cause us to lose track of the scanout imports from later planes when the earlier planes are redoing the import, overwriting the pointer to the allocated renderonly_scanout struct. Drop the loop and just do the import for the current plane. Fixes: 826f95778a4e ("etnaviv: always try to create KMS side handles for imported resources") Signed-off-by: Lucas Stach <[email protected]> Reviewed-by: Philipp Zabel <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20993> (cherry picked from commit 175732bb51c81513ae05f9313d6df7c0631ef159) - - - - - b1f45418 by Marek Olšák at 2023-02-08T20:34:43+00:00 radeonsi: fix RB+ blending with sRGB formats The epsilon for 8bpc is for the linear colorspace. There is no epsilon for sRGB. Fixes: 17021efc742 - radeonsi: adjust RB+ blend optimization settings Acked-by: Pierre-Eric Pelloux-Prayer <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041> (cherry picked from commit 8556b3db71683fc0393b7f75b0317890c8c0ae4e) - - - - - 88fd0585 by Marek Olšák at 2023-02-08T20:34:43+00:00 radeonsi/gfx11: unset SAMPLE_MASK_TRACKER_WATERMARK to fix hangs Same as PAL. Fixes: 529eb739fc4 - radeonsi/gfx11: add CB deltas Reviewed-by: Pierre-Eric Pelloux-Prayer <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041> (cherry picked from commit 66d11391f76c0892388d933282fbc74028d9edc4) - - - - - d2180809 by Marek Olšák at 2023-02-08T20:34:43+00:00 amd: split GFX1103 into GFX1103_R1 and GFX1103_R2 Fixes: caa09f66ae4 - amd: add chip identification for gfx1100-1103 Reviewed-by: Pierre-Eric Pelloux-Prayer <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041> (cherry picked from commit 84d59cdb5971424a4297e288b852c8cc15c46163) - - - - - 2da08ed3 by Marek Olšák at 2023-02-08T20:34:43+00:00 amd: fix tile_swizzle on gfx11 - should be shifted by 10 bits, not 8 This reverts the radv_adjust_tile_swizzle change to unify the code. Fixes: 529eb739fc4 - radeonsi/gfx11: add CB deltas Reviewed-by: Pierre-Eric Pelloux-Prayer <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041> (cherry picked from commit 47f598a183e849dfee4a587b51074664ee778312) - - - - - e10b4ffa by Marek Olšák at 2023-02-08T20:34:43+00:00 amd: fix typo in shadowed uconfig registers on gfx11 It used an invalid offset, which hung. Fixes: f24f8665dbe2a - ac: implement register shadowing for gfx11 Reviewed-by: Pierre-Eric Pelloux-Prayer <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041> (cherry picked from commit 76472c850b7f93a5389c473a9cf87685ad97cb72) - - - - - 9a5bec66 by Constantine Shablya at 2023-02-08T20:34:44+00:00 anv: handle ATTACHMENT_OPTIMAL layout Closes: #8216 Reviewed-by: Lionel Landwerlin <[email protected]> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21066> (cherry picked from commit 9b3b7e509106976b131df85f0462df299a44c80f) - - - - - eadaef0f by Timur Kristóf at 2023-02-08T20:34:44+00:00 radv: Disable NGG culling when conservative overestimation is used. Even when small primitive culling is disabled, the face culling algorithm in ac_nir_cull can delete tiny triangles when their area is almost zero. Cc: mesa-stable Signed-off-by: Timur Kristóf <[email protected]> Reviewed-by: Samuel Pitoiset <[email protected]> Reviewed-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20987> (cherry picked from commit 3508597aa1b88d1b5a6f78ad53d8abcc32cde2c9) - - - - - b742313e by Qiang Yu at 2023-02-08T20:34:44+00:00 ac/nir/ngg: fix clip dist culling mask uninitialized Fixes: f75452918b2 ("ac/nir/ngg: support clipdist culling") Reviewed-by: Timur Kristóf <[email protected]> Reviewed-by: Marek Olšák <[email protected]> Signed-off-by: Qiang Yu <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20691> (cherry picked from commit d798214c7b25b0bf2ce6b094475913a1f72585b8) - - - - - 28e5823a by Dylan Baker at 2023-02-08T20:34:44+00:00 meson: combine checks for linker --gc-sections support We first do an incomplete check for whether the linker supports --gc-sections, then potentially add C and C++ arguments assuming that it works, then later do a complete check to see if it actually works and use --gc-sections. This means we can end up putting functions and data in separate sections when we can't gc them. Combine the checks, do less work, and be more accurate. fixes: f51ce21e4e0bf7efabe58afb4a2cd6b9f98d9505 ("meson: Drop adding -Wl,--gc-sections to project c/cpp arguments.") Reviewed-by: Eric Engestrom <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21083> (cherry picked from commit fd9b50aa1c07512c46ec981f19ea68fa4b8d7b4f) - - - - - c8aa0587 by SoroushIMG at 2023-02-08T20:34:44+00:00 zink: fix sparse residency query and minLOD feature checks cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21013> (cherry picked from commit 4f8ba2b9aae265dfc56a62e85cd5eab3c4c718f3) - - - - - 489f1293 by SoroushIMG at 2023-02-08T20:34:44+00:00 zink: fix cap check for arb sparse texture2 arb_sparse_texture2 also enables multisampled sparse textures. bring back the check for msaa support. fixes #8229 Fixes: 4f8ba2b9aae ("zink: fix sparse residency query and minLOD feature checks") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21121> (cherry picked from commit 8f928a95e167423320af711b21270a8212f34628) - - - - - 18f0d334 by Timur Kristóf at 2023-02-08T20:34:44+00:00 ac/nir/ngg: Include culled primitives in query. Vulkan spec 18.8. Primitives Generated Queries: When a generated primitive query for a vertex stream is active, the primitives-generated count is incremented every time a primitive emitted to that stream reaches the transform feedback stage, whether or not transform feedback is active. We can see the order of stages in chapter 27 Fixed-Function Vertex Post-Processing, which shows that the transform feedback stage is before rasterization (and therefore culling). Conclusion is that culled primitives should be included in the primitives generated query. This commit makes sure to emit the primitives generated query code before culling and uses the input primitive count passed to the current wave instead of the exec mask after culling. Cc: mesa-stable Signed-off-by: Timur Kristóf <[email protected]> Reviewed-by: Samuel Pitoiset <[email protected]> Reviewed-by: Qiang Yu <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21037> (cherry picked from commit 3a819bd22ec5a7eea2e0e337977cbc0af9e38032) - - - - - e29a84fc by Konstantin Seurer at 2023-02-08T20:34:44+00:00 ac/llvm: Fix validation error with global io Fixes: afd645f0576 ("ac/llvm: remove LLVMBuildGEP usages") Reviewed-by: Pierre-Eric Pelloux-Prayer <[email protected]> Reviewed-by: Samuel Pitoiset <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20521> (cherry picked from commit 10ac51a52bad2c2378b2d847eae23e1366ddc46f) - - - - - 72fbe445 by Rhys Perry at 2023-02-08T20:34:45+00:00 radv: set state.vbo_misaligned_mask_invalid in radv_bind_vs_input_state Found by inspection. Something probably hangs because of this, but I don't know what. Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Tatsuyuki Ishi <[email protected]> Reviewed-by: Samuel Pitoiset <[email protected]> Fixes: c199a5160a0 ("radv: bind the VS input state for prologs created with GPL") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20913> (cherry picked from commit 10a5035c836a852fcdc7a4532d9ec1af5fd3464d) - - - - - 21e6f53a by SoroushIMG at 2023-02-08T20:34:45+00:00 zink: only save frag const buffers when used by blit fixes upload manager constant buffer leak. zink only needs to save the const buffer for stencil fallback blits. cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21134> (cherry picked from commit 4c647c9e259a6a0fc1499c377a07bfd0ba902079) - - - - - 4f58fe67 by SoroushIMG at 2023-02-08T20:34:45+00:00 zink: fix leak when rebinding same image surface simple way to reproduce this is to run these 4 together: KHR-GL46.gpu_shader5.images_array_indexing KHR-GL46.shader_image_load_store.advanced-allMips KHR-GL46.shader_image_load_store.advanced-sso-simple KHR-GL46.shader_image_load_store.incomplete_textures cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21134> (cherry picked from commit 104040b5c7135403194005951e57197ef76438a6) - - - - - df96e9c0 by SoroushIMG at 2023-02-08T20:34:45+00:00 zink: clear null image surfaces to 0 GL Spec says that imageLoad from incomplete images must return 0. This is not really spec compliant as for proper behavior nullDescriptor and robustImageAccess2 is needed. A workaround for lack of either of these requires a shader variant. Clearing the null surface and hoping the app doesn't write to the image is closer to spec, while avoiding a shader recompile. KHR-GL46.shader_image_load_store.incomplete_textures tests this. cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21135> (cherry picked from commit 22e91af1a77361249b9c71ee609b67ec187e612c) - - - - - edb82453 by Mike Blumenkrantz at 2023-02-08T20:34:45+00:00 zink: fix max acquired image count according to spec, the maximum number of acquired images can be calculated with swapchain_size - VkSurfaceCapabilitiesKHR::minImageCount + 1 the previous calculation was both wrong and occurring in the wrong place, so this corrects both issues cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21095> (cherry picked from commit 89cf0a3bdc9949c54d8d7965a2d51bed91b6d10a) - - - - - 3e5da1cc by Yuxuan Shui at 2023-02-08T20:34:45+00:00 loader: unregister special event in loader_dri3_drawable_fini This was inadvertently removed in 98a6cfd3953 and causes continuous memory leaks as events are being received after the context has been unbound. Fixes: 3170b63314f ("loader: Add infrastructure for tracking active CRTC resources") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8238 Signed-off-by: Yuxuan Shui <[email protected]> Reviewed-by: Kenneth Graunke <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21128> (cherry picked from commit 27a89a0903f2c541541846e8d909bb67af242d5e) - - - - - 9d4413d6 by pal1000 at 2023-02-08T20:34:45+00:00 meson: Ignore unused variables when assertions are disabled Fixes: 46b099e3 ("meson: Ignore unused variables in release builds") 46b099e3 has some issues: - it doesn't enable unused variables warning on release builds with assertions enabled; - it doesn't disable unused variables warning on debug builds with assertions disabled; - it doesn't disable unused variables warning when building with MSVC and assertions are disabled regardless of buildtype, see #8147. 3/4 regressions reported there have this limitation alone as root cause. Reviewed-by: Emma Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21154> (cherry picked from commit 4347072443867f6337c33ffc330263bb851d9839) - - - - - 1e657620 by Iago Toral Quiroga at 2023-02-08T20:34:45+00:00 v3dv: ensure at least V3D_CL_MAX_INSTR_SIZE bytes in last CL instruction The CLE parser in the sim will read this many bytes for each instruction in a CL, so we should ensure we have at least that many bytes available in the BO when reading the last instruction, otherwise we can trigger a GMP violation. It is not clear whether this behavior applies to real hardware too. cc: mesa-stable Reviewed-by: Alejandro Piñeiro <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21162> (cherry picked from commit c2601f06908434aaddd6b1db5e995bbda22d2a72) - - - - - abfbec7a by Iago Toral Quiroga at 2023-02-08T20:34:46+00:00 v3dv: ensure we apply binning syncs to secondary command buffers Currently, we postpone binning syncs until we record draw calls and can validate if any of them require accessing protected resources in the binning stage, however, if the draw calls are recorded in a secondary command buffer and the barriers have been recorded in the primary command buffer, we won't apply the binning sync in the secondary when we record the draw calls and so we must apply it when we execute the secondary in the primary. Fixes flakyness in: dEQP-VK.api.command_buffers.record_many_draws_secondary_2 cc: mesa-stable Reviewed-by: Alejandro Piñeiro <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21162> (cherry picked from commit fec15a225f603f7a980241ce6b7fad35dfc6aff4) - - - - - bc9220de by Mike Blumenkrantz at 2023-02-08T20:34:46+00:00 lavapipe: disable VK_FORMAT_FEATURE_2_COLOR_ATTACHMENT_BLEND_BIT for int formats this is unsupported and undefined by the spec cc: mesa-stable Reviewed-by: Roland Scheidegger <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21099> (cherry picked from commit 7d8e2db9f95747895b6cd137cb1db445b3a1a66f) - - - - - f615ca74 by Rhys Perry at 2023-02-08T20:34:46+00:00 aco: fix out-of-bounds access when moving s_mem(real)time across SMEM Signed-off-by: Rhys Perry <[email protected]> Reviewed-by: Georg Lehmann <[email protected]> Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8224 Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21138> (cherry picked from commit fad1f716dd831fba4c380bce1cf76bffc11be6d6) - - - - - c5285939 by Ian Romanick at 2023-02-08T20:34:46+00:00 lavapipe: Fix bad array index scale factor in lvp_inline_uniforms pass A few lines earlier uni_offsets is accessed with ubo scaled by PIPE_MAX_CONSTANT_BUFFERS: if (uni_offsets[ubo * PIPE_MAX_CONSTANT_BUFFERS + i] == offset) Found by inspection. Looking at the before and after NIR code for dEQP-VK.graphicsfuzz.cov-int-initialize-from-multiple-large-arrays, using the correct indexing appears to enable the pass to inline an additional uniform. My guess is that when a uniform is used more than once, the first loop wouldn't find the offset recored in the table because it was recorded at the wrong location. Fixes: d23a9380dd6 ("lavapipe: implement extreme uniform inlining") Reviewed-By: Mike Blumenkrantz <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21144> (cherry picked from commit a7696a4d98bcf4cdfae1c56a21c4deb3a9ce004f) - - - - - a194c941 by SoroushIMG at 2023-02-08T20:34:46+00:00 zink: fix pointcoord y inversion Point sprite coordinates in general need to be inverted, not just the texcoords converted to point sprite. Move point coord y inversion out to its own pass. Fixes GTF-GL46.gtf21.GL2FixedTests.point_sprites.point_sprites with FBO dEQP surface. cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21050> (cherry picked from commit 782f1e9e010452850853b9791e673f2e1a7a671e) - - - - - bf586009 by Mike Blumenkrantz at 2023-02-08T20:34:46+00:00 zink: add a define for the "default" optimal key Reviewed-by: Emma Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169> (cherry-picked from 1f08a6dcdbf382a7586b703379969bdd3113c02e) - - - - - 3d71f973 by Mike Blumenkrantz at 2023-02-08T20:34:46+00:00 zink: add a define for testing that an optimal key is the default tcs values here are ignored since they only matter for generated tcs Reviewed-by: Emma Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169> (cherry picked from commit 7c021cc5f05d24211f327ea16d686f4bd9986465) - - - - - e9b16282 by Mike Blumenkrantz at 2023-02-08T20:34:46+00:00 zink: set gfx feedback loop bit in pipeline state for driver workaround this needs to be set on context create or it may never get set Fixes: 645f2da3faf ("zink: always set VK_PIPELINE_CREATE_COLOR_ATTACHMENT_FEEDBACK_LOOP_BIT_EXT sometimes") Reviewed-by: Emma Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169> (cherry picked from commit 0cb326cc74464f4e7f57de5c4d740e080f5e5b70) - - - - - 0064841f by Mike Blumenkrantz at 2023-02-08T20:34:47+00:00 zink: set zs feedback loop bit from driver workaround on ctx create this may otherwise not be set until the cache has been broken Fixes: 56fb2580642 ("zink: replace mixed_zs with zs feedback loops") Reviewed-by: Emma Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169> (cherry picked from commit bbae237258a40c370caffb58602745f1d36f66ba) - - - - - 9b3aaba2 by Mike Blumenkrantz at 2023-02-08T20:34:47+00:00 zink: fix gpl lib hashing this was including the generated tcs bits, which was likely to be wrong and thus break optimal key hashing, requiring more pipelines it also wasn't setting the optimal key value correctly during precompile, which meant the wrong hash value was used and the precompiled libs were never actually accessible cc: mesa-stable Reviewed-by: Emma Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169> (cherry picked from commit 4cf54e2ed22023c986f70711bddd0e934aa5683c) - - - - - 0efffb8f by Mike Blumenkrantz at 2023-02-08T20:34:47+00:00 zink: make last_vertex_stage the first bit in zink_vs_key_base Reviewed-by: Emma Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169> (cherry picked from commit 77d8cd9c07adb5da818ed14c7a60341e6289a308) - - - - - deccd028 by Mike Blumenkrantz at 2023-02-08T20:34:47+00:00 zink: use screen indexing for bindless descriptor set in template bind Fixes: 8636717270f ("zink: add a "compact" descriptor mode") Reviewed-by: Emma Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21169> (cherry picked from commit faaf6f95cc478da6ea4f8416bdae7080d9fca77a) - - - - - c6a38038 by Mike Blumenkrantz at 2023-02-08T20:34:47+00:00 util/vbuf: fix multidraw unrolling * drawid needs to be incremented at end of loop * rescope draw structs to initialize at top of loop fix #8191 Fixes: 6b07893b31f ("util/vbuf: handle multidraws") Reviewed-by: Kenneth Graunke <[email protected]> Tested-by: Mark Janes <[email protected]> Reviewed-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21139> (cherry picked from commit 8f5a63ebfe84f0bdaa7959fae79e9d42a17113ac) - - - - - 72a09034 by Georg Lehmann at 2023-02-08T20:34:47+00:00 aco: fix imod/omod for gfx11 VOP3 opcodes Fixes: d8d99c3c4f2 ("aco: add GFX11 opcode numbers") Reviewed-by: Rhys Perry <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21170> (cherry picked from commit c8adf16278fc02207602e4fafa12b95e6ea8dda0) - - - - - 0950a0b3 by Iván Briano at 2023-02-08T20:34:47+00:00 anv: uncompressed views of compressed 3d images are now valid There was a VUID-VkImageViewCreateInfo-image-04739 in the Vulkan 1.3 spec that said: If image was created with the VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT flag and format is a non-compressed format, viewType must not be VK_IMAGE_VIEW_TYPE_3D That VUID has since been removed, and when a view of a 3D image is created, with put the depth into the array_len, so it won't be always 1. Reviewed-by: Mark Janes <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20803> (cherry picked from commit 58ababdee6cd6b1e08604033602e4a5f9d5ab7a3) - - - - - ad91f96a by Eric Engestrom at 2023-02-08T21:05:31+00:00 docs: add release notes for 22.3.5 - - - - - 6570a156 by Eric Engestrom at 2023-02-08T21:05:36+00:00 VERSION: bump for 22.3.5 - - - - - 2f45f1ae by Timo Aaltonen at 2023-02-09T16:03:14+02:00 Merge branch 'upstream-unstable' into debian-unstable - - - - - dc242cf5 by Timo Aaltonen at 2023-02-09T20:39:48+02:00 version bump - - - - - b54a6a01 by Timo Aaltonen at 2023-02-09T20:43:39+02:00 release to sid - - - - - 0 changed files: The diff was not included because it is too large. View it on GitLab: https://salsa.debian.org/xorg-team/lib/mesa/-/compare/5d14beb3f9b870623443c4bf8a7e2254f7e11c27...b54a6a016ab9698fa8361d2437e14419e17eb7fa -- View it on GitLab: https://salsa.debian.org/xorg-team/lib/mesa/-/compare/5d14beb3f9b870623443c4bf8a7e2254f7e11c27...b54a6a016ab9698fa8361d2437e14419e17eb7fa You're receiving this email because of your account on salsa.debian.org.
