Timo Aaltonen pushed to branch debian-unstable at X Strike Force / lib / mesa
Commits: 1a2e6abe by Eric Engestrom at 2023-12-13T19:15:13+00:00 docs: add sha256sum for 23.3.1 - - - - - c962ecd0 by Eric Engestrom at 2023-12-13T19:17:09+00:00 .pick_status.json: Update to d761871761e5fe7d498b0cc818ed627698ed1225 - - - - - 7d805b42 by Lionel Landwerlin at 2023-12-13T19:17:09+00:00 nir/clone: fix missing printf_info clone Signed-off-by: Lionel Landwerlin <[email protected]> Cc: mesa-stable Reviewed-by: Karol Herbst <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26505> (cherry picked from commit 81b3dea9937baefd19d1791e1a592eec443f9085) - - - - - b6b70fee by Lionel Landwerlin at 2023-12-13T19:17:09+00:00 nir/divergence: handle printf intrinsic Signed-off-by: Lionel Landwerlin <[email protected]> Cc: mesa-stable Reviewed-by: Karol Herbst <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26505> (cherry picked from commit 4e4a3820abc9f4de717393ecc51700c7b798fd79) - - - - - 32bfb546 by Lionel Landwerlin at 2023-12-13T19:17:09+00:00 anv: fix incorrect queue_family access on command buffer The queue_family field is not an array, but a pointer. Signed-off-by: Lionel Landwerlin <[email protected]> Fixes: 9866c4e32b ("anv: Skip layout transition on the compute queue") Reviewed-by: Rohan Garg <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26645> (cherry picked from commit aa8c88f96cd3cc0078edfdff1e1cd7f40869a883) - - - - - 2ae88a43 by David Heidelberg at 2023-12-17T23:48:00+00:00 ci/freedreno: timestamp-get no longer fails on Adreno Fixes: 659e557676d2 ("freedreno: Fix timestamp conversion") Cc: mesa-stable #23.3 Signed-off-by: David Heidelberg <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26611> (cherry picked from commit 5527c090f41ab665efe1a89936f7306d201a1faa) - - - - - 0fc0b4bc by David Heidelberg at 2023-12-17T23:48:00+00:00 ci/freedreno: fail introduced by ARB_post_depth_coverage Fixes: fd00e994449d ("freedreno/a6xx: ARB_post_depth_coverage") Signed-off-by: David Heidelberg <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26611> (cherry picked from commit c2558a2df8c3a018820022583d9221f371801cbc) - - - - - 065c7d1f by Friedrich Vock at 2023-12-17T23:48:00+00:00 radv,vtn,driconf: Add and use radv_rt_ssbo_non_uniform workaround for Crysis 2/3 Remastered Crysis 2 and 3 Remastered's RT shaders non-uniformly index into SSBO descriptor arrays without specifying the NonUniformEXT qualifier on the relevant access chains/load ops. This leads to artifacts around objects. To add insult to injury, the game fails to provide a meaningful applicationName/engineName in the Vulkan part of the DX11-Vulkan interop solution used for RT. Both of these fields are set to "nvpro-sample" (perhaps the code has been copied from NVIDIA's sample applications). Therefore, fall back to executable name matching. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9883 Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26391> (cherry picked from commit f1817ab7e03f188164c7d6850149781066418d49) - - - - - 1ce44041 by Karol Herbst at 2023-12-17T23:48:00+00:00 rusticl/kernel: explicitly set rounding modes Since dbbf566588c ("aco,ac/llvm,radeonsi: lower f2f16 to f2f16_rtz in nir") radeonsi behavior changed and some of the core fp16 ops broke as a result. We should explicitly specify the rounding mode until we add an gallium API for drivers to advertize what they prefer. Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26655> (cherry picked from commit d136583c82d5036696b322bbe966490b321c96e1) - - - - - a9bbaf9d by Timothy Arceri at 2023-12-17T23:48:00+00:00 radeonsi: fix divide by zero in si_get_small_prim_cull_info() This fixes a crash on startup with the game "Ty the Tasmanian Tiger 3" Fixes: f8a0aa685275 ("radeonsi: fix view culling for wide lines") Reviewed-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26661> (cherry picked from commit bed1b8b90d844d8bf36d3d1aa7c3f83e086d9cf6) - - - - - 81cb966a by Christian Gmeiner at 2023-12-17T23:48:00+00:00 etnaviv: Update headers from rnndb Update to rnndb commit 071f5a60dcb8. This updates VIVS_PA_SHADER_ATTRIBUTES__LEN define from 10 to 16 and fixes memory corruption if more then 10 varyings are used. The current upper limit for varyings is 16. Cc: mesa-stable Signed-off-by: Christian Gmeiner <[email protected]> Reviewed-by: Lucas Stach <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26662> (cherry picked from commit 11ffb20b7072b4096dc4e033395f36ff6fbfd42e) - - - - - 9cabb39d by Christian Gmeiner at 2023-12-17T23:48:00+00:00 etnaviv: Add static_assert(..) to catch memory corruption When we start to support GPUs with more then 16 varyings the code base tells us that there is some work to do. Cc: mesa-stable Signed-off-by: Christian Gmeiner <[email protected]> Reviewed-by: Lucas Stach <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26662> (cherry picked from commit 2f205caea484e3882a209d4262f2f1ce1e0734a8) - - - - - b02dc14f by Boris Brezillon at 2023-12-17T23:48:00+00:00 util/hash_table: Use FREE() to be consistent with the CALLOC_STRUCT() call CALLOC_STRUCT() calls the OS abstraction layer to do the allocation. Call FREE() to free the corresponding objects so we keep things consistent and have proper debug traces when memory-debugging is enabled. Fixes: 6649b840c340 ("mesa/util: add a hash table wrapper which support 64-bit keys") Signed-off-by: Boris Brezillon <[email protected]> Reviewed-by: Yonggang Luo <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26423> (cherry picked from commit 977cc3157dc0215c065bc3039f7fd5c8b359dc17) - - - - - e2427f91 by Boris Brezillon at 2023-12-17T23:48:00+00:00 util/hash_table: Don't leak hash_u64_key objects when the entry exists When an entry exists, _mesa_hash_table_insert() updates the entry with the new data/key pair, which causes a leak if the key has previously been dynamically allocated, like is the case for hash_u64_key keys. One solution to solve that is to do the insertion in two steps: first _mesa_hash_table_search_pre_hashed(), and if the entry doesn't exist _mesa_hash_table_insert_pre_hashed(). But approach forces us to do the double-hashing twice. Another approach is to extract the logic in hash_table_insert() that's responsible for the searching and entry allocation into a separate helper called hash_table_get_entry(), and keep the entry::{key,data} assignment in hash_table_insert(). This way we can re-use hash_table_get_entry() from _mesa_hash_table_u64_insert(), and lake sure we free the allocated key if the entry was already present. Fixes: 6649b840c340 ("mesa/util: add a hash table wrapper which support 64-bit keys") Cc: stable Signed-off-by: Boris Brezillon <[email protected]> Reviewed-by: Yonggang Luo <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26423> (cherry picked from commit 5a60fd7b14e9a3045513a4b46ebd109c422c5b2e) - - - - - e839b0ae by Boris Brezillon at 2023-12-17T23:48:00+00:00 util/hash_table: Don't leak hash_key_u64 objects when the u64 hash table is destroyed Allocate a ralloc sub-context which takes the u64 hash table as a parent and attach a destructor to it so we can free the hash_key_u64 objects that were allocated by _mesa_hash_table_u64_insert(). The order of creation of this sub-context is crucial: it needs to happen after the _mesa_hash_table_create() call to guarantee that the destructor is called before ht->table and its children are freed, otherwise the _mesa_hash_table_u64_clear() call in the destructor leads to a use-after-free situation. Fixes: ff494361bee7 ("util: rzalloc and free hash_table_u64") Cc: stable Signed-off-by: Boris Brezillon <[email protected]> Reviewed-by: Yonggang Luo <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26423> (cherry picked from commit db5166718d89ba71f8d12fbdceffb05d7c5e9a03) - - - - - df326066 by Yonggang Luo at 2023-12-17T23:48:00+00:00 dzn: Fixes -Werror=incompatible-pointer-type Error message: ../../src/microsoft/vulkan/dzn_device.c:3840:108: error: passing argument 5 of 'device->dev13->lpVtbl->OpenExistingHeapFromAddress1' from incompatible pointer type [-Werror=incompatible-pointer-types] Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26508> (cherry picked from commit 767aa002304e4b53df51570d5deec2a063593ec8) - - - - - 9d3dc80f by Gert Wollny at 2023-12-17T23:48:00+00:00 r600/sfn: keep workgroup and invocation ID registers for whole shader For some reason one must not overwrite these values "too early", so pin them for the whole shader. Fixes: 79ca45 (r600/sfn: rewrite NIR backend) Related: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10004 Signed-off-by: Gert Wollny <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25846> (cherry picked from commit eb25c7a4e284cf5a8986978d4f35cb105c073712) - - - - - e0978d16 by Eric Engestrom at 2023-12-17T23:48:00+00:00 .pick_status.json: Update to 377c6b2d45ee73da3e5431846a3b4bfdd7ae2b83 - - - - - c81c063e by Eric Engestrom at 2023-12-17T23:48:01+00:00 ci/b2c: drop passthrough of unset CI_JOB_JWT Fixes: dabc068e6c04dca7800c ("ci: Use ci-fairy minio login via token file") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26653> (cherry picked from commit 6cc6ebde3a16f76c5fe42aac7136c3384bafe338) - - - - - d4975a80 by Robert Foss at 2023-12-17T23:48:01+00:00 egl/surfaceless: Fix EGL_DEVICE_EXT implementation The native_display checks are incorrect and partially never executed due to native_display always being NULL. Fixes: 1efaa858890 ("egl: Fix attrib_list[0] == EGL_NONE check") Signed-off-by: Robert Foss <[email protected]> Reviewed-by: Adam Jackson <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26131> (cherry picked from commit cda9980f9639093cf86897a760e90c89df7b6c0f) - - - - - 44440e5a by Eric Engestrom at 2023-12-17T23:48:01+00:00 .pick_status.json: Updates notes for 6a92af158dc132eee449c175bdee66d92c68d191 - - - - - 6664fc41 by Lionel Landwerlin at 2023-12-17T23:48:01+00:00 anv: wait for CS write completion before executing secondary Got a error state on DG2 with a jump to secondary. The secondary is empty and padded with MI_NOOPs to workaround the CS prefetching. According to the error state, the return jump address from the secondary to the primary is 0x0. The ACTHD register value is 0x10, so it seems that the command streamer indeed jumped to 0x0 and hanged on a few dwords after that. The return address should have been set edited by a previous MI_STORE_DATA_IMM instruction. So it appears it did not complete in time for the command stream to catch it. On Gfx12+ this can happend if we do not set ForceWriteCompletionCheck. This change also takes the opportunity to remove the padding MI_NOOPs at the end of secondaries on Gfx12+ by using disabling the prefetching just before jumping into secondaries and reenabling it at the beginning of each secondary. Signed-off-by: Lionel Landwerlin <[email protected]> Cc: mesa-stable Reviewed-by: Ivan Briano <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26665> (cherry picked from commit 6a92af158dc132eee449c175bdee66d92c68d191) - - - - - 874cd3b1 by Faith Ekstrand at 2023-12-17T23:48:01+00:00 nir: Scalarize bounds checked loads and stores Fixes: 39da1deb497a ("nir/lower_io: Add a bounds-checked 64-bit global address format") Reviewed-by: M Henning <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26526> (cherry picked from commit 1cf1b9d7412e94f70a5f68f81eed7ac22ad75613) - - - - - f3d9b7df by Tapani Pälli at 2023-12-17T23:48:01+00:00 anv/hasvk/drirc: change anv_assume_full_subgroups to have subgroup size Cc: mesa-stable Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26385> (cherry picked from commit 7ff8f79a8841d439af449fac8b382070a7b76c9f) - - - - - c2a1b110 by Tapani Pälli at 2023-12-17T23:48:01+00:00 drirc: setup anv_assume_full_subgroups=16 for UnrealEngine5.1 We set max subgroup size as 16 for 'UnrealEngine5.1', this improves a customer benchmark by 50% on A750. Cc: mesa-stable Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26385> (cherry picked from commit 012b6fbe632e190138f864ae4c6c6abe4c0ee81a) - - - - - fd1d0b4e by Friedrich Vock at 2023-12-17T23:48:01+00:00 radv/rt: Initialize unused children in PLOC early-exit Bad things happen when these aren't initialized. Fixes GPU hangs when loading Avatar: Frontiers of Pandora savegames. Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26712> (cherry picked from commit f9a394b753b55ccfc869568413b6fc6795dc1636) - - - - - 8b389ea2 by Eric Engestrom at 2023-12-17T23:48:01+00:00 vulkan/wsi: fix build when platform headers are installed in non-standard locations Anything that uses the platform defines in `vulkan_wsi_list` will need to be able to resole the includes they trigger, which are provided by `vulkan_wsi_deps`. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10304 Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26715> (cherry picked from commit 8043e8c4a66673675b2e1018f214e471942c717d) - - - - - 79b26057 by George Ouzounoudis at 2023-12-17T23:48:01+00:00 vulkan: Fix dynamic graphics state enum usage Simply replace the correct rasterization stream enum Fixes: 9d0ed9cbcc01 ("vulkan: Add more dynamic rasterizer state") Reviewed-by: Faith Ekstrand <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24872> (cherry picked from commit d8945dd51e47a026b5219b9f9d89fedb4ace04ca) - - - - - 25f02192 by Yiwei Zhang at 2023-12-17T23:48:01+00:00 vulkan/wsi/wayland: ensure drm modifiers stored in chain are immutable Chain stored modifiers point to the mapping of the current feedback shmem of the surface. The surface tracked feedback mapping will be gone and replaced with new mapping during surface_dmabuf_feedback_done. There are two issues here: 1. One issue is that the existing mapping is closed before been used to compare against new modifiers in sets_of_modifiers_are_the_same. 2. The other issue is that when the chain is still optimal, the chain persists while the mapping is still replaced with the one from the new format table shmem. This change makes a deep copy of the modifiers to store in the chain to ensure the modifiers used for the current chain are immutable through the chain lifecycle. Cc: mesa-stable Signed-off-by: Yiwei Zhang <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Reviewed-by: Leandro Ribeiro <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26618> (cherry picked from commit ddf2ca4faffdd309638aa0ebfcba2c43b4fc439d) - - - - - cb65e078 by Eric Engestrom at 2023-12-20T00:01:45+00:00 .pick_status.json: Update to 670a799ebff9a98daafccf49324c2a01311b0c41 - - - - - 5ea94d17 by Dave Airlie at 2023-12-20T00:04:51+00:00 intel/compiler: move gen5 final pass to actually be final pass This got broken by the register conversion, this pass needs to be after all the others. Fixes: ce75c3c3fea9 ("intel: Switch to intrinsic-based registers") Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26731> (cherry picked from commit f76f4be301ef311e6be21486b6a3f5fd5e90240f) - - - - - ead6751f by Tapani Pälli at 2023-12-20T00:04:52+00:00 iris: use intel_needs_workaround with 14015055625 This was missing from the FS stage primitive-id check. Also add usage of macro to avoid running any extra code on platforms where this WA would not apply. Fixes: 0f147240398 ("iris: Implement Wa_14015297576") Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: José Roberto de Souza <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26709> (cherry picked from commit 82553774e2d1c3edff4c8e8683808d159846f83d) - - - - - 2d842a3f by Michel Dänzer at 2023-12-20T00:04:53+00:00 gallium/dri: Return __DRI_ATTRIB_SWAP_UNDEFINED for _SWAP_METHOD In contrast to __DRI_ATTRIB_SWAP_EXCHANGE, this is compatible with Mesa < 23.3 on the client side. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10080 Fixes: e64ab3e4a94c ("glx: Delete support for GLX_OML_swap_method.") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26685> (cherry picked from commit 9548f969bda1075b20dd56a73cbf1e35c0cf7aba) - - - - - 0bbbc9e7 by Michel Dänzer at 2023-12-20T00:04:54+00:00 glx: Handle IGNORE_GLX_SWAP_METHOD_OML regardless of GLX_USE_APPLEGL Avoids tons of WARNING: unknown fbconfig attribute from server: tag 0x8060 value 0x8063 messages with LIBGL_DEBUG=verbose. Fixes: e64ab3e4a94c ("glx: Delete support for GLX_OML_swap_method.") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26685> (cherry picked from commit f0594915e631877bcdf8ce67636143a017b41fb1) - - - - - 684d1142 by Jesse Natalie at 2023-12-20T00:05:01+00:00 d3d12: Only destroy the winsys during screen destruction, not reset Fixes: 81c8e89f ("d3d12: Fix screen->winsys leak in d3d12_screen") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26744> (cherry picked from commit 325fb6e26b62326c86514d263ffedd241fd36865) - - - - - ab4a2e97 by José Expósito at 2023-12-20T00:05:03+00:00 egl/glx: fallback to software when Zink is forced and fails When `MESA_LOADER_DRIVER_OVERRIDE` is set to `zink` and the display initialization fails, fallback to software rendering. The error was reported in #10123 and it can be reproduced with: $ MESA_LOADER_DRIVER_OVERRIDE=zink eglinfo `eglinfo` would crash in `dri2_display_release()` because of `assert(dri2_dpy->ref_count > 0)`. After bisecting the error to commit 8cd44b884387 ("egl/glx: add autoloading for zink"), I found out that, before this change, the display was set to initialized even when `_eglDriver.Initialize(disp)` failed: disp->Options.Zink = env && !strcmp(env, "zink"); // disp->Options.Zink is true if (!_eglDriver.Initialize(disp)) { [...] // Zink initialization has failed at this point // However, success is set to true: bool success = disp->Options.Zink; if (!disp->Options.Zink && !getenv("GALLIUM_DRIVER")) { [...] } // Software initialization is ignored because success is true if (!success) { [...] } } // The display is set as initialized even though it shouldn't disp->Initialized = EGL_TRUE; Resolves: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10123 Fixes: 8cd44b884387 ("egl/glx: add autoloading for zink") Signed-off-by: José Expósito <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26184> (cherry picked from commit d913927fe9201f0fea71ef0e614b9c400c122d49) - - - - - e17dfc07 by Sviatoslav Peleshko at 2023-12-20T00:05:05+00:00 nir/loop_analyze: Don't test non-positive iterations count Testing negative iterations count makes no sense, and can cause issues when the unsigned type is used. Testing 0 iterations is already covered with will_break_on_first_iteration, so it can be skipped too. Fixes: 6772a17a ("nir: Add a loop analysis pass") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9913 Signed-off-by: Sviatoslav Peleshko <[email protected]> Reviewed-by: Ian Romanick <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26173> (cherry picked from commit a6459e0f7bcb662130c79764ccf54ccfa9151182) - - - - - af708d5e by Sviatoslav Peleshko at 2023-12-20T00:05:06+00:00 intel/fs: Don't optimize DW*1 MUL if it stores value to the accumulator Fixes: a8b86459 ("i965/fs: Optimize a * 1.0 -> a.") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9570 Signed-off-by: Sviatoslav Peleshko <[email protected]> Reviewed-by: Ian Romanick <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25710> (cherry picked from commit 8f8cde4c6050d1e91101ec66e8982036da9d7700) - - - - - 771c65fe by Sil Vilerino at 2023-12-20T20:18:46+00:00 d3d12: Fix AV1 video encode 32 bits build Reviewed-by: Jesse Natalie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26573> (cherry picked from commit 096e17b57832e96e36fc27f70e7a0e5ccbb0ac8a) - - - - - 8d2fa241 by Eric Engestrom at 2023-12-20T20:19:35+00:00 .pick_status.json: Update to e61fae6eb8ae1ae1228d6f89329324310db808ae - - - - - a23408d5 by Karol Herbst at 2023-12-20T20:19:35+00:00 rusticl: do not warn on empty RUSTICL_DEBUG or RUSTICL_FEATURES Fixes: b90d1cfbfea ("rusticl/platform: add RUSTICL_FEATURES boilerplate") Fixes: ca1e9917a9b ("rusticl/program: allow dumping compilation logs through RUSTICL_DEBUG") Signed-off-by: Karol Herbst <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26764> (cherry picked from commit 382718e0e1493ae9d654a667f4c5a75ac86422b6) - - - - - 953da130 by Bas Nieuwenhuizen at 2023-12-20T21:26:40+00:00 radv: Use correct writemask for cooperative matrix ordering. Not expecting this to actually fix anything externally visible, but reduces some invalid usage when the resulting vector is not 16 elements long (e.g. the C/result matrix). Fixes: 9df4703fbb5 ("radv: Add cooperative matrix lowering.") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26768> (cherry picked from commit 07ad6fd34a6ed32b74a3f9697545261a3fd84de2) - - - - - 78b48817 by Pierre-Eric Pelloux-Prayer at 2023-12-20T21:26:40+00:00 radeonsi/sqtt: fix RGP pm4 state emit function It was missing in c3129b2b839. Fixes: c3129b2b839 ("radeonsi: add a simple version of si_pm4_emit_state for non-shader states") Reviewed-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26774> (cherry picked from commit 77098ec467fae56d3e3885d8e84137ac410e15cc) - - - - - 4425ef56 by Pierre-Eric Pelloux-Prayer at 2023-12-20T21:26:40+00:00 radeonsi/sqtt: clear record_counts variable This avoids hitting the asserts in ac_sqtt_finish. Fixes: 94ce6540d8c ("ac/sqtt: add helpers for initializing ac_thread_trace_data") Reviewed-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26774> (cherry picked from commit e4d537fb84369906d7eda9229f847f5d4cdfb124) - - - - - fab56a0d by Pierre-Eric Pelloux-Prayer at 2023-12-20T21:26:40+00:00 radeonsi/sqtt: rework pm4.reg_va_low_idx The initial logic was to remember the place were SPI_SHADER_PGM_LO_* are written, then assume that we can get the register offset because the sequence would always be: PKT3_SET_SH_REG SPI_SHADER_PGM_LO_* register offset VA low 32 bits value <- reg_va_low_idx The problem is that this sequence isn't guaranteed, for instance we can get this instead: 0 c0067600 | 1 00000046 | 2 003ffffd | SPI_SHADER_PGM_RSRC3_VS 3 00000020 | SPI_SHADER_LATE_ALLOC_VS 4 * 00002080 | SPI_SHADER_PGM_LO_VS 5 00000080 | SPI_SHADER_PGM_HI_VS So the assert in si_state_draw.cpp would fail as well as the VA update logic. So instead remember which the SPI_SHADER_PGM_LO_* offset, and the low 32 bits of the VA in si_update_shaders. Fixes: 8034a71430b ("radeonsi/sqtt: re-export shaders in a single bo") Reviewed-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26774> (cherry picked from commit b55a2065e03e0f033217b1b58a0c18e3a5e86136) - - - - - d93e7ef9 by Pierre-Eric Pelloux-Prayer at 2023-12-20T21:26:40+00:00 radeonsi/sqtt: use calloc instead of malloc This makes sure the record is fully initialized and fixes RGP crashes or missing shaders. Cc: mesa-stable Reviewed-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26774> (cherry picked from commit af8e6c93473da991abbf588ce24ef409b08e84ce) - - - - - 3c7025cc by Eric Engestrom at 2023-12-22T15:47:28+00:00 .pick_status.json: Update to 1e6fcd6a611574241b1cde306afcc416a03ac76b - - - - - 0c6d7bcd by Karol Herbst at 2023-12-22T15:47:35+00:00 rusticl: silence clippy::arc-with-non-send-sync for now Allows compilation with newer clippy Cc: mesa-stable Signed-off-by: Karol Herbst <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26764> (cherry picked from commit 7e74ee07e3a7aebc46cbd6d724b49790cb9f9c29) - - - - - 676fd7a2 by Karol Herbst at 2023-12-22T15:48:26+00:00 rusticl: check rustc version for flags requiring newer rustc/clippy Fixes: 7e74ee07e3a ("rusticl: silence clippy::arc-with-non-send-sync for now") Signed-off-by: Karol Herbst <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26780> (cherry picked from commit 9643671dae06701fa5ad926b6f30909407d1f8ac) - - - - - fa0f07c5 by Jonathan Gray at 2023-12-22T15:48:47+00:00 intel/common: add directory prefix to intel_gem.h include Otherwise common/intel_gem.h may get included instead of common/i915/intel_gem.h when building in a different directory. Fixes: e050a00b9f4 ("intel/common: Move i915 files to i915 folder") Reviewed-by: José Roberto de Souza <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26784> (cherry picked from commit fbb9ce014080edd085b2e998c3e6d7fb569ef0b0) - - - - - 7cfc8d3a by Tapani Pälli at 2023-12-24T07:34:01+00:00 mesa: fix enum support for EXT_clip_cull_distance Extension was enabled but required enums not. Fixes: 979bcb9f428 ("glsl: add EXT_clip_cull_distance support based on ARB_cull_distance") Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26688> (cherry picked from commit 629b15f446a41492fc5057c04008c6de9c52b078) - - - - - 04ed77a1 by Vinson Lee at 2023-12-24T07:34:01+00:00 etnaviv: Remove duplicate initializers Fix initializer-overrides warnings. ../src/gallium/drivers/etnaviv/etnaviv_compiler.c:62:29: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides] 62 | .lower_extract_byte = true, | ^~~~ ../src/gallium/drivers/etnaviv/etnaviv_compiler.c:63:29: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides] 63 | .lower_extract_word = true, | ^~~~ Fixes: 9dc4ee91215 ("etnaviv: lower (un)pack_{2x16,2x32}_split and extract_{byte,word}") Signed-off-by: Vinson Lee <[email protected]> Reviewed-by: Lucas Stach <[email protected]> Reviewed-by: Christian Gmeiner <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26773> (cherry picked from commit f5d08bdf4e3a0e75a846b76889e234b7c9bbd754) - - - - - 99fdd1bc by Tapani Pälli at 2023-12-24T07:34:01+00:00 drirc/anv: disable FCV optimization for Baldur's Gate 3 Cc: mesa-stable Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26754> (cherry picked from commit 9e88c711a3da96cb633bdc35e009bcb1bd193d74) - - - - - 02890271 by Eric Engestrom at 2023-12-27T13:39:24+00:00 .pick_status.json: Update to 55c262898ae7188311c89a60e4ec0fbb67b7a95b - - - - - 72dac993 by Kenneth Graunke at 2023-12-27T13:39:28+00:00 iris: Initialize bo->index to -1 when importing buffers A value of -1 means that the buffer has never been used in an execbuf buffer list in any of our contexts. While setting this isn't critical, doing so will allow us to short-circuit some looping in the next patch. Cc: mesa-stable Reviewed-by: José Roberto de Souza <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26806> (cherry picked from commit d178334d5cafa9b215d38c7c443c4dbc168e66c5) - - - - - 43e9a93f by Kenneth Graunke at 2023-12-27T13:39:29+00:00 iris: Don't search the exec list if BOs have never been added to one Whenever we use a BO in a batch, we need to find its corresponding exec list entry, either to a) record that it's been used, b) update whether it's being written, c) check for cross-batch implicit dependencies. bo->index exists to accelerate these lookups. If a BO is used multiple times by a batch, bo->index is its location in the list. Because the field is global, and a BO can in theory be used concurrently by multiple contexts, we need to double-check whether it's still there. If not, we fall back to a linear search of all BOs in the list, looking to see if our index was simply wrong (but presumably right for another context). However, there's one glaringly obvious case that we missed here. If bo->index is -1, then it's wrong for /all/ contexts, and in fact implies that said BO has never been added to any exec list, ever. This is quite common in fact: a new BO, never been used before, say from the BO cache, or streaming uploaders, gets used for the first time. In this case we can simply conclude that it's not in the list and skip the linear walk through all buffers referenced by the batch. Improves performance on an i7-12700 and A770: - SPECviewperf2020 catiav5test1: 72.9214% +/- 0.312735% (n=45) Cc: mesa-stable Reviewed-by: José Roberto de Souza <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26806> (cherry picked from commit d55b5d4af5d55a25837d8507840f4ab9b1075ea3) - - - - - 64741669 by Kenneth Graunke at 2023-12-27T13:39:30+00:00 iris: Skip mi_builder init for indirect draws We only need it for indirect draws. Improves performance on an i7-12700 and A770: - Piglit's drawoverhead base case +150.639% +/- 2.86933% (n=15). - gfxbench5 gl_driver2_off +19.7219% +/- 1.13778% (n=15) - SPECviewperf2020 catiav5test1 +1.6831% +/- 0.552052% (n=10). Cc: mesa-stable Reviewed-by: José Roberto de Souza <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26806> (cherry picked from commit 55c262898ae7188311c89a60e4ec0fbb67b7a95b) - - - - - ad50fc2d by Eric Engestrom at 2023-12-27T22:26:11+00:00 docs: add release notes for 23.3.2 - - - - - 527d4523 by Eric Engestrom at 2023-12-27T22:27:12+00:00 VERSION: bump for 23.3.2 - - - - - 106be3af by Timo Aaltonen at 2024-01-02T14:03:06+02:00 Merge branch 'upstream-unstable' into debian-unstable - - - - - 39fb99da by Timo Aaltonen at 2024-01-03T10:08:39+02:00 version bump - - - - - b6005ec4 by Tao Chen at 2024-01-03T15:07:16+02:00 Add Loongarch support - - - - - cb336c5c by Timo Aaltonen at 2024-01-03T15:08:21+02:00 patches: Refreshed, and dropped an upstreamed patch. - - - - - 26e0e057 by Timo Aaltonen at 2024-01-03T15:19:51+02:00 release to sid - - - - - 1 changed file: - .gitlab-ci/test/gitlab-ci.yml The diff was not included because it is too large. View it on GitLab: https://salsa.debian.org/xorg-team/lib/mesa/-/compare/ffbdb7d564222696057b6bd9c39f3b84593ae8f4...26e0e0570a396fd9edddc916d4370b761eb97d01 -- View it on GitLab: https://salsa.debian.org/xorg-team/lib/mesa/-/compare/ffbdb7d564222696057b6bd9c39f3b84593ae8f4...26e0e0570a396fd9edddc916d4370b761eb97d01 You're receiving this email because of your account on salsa.debian.org.
