Timo Aaltonen pushed to branch upstream-experimental at X Strike Force / lib / mesa
Commits: db1835d8 by Eric Engestrom at 2024-05-05T15:46:46+02:00 .pick_status.json: Update to 603982ea802b3846e91a943b413a7baf430e875d - - - - - 726c28f9 by Iván Briano at 2024-05-05T15:46:58+02:00 anv: fix casting to graphics_pipeline_base The macro takes the type of the pipeline to check for, but the cast to base checks for a full graphics pipeline, so if used on a library one it fails. Cc: mesa-stable Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29011> (cherry picked from commit 6223388c738e37a6d509ba54e2d179ee5773a4d6) - - - - - 7252bb2d by Yusuf Khan at 2024-05-05T15:46:58+02:00 nouveau: Fix crash when destination or source screen fences are null Fixes: dEQP-EGL.functional.sharing.gles2.multithread.random_egl_sync.*, one of them, its quite finiky, one may say random Signed-off-by: Yusuf Khan <[email protected]> Reviewed-by: Karol Herbst <[email protected]> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28618> (cherry picked from commit 482d9fcbf304e41a0a4ab461894277e5cfd2c9b2) - - - - - 60bb6425 by Rohan Garg at 2024-05-05T15:46:59+02:00 anv: allocate space for generated indirect draw id's using the temporary allocation helper Generated Indirect Draw's need a small temporary allocate to store draw id's. Use the new temporary allocation helper to allocate that space. Fixes: 82d772fa9b ("anv: create new helper for small allocations") Signed-off-by: Rohan Garg <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28989> (cherry picked from commit e50234de8624a8c42d050806de9f404ce189f452) - - - - - 00b2aaf2 by Sviatoslav Peleshko at 2024-05-05T15:47:00+02:00 anv: Fix descriptor sampler offsets assignment This seems to be a simple copy-paste mistake. It makes sense to or-assign surface offsets because we clear the actual offset part with a mask first, but sampler offsets should be just assigned instead. Fixes: 7c76125d ("anv: use 2 different buffers for surfaces/samplers in descriptor sets") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10790 Signed-off-by: Sviatoslav Peleshko <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29019> (cherry picked from commit 39c4de7e42a85a6871c552c2d55ddb7d3a1988ee) - - - - - 80af43b9 by Gert Wollny at 2024-05-05T15:47:00+02:00 zink/kopper: Wait for last QueuePresentKHR to finish before acquiring for readback When a job is submitted to the flush_queue the resource dt_idx is reset, and if a readback is requested then we have to make sure that the corresponding kopper_preset has finished before we can acquire the image for readback, so wait for the according fence in this case. This fixes the validation error UNASSIGNED-Threading-MultipleThreads-Write triggered by piglit "read-front" lavapipe. Fixes: 8ade5588e39d736bdeab9bdd8ffa7cbfb6a5191e zink: add kopper api Signed-off-by: Gert Wollny <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28127> (cherry picked from commit 811ed6286590bed340a73d3115a283a027d9091b) - - - - - 80d8da9d by Gert Wollny at 2024-05-05T15:47:01+02:00 mesa/st: don't use base shader serialization when uniforms are not packed When loading the base shader serialization there is a discrepancy between the state parameters that may already have been optimized, because after storing the serialization the shader went through st_finalize_nir, and _mesa_optimize_state_parameters was run, so that original state parameters may have been optimized and replaced by new parameters. After get_nir_shader is called, the original state parameters are re-added - in addition to the optimized parameters. This lead to an bug with the uniform offsets when lowering uniforms to UBOs. Therefore, as a hotfix for drivers that don't support packed uniforms, ignore the base serialization and use the serialization obtained after st_finalize_nir was run. With that the problem can be avoided. Fixes: 5eb0136a3c561e25d3f274e33a86812cfb2af589 mesa/st: when creating draw shader variants, use the base nir and skip driver opts Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10881 v2: reorder conditional evaluation for better readability (zmike) v3: revert c72bb8de7 ("r300: mark new fails") (Pavel Ondračka) Signed-off-by: Gert Wollny <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28994> (cherry picked from commit 7de8a010876b6e1fdf7fc8cf15f3f0e10ba5c569) - - - - - 55ad51ff by Ian Romanick at 2024-05-05T15:47:02+02:00 intel/brw: Fix optimize_extract_to_float for i2f of unsigned extract Fixes fs-uint-to-float-of-extract-int8.shader_test and fs-uint-to-float-of-extract-int16.shader_test added by piglit!883. No shader-db or fossil-db changes on any Intel platform. v2: Expand the comment explaining the potential problem. Suggested by Caio. Fixes: 29ce110be6d ("i965/fs: Remove extract virtual opcodes.") Reviewed-by: Caio Oliveira <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27891> (cherry picked from commit bf5d82654ab9d3a67dacab4571d814066e0593c4) - - - - - e0899ef8 by Ian Romanick at 2024-05-05T15:47:07+02:00 intel/elk: Fix optimize_extract_to_float for i2f of unsigned extract Fixes fs-uint-to-float-of-extract-int8.shader_test and fs-uint-to-float-of-extract-int16.shader_test added by piglit!883. v2: Expand the comment explaining the potential problem. Suggested by Caio. Fixes: e6022281f27 ("intel/elk: Rename files to use elk prefix") Reviewed-by: Caio Oliveira <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27891> (cherry picked from commit 0fa17962d6b26fe29996a5767fbdd44dc2dbd082) - - - - - b897d0ba by Georg Lehmann at 2024-05-05T15:47:07+02:00 radv, radeonsi: don't use D16 for f2f16_rtz D16 rounds towards zero for fp32 -> fp16, but for fixed point it rounds to nearest even in fp16. MIMG without D16 also rounds to nearest even, but in fp32. This means D16 and f2f16_rtz(tex@32) can produce different results. Sadly this also means we can never use d16 if fp16 rounding isn't undefined. Cc: mesa-stable Acked-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28730> (cherry picked from commit 3a35522c8a48bd19d37223c24d271e08ed5b1a34) - - - - - e0c70876 by Eric Engestrom at 2024-05-06T19:40:33+02:00 .pick_status.json: Update to 569c2fcf952a3ec13ddf77c0058e769bf68f3aaf - - - - - 9eb0a429 by Christian Gmeiner at 2024-05-06T19:40:39+02:00 clc: Always use spir for 32 bit Fixes unknown target triple 'unknown-unknown-unknown-spirv-unknown-unknown' problem with llvm 17 on a 32 bit system. Fixes: 22fa315ee06 ("clc: use spirv triple starting with llvm-17") Signed-off-by: Christian Gmeiner <[email protected]> Reviewed-by: Karol Herbst <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29049> (cherry picked from commit db7bfe85ae499257ec214a543f6d8ef9c7a3738a) - - - - - ec0e288f by Lionel Landwerlin at 2024-05-06T19:40:40+02:00 anv: fixup alloc failure handling in reserved_array_pool Signed-off-by: Lionel Landwerlin <[email protected]> Fixes: 806281f61f ("anv: add a new reserved pool for capture/release") Reviewed-by: Rohan Garg <[email protected]> Reviewed-by: José Roberto de Souza <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29057> (cherry picked from commit e260b16b1110174169f6234b8f59cb42fc42f69f) - - - - - 27cf4920 by Lionel Landwerlin at 2024-05-06T19:40:41+02:00 anv: fix leak of custom border colors Inside a HAVE_VALGRIND section. Signed-off-by: Lionel Landwerlin <[email protected]> Fixes: 4dad2a4a6f ("anv: enable shader border color capture/replay") Reviewed-by: Rohan Garg <[email protected]> Reviewed-by: José Roberto de Souza <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29057> (cherry picked from commit ae6d20815ad1029c50bf8a3bdde13d34414142aa) - - - - - 02e295cb by Karol Herbst at 2024-05-06T19:40:42+02:00 nouveau: fix potential double-free in nouveau_drm_screen_create Fixes: 821f4c8d99a ("nouveau: import libdrm_nouveau") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29000> (cherry picked from commit d163498dbe1a1777702ef6300df497793abc16ee) - - - - - c0d4d3e5 by Patrick Lerda at 2024-05-06T19:40:42+02:00 clover: fix pipe_box update regression Indeed, clover was processing the pipe_box elements with a hardcoded order. The update of the pipe_box object broke clover. Fixes: 651191801a8 ("gallium: increase the size of pipe_box y, height fields to allow bigger textures") Signed-off-by: Patrick Lerda <[email protected]> Reviewed-by: Karol Herbst <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29060> (cherry picked from commit f8489211480a4789533b6c117dbcd9f6cb6cf71e) - - - - - 0930b692 by Mike Blumenkrantz at 2024-05-06T19:40:43+02:00 zink: clean up accidental debug print Fixes: 19e8df39b62 ("zink: slightly better swapinterval failure handling") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29065> (cherry picked from commit 13bd41386086b9d44684aea4813697333500db40) - - - - - 927bbf50 by Karol Herbst at 2024-05-06T19:40:43+02:00 nir: fix nir_shader_get_function_for_name for functions without names. It's legal in SPIRV for functions to not have names, we have to take this into account when calling into strcmp here. Fixes: 2aa9eb497d0 ("nir: Add a helper for finding a function by name") Signed-off-by: Karol Herbst <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29063> (cherry picked from commit 569c2fcf952a3ec13ddf77c0058e769bf68f3aaf) - - - - - 1255b12f by Eric Engestrom at 2024-05-07T15:56:18+02:00 .pick_status.json: Update to 9666756f603f0285d8a93ef93db1c7ec702b671f - - - - - f45a1d10 by Mykhailo Skorokhodov at 2024-05-07T15:56:28+02:00 egl/wayland: Fix sRGB format look up for config That check should help with situations when the dri2_wl_visual_idx_from_pipe_format function can't recognize pipe_format as before. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10829 Fixes: 6a084e2b("egl/wayland: Use pipe_format to look up configs") Signed-off-by: Mykhailo Skorokhodov <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29052> (cherry picked from commit 066fc39f45181c30b9b3ee93c17f52763a8e4356) - - - - - e568bbf4 by Mykhailo Skorokhodov at 2024-05-07T18:20:24+02:00 ci/lima: expect fail of window_8888_colorspace_srgb on wayland Signed-off-by: Mykhailo Skorokhodov <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29052> (cherry picked from commit 1cc48123986e38cb5608b159e080408b737954be) - - - - - 2f97ea3a by Tapani Pälli at 2024-05-07T18:20:24+02:00 iris: change stream uploader default size to 2MB Patch bumps up the size to the 2MB alignment, this fixes rendering issues with Star Wars KOTOR when VBO's are not used (which is the default setting). Fixes: 0b6693a3a14 ("iris: Align fresh BO allocations to 2MB in size") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10863 Signed-off-by: Tapani Pälli <[email protected]> Reviewed-by: Kenneth Graunke <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28974> (cherry picked from commit cbe2630f19e86638229f65fb1ee1992f71889c2a) - - - - - ddf6f67b by Boris Brezillon at 2024-05-07T18:20:25+02:00 panfrost: Add the BO containing fragment program descriptor to the batch On pre-Valhall HW, the fragment shader metadata was part of the RSD (renderer state descriptor), which was emitted at draw time, but Valhall introduces a shader program descriptor containing only the shader information, and this one is emitted at shader preparation time. If we don't add the FS state BO to batch, we might end up with a batch being executed after the shader object has been destroyed, leading to page faults when the GPU tries to access the shader program descriptor. We make the panfrost_batch_add_bo() unconditional since it gracefully handles the NULL case (which will happen on v7-). Fixes: 087b63cb0771 ("panfrost: Allow uploading fragment SPDs") Signed-off-by: Boris Brezillon <[email protected]> Reviewed-by: Erik Faye-Lund <[email protected]> Reviewed-by: Antonino Maniscalco <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28926> (cherry picked from commit 2cc317763ccc2f33bbff0920bb0833d09300f60c) - - - - - 1f917b88 by Boris Brezillon at 2024-05-07T18:20:25+02:00 pan/kmod: Fix a syncobj leak in the panthor backend Make sure we release the syncobj attached to the BO if the object is sharable. Fixes: 97f6a62f7ef8 ("pan/kmod: Add a backend for panthor") Signed-off-by: Boris Brezillon <[email protected]> Reviewed-by: Erik Faye-Lund <[email protected]> Acked-by: Constantine Shablia <[email protected]> Reviewed-by: Antonino Maniscalco <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28926> (cherry picked from commit 068d111884a588f4972e27477b1cb2cf4f52d0e3) - - - - - 965f8b10 by Boris Brezillon at 2024-05-07T18:20:25+02:00 pan/kmod: Make default allocator thread-safe Allocations targeting a pan_kmod_dev can happen concurrently, so we need the pan_kmod_dev allocator to be thread-safe. ralloc() is not thread-safe, and we don't really need a hierarchical allocator in this context anyway, so let's just switch to calloc/free instead. Fixes: d95ec56f8c68 ("panfrost: Abstract kernel driver operations") Reported-by: Eric Smith <[email protected]> Signed-off-by: Boris Brezillon <[email protected]> Tested-by: Eric Smith <[email protected]> Reviewed-by: Eric Smith <[email protected]> Reviewed-by: Erik Faye-Lund <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28926> (cherry picked from commit 4c74d1473054ca3cc609bae6e31028063bd531bf) - - - - - 063edd4d by Constantine Shablia at 2024-05-07T18:20:25+02:00 panfrost: report correct MAX_VARYINGS Fixes packing-varying piglit failures Cc: mesa-stable Reviewed-by: Erik Faye-Lund <[email protected]> Reviewed-by: Boris Brezillon <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29017> (cherry picked from commit 81f42d82edef8b3617cc504bfc1bbfc381e52f3b) - - - - - f24ce4cd by Connor Abbott at 2024-05-07T18:20:25+02:00 docs/android: Fix example meson cross file again I copied it over wrong, it should be cpu_family that's changed to aarch64 to avoid "error: undefined symbol: blake3_hash_many_neon". Fixes: 57abef5af1f3 ("docs/android: Fix example meson cross file") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29081> (cherry picked from commit 4cefb5ece8208be8c8aacc9be75045f40cb2e820) - - - - - e8f360c3 by David Rosca at 2024-05-07T18:20:25+02:00 frontends/va: Fix AV1 slice_data_offset with multiple slice data buffers The slice parameter data offset refers to offset in the submitted data buffer. When multiple slice data buffers are submitted, the offsets of all slices needs to be adjusted to be based from the start of the first data buffer. Cc: mesa-stable Reviewed-by: Leo Liu <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28960> (cherry picked from commit 6746d4df6eac83d048e88c2d54aa19e7c1a0a696) - - - - - 8b6095c1 by David Rosca at 2024-05-07T18:20:25+02:00 Revert "radeonsi/vcn: AV1 skip the redundant bs resize" Currently ffmpeg has a bug in VAAPI AV1 decode that in some cases it submits the same slice data buffer as many times as there is tiles. However, in other cases it behaves correctly and all slice data buffers contain different parts of bitstream to decode which this change breaks. Now that the va frontend is passing correct offsets, this fixes decoding AV1-TEST-VECTORS/av1-1-b8-22-svc-L1T2 with ffmpeg. This reverts commit e6701f723147c45798584ba77da7095f2317684c. Cc: mesa-stable Reviewed-by: Leo Liu <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28960> (cherry picked from commit 88dfe04b08d5a1279dbde042b2e79ca2e7a530a6) - - - - - 50971e45 by Eric Engestrom at 2024-05-08T14:37:55+02:00 .pick_status.json: Update to b8e79d2769b4a4aed7e2103cf0405acc5bdadb86 - - - - - abce42ce by Karol Herbst at 2024-05-08T14:37:58+02:00 rusticl: use stream uploader for cb0 if prefered Using the same buffer without a barrier actually can lead to data races as drivers might not properly synchronize the content. Using the stream uploader is a neat fix which prevents us from having to use a barrier but still keep high throughput when launching kernels back-to-back. Fixes: 5ff33f99058 ("rusticl: use real buffer for cb0 for drivers prefering") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27666> (cherry picked from commit 8da8c6c2d8bf9b9b04ee030df68d7d44146fc877) - - - - - 71f25dc2 by Eric Engestrom at 2024-05-08T15:28:54+02:00 VERSION: bump for 24.1.0-rc3 - - - - - 30 changed files: - .pick_status.json - VERSION - docs/android.rst - src/amd/vulkan/radv_pipeline.c - src/compiler/clc/clc_helpers.cpp - src/compiler/nir/nir.h - src/egl/drivers/dri2/platform_wayland.c - src/gallium/drivers/iris/iris_context.c - src/gallium/drivers/lima/ci/lima-fails.txt - src/gallium/drivers/nouveau/nouveau_screen.c - src/gallium/drivers/panfrost/pan_cmdstream.c - src/gallium/drivers/panfrost/pan_screen.c - src/gallium/drivers/r300/ci/r300-rv530-nohiz-fails.txt - src/gallium/drivers/radeonsi/radeon_vcn_dec.c - src/gallium/drivers/radeonsi/si_shader_nir.c - src/gallium/drivers/zink/zink_kopper.c - src/gallium/frontends/clover/core/resource.cpp - src/gallium/frontends/rusticl/core/queue.rs - src/gallium/frontends/rusticl/mesa/pipe/context.rs - src/gallium/frontends/rusticl/rusticl_mesa_bindings.h - src/gallium/frontends/va/picture.c - src/gallium/frontends/va/picture_av1.c - src/gallium/frontends/va/va_private.h - src/gallium/winsys/nouveau/drm/nouveau.c - src/intel/compiler/brw_fs_nir.cpp - src/intel/compiler/elk/elk_fs_nir.cpp - src/intel/vulkan/anv_allocator.c - src/intel/vulkan/anv_cmd_buffer.c - src/intel/vulkan/anv_device.c - src/intel/vulkan/anv_pipeline.c The diff was not included because it is too large. View it on GitLab: https://salsa.debian.org/xorg-team/lib/mesa/-/compare/f3ff3d86efcbada04311e2a8a9e55aa5b2f6e308...71f25dc28cabee2b8b96c57bbccd7016ebebbe2f -- View it on GitLab: https://salsa.debian.org/xorg-team/lib/mesa/-/compare/f3ff3d86efcbada04311e2a8a9e55aa5b2f6e308...71f25dc28cabee2b8b96c57bbccd7016ebebbe2f You're receiving this email because of your account on salsa.debian.org.

