Your message dated Tue, 29 Nov 2022 20:41:16 +0500
with message-id
<caneom1ewsvhvhaclpn4sgycvhv0go51gif0srkaeeulbb2r...@mail.gmail.com>
and subject line Re: xfce4-panel: window menu sometimes keeps blinking
attention when all windows stopped demanding attention
has caused the Debian Bug report #699871,
regarding xfce4-panel: window menu sometimes keeps blinking attention when all
windows stopped demanding attention
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
699871: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=699871
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: xfce4-panel
Version: 4.10.0-1.1
Severity: minor
Not sure how this is triggered, but often when right after program start
which demands attention, window menu would keep blinking even when all
windows stopped demanding attention (even were closed).
Window menu should stop blink when no window demands attention.
Attached patch seems to fix it, with an additional hack to stop blinking
once menu is opened.
-- System Information:
Debian Release: 7.0
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'testing'), (400, 'unstable'),
(300, 'stable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages xfce4-panel depends on:
ii exo-utils 0.10.2-1
ii libatk1.0-0 2.4.0-2
ii libc6 2.13-37
ii libcairo2 1.12.2-2
ii libdbus-1-3 1.6.8-1
ii libdbus-glib-1-2 0.100-1
ii libexo-1-0 0.10.2-1
ii libfontconfig1 2.9.0-7.1
ii libfreetype6 2.4.9-1.1
ii libgarcon-1-0 0.2.0-1
ii libgdk-pixbuf2.0-0 2.26.1-1
ii libglib2.0-0 2.33.12+really2.32.4-3
ii libgtk2.0-0 2.24.10-2
ii libice6 2:1.0.8-2
ii libpango1.0-0 1.30.0-1
ii libsm6 2:1.2.1-2
ii libwnck22 2.30.7-1
ii libx11-6 2:1.5.0-1
ii libxext6 2:1.3.1-2
ii libxfce4ui-1-0 4.10.0-1
ii libxfce4util6 4.10.0-2
ii libxfconf-0-2 4.10.0-1
ii multiarch-support 2.13-37
xfce4-panel recommends no packages.
xfce4-panel suggests no packages.
-- no debconf information
Index: xfce4-panel-4.10.0/plugins/windowmenu/windowmenu.c
===================================================================
--- xfce4-panel-4.10.0.orig/plugins/windowmenu/windowmenu.c
+++ xfce4-panel-4.10.0/plugins/windowmenu/windowmenu.c
@@ -681,10 +681,13 @@ window_menu_plugin_window_state_changed
plugin->urgent_windows--;
/* check if we need to change the button */
- if (plugin->urgent_windows == 1)
+ if (PANEL_HAS_FLAG (new_state, URGENT_FLAGS) && plugin->urgent_windows == 1)
xfce_arrow_button_set_blinking (XFCE_ARROW_BUTTON (plugin->button), TRUE);
- else if (plugin->urgent_windows == 0)
+ else if (!PANEL_HAS_FLAG (new_state, URGENT_FLAGS) && plugin->urgent_windows == 0)
xfce_arrow_button_set_blinking (XFCE_ARROW_BUTTON (plugin->button), FALSE);
+
+ if (plugin->urgent_windows < 0)
+ plugin->urgent_windows = 0;
}
@@ -1360,6 +1363,10 @@ window_menu_plugin_menu (GtkWidget
&& !gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (button)))
return;
+ /* stop blinking */
+ plugin->urgent_windows = 0;
+ xfce_arrow_button_set_blinking (XFCE_ARROW_BUTTON (plugin->button), FALSE);
+
/* popup the menu */
menu = window_menu_plugin_menu_new (plugin);
g_signal_connect (G_OBJECT (menu), "deactivate",
--- End Message ---
--- Begin Message ---
Source: xfce4-panel
Source-Version: 4.15.5-1
--- End Message ---
