Your message dated Sat, 3 Dec 2022 19:54:17 +0500
with message-id
<CANeoM1GtTXewp=ihkyvbydakaok2fb5a9d3m6bms5e1j242...@mail.gmail.com>
and subject line Re: xfce4-xkb-plugin: Respect font-size option (text layout),
better flag size (image layout)
has caused the Debian Bug report #815938,
regarding xfce4-xkb-plugin: Respect font-size option (text layout), better flag
size (image layout)
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
815938: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815938
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: xfce4-xkb-plugin
Version: 1:0.7.1-2
Severity: wishlist
Tags: upstream patch
Dear Maintainer,
I have minor issues (though it may be of personal taste) with the graphics
layout of the xkb plugin:
1) In the text-mode layout, the current debian patch allows to select font, but
it ignores the font size (the text is always scalled to fill the reserved
space). This does not seems like the original intention for the size selection
in the configuration dialog.
2) In the image-mode layout, the size of the flag is unproportionally large
compared to other panel icon plugins.
Attached is a patch that would correct the described behaviour.
Thanks,
Pavel
-- System Information:
Debian Release: stretch/sid
APT prefers testing-proposed-updates
APT policy: (840, 'testing-proposed-updates'), (840, 'testing'), (740,
'unstable'), (738, 'experimental'), (540, 'proposed-updates'), (540, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.4.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=cs_CZ.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages xfce4-xkb-plugin depends on:
ii libc6 2.21-9
ii libcairo2 1.14.6-1
ii libgarcon-1-0 0.4.0-2
ii libgdk-pixbuf2.0-0 2.32.3-1.2
ii libglib2.0-0 2.46.2-3
ii libgtk2.0-0 2.24.29-1
ii libpango-1.0-0 1.38.1-1
ii libpangocairo-1.0-0 1.38.1-1
ii librsvg2-2 2.40.11-2
ii libwnck22 2.30.7-5
ii libxfce4ui-1-0 4.12.1-2
ii libxfce4util7 4.12.1-2
ii libxklavier16 5.2.1-1
ii xfce4-panel 4.12.0-3
xfce4-xkb-plugin recommends no packages.
xfce4-xkb-plugin suggests no packages.
-- no debconf information
--- old/debian/patches/01-font_selection.patch 2015-03-15 22:02:34.000000000 +0100
+++ new/debian/patches/01-font_selection.patch 2016-02-25 20:09:16.723801490 +0100
@@ -144,13 +144,13 @@
- DBG ("txt size scale x/y: %.2f/%.2f", scalex, scaley);
-
- text_height = actual_height * scaley;
-+ text_height = actual_height;
++ text_height = pango_height;
scaley = text_height / pango_height;
radius = (text_height < 32) ? 1.2 : 2.5;
diameter = 2 * radius;
- text_width = actual_width * scalex;
-+ text_width = actual_width;
++ text_width = pango_width;
if (actual_width - text_width < 3 + variant_markers_count * diameter)
{
text_width = actual_width - 3 - (variant_markers_count) * diameter;
--- old/panel-plugin/xfce4-xkb-plugin.c 2016-02-25 22:37:50.902329409 +0100
+++ new/panel-plugin/xfce4-xkb-plugin.c 2016-02-25 23:09:12.053774427 +0100
@@ -343,6 +343,7 @@
else
{
xkb->hsize = (int) (1.33 * panel_size);
+ if ( panel_size >= 24 ) xkb->hsize = panel_size;
}
gtk_widget_set_size_request (xkb->btn, xkb->hsize, xkb->vsize);
--- End Message ---
--- Begin Message ---
Source: xfce4-xkb-plugin
Source-Version: 1:0.8.1-1
The plug-in underwent many changes, including the migration to Xfconf.
The Debian patch was dropped as a result of this. "Text size" was also
changed to "Widget size".
See commit 0f72f634988fe39eb9e07ec1803e2310957a50cb for details.
Please try the latest version.
Cheers,
Akbar.
--- End Message ---
