[ 
https://issues.apache.org/jira/browse/DEFT-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065332#comment-13065332
 ] 

Roger Schildmeijer commented on DEFT-154:
-----------------------------------------

Looks fine in sandbox/trunk, thanks! (I probably was working on a more recent 
file. Nice that you sorted it out without requesting a rebase :) )

> Naive read in AsynchronousSocket
> --------------------------------
>
>                 Key: DEFT-154
>                 URL: https://issues.apache.org/jira/browse/DEFT-154
>             Project: Deft
>          Issue Type: Bug
>            Reporter: Roger Schildmeijer
>            Assignee: Roger Schildmeijer
>         Attachments: 
> Implemented+%23DEFT-154+%28Naive+read+in+AsynchronousSocket%29+patch+by+schildme.patch
>
>
> IOExceptions are not catched in AsynchronousSocket.handleRead(..)
> E.g if a connection between two peers is broken and one of them tried to read 
> from the channel, an IOE could be thrown (valid case). 
> Proposal: catch the exception, log,  invoke close callback (if its set), 
> close the channel and unregister it from the ioloop. (hint. 
> Closeable.closeQuietly(..))
> (Found while doing DEFT-151 (Distributed demo application (elastica)))

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to