[
https://issues.apache.org/jira/browse/DEFT-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069576#comment-13069576
]
Roger Schildmeijer commented on DEFT-167:
-----------------------------------------
don't worry, Roger :)
I have a bit of trouble finding a clear documentation about this subject.
Thats probably why the existing encoding/decoding issues (in the current code
base) ended up there from the beginning.
However after some reading, the best solution seems to be this:
(Thanks for the research)
1) protocol-level encode/decode with default charset ISO-8859-1 or US-ASCII
2) other charset like utf-8, encoded/decoded by the application developer
Ok.
regarding CharsetDecoder, the javadoc says:
"Instances of this class are not safe for use by multiple concurrent
threads."
so it seems safer to link a new instance of CharsetDecoder every single
IOLoop, right ?!?!?
Sounds reasonable. Take a look at the ThreadLocal MessageDigest in
org.deftserver.util.HttpUtil
can you tell me where I find the new repository!?!?
Take a look at http://incubator.apache.org/projects/deft.html.
The svn repo is located at: https://svn.apache.org/repos/asf/incubator/deft/
if you agree I would for now, continue to update my old github fork, to
generate the patches more quickly.
My best advice is to svn checkout from the Apache repo. (you could still use
git locally, I do that..)
> Use CharsetDecoder to convert ByteBuffer to String
> --------------------------------------------------
>
> Key: DEFT-167
> URL: https://issues.apache.org/jira/browse/DEFT-167
> Project: Deft
> Issue Type: Improvement
> Reporter: Michele Zuccalà
> Priority: Minor
>
> My research has shown that CharsetDecoders are much faster for the conversion
> of a ByteBuffer into a String.
> Take a look here for this simple improvement:
> https://github.com/ilmich/deft/commit/6914e922051d4e0e050a58daea2790091c236b7c
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
