[ 
https://issues.apache.org/jira/browse/DEFT-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070589#comment-13070589
 ] 

Roger Schildmeijer commented on DEFT-171:
-----------------------------------------

...been thinking some more about this. I don't think we should separate the 
http client from rest of the code. So its probably a good idea to use the same 
version everywhere...even though the AsynchronousHttpClient.java could be 
unchanged between two Deft releases the modules that are used indirectly 
(AsynchronousSocket.java, IOLoop.java etc) could be changed, so its probably ok 
to increase the version in the User-Agent http header...

It's also a good idea to hold the version number outside of the sourcecode, 
just like you proposed.

> Deft version should be correct in headers. Currently the versions returned 
> vary between client and response; are also hard-coded.
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DEFT-171
>                 URL: https://issues.apache.org/jira/browse/DEFT-171
>             Project: Deft
>          Issue Type: Bug
>            Reporter: Johnathan Meehan
>            Priority: Minor
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to