[ 
https://issues.apache.org/jira/browse/DEFT-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070660#comment-13070660
 ] 

Johnathan Meehan edited comment on DEFT-117 at 7/25/11 6:43 PM:
----------------------------------------------------------------

Added patch of initial implementation (which includes DEFT-115), for 
safekeeping and the curious. Need to review that things are actually okay (I 
think they are), review the methods which do and do not have bodies, and see 
about bringing AsynchronousHttpClient under better test.

Edit 1:
Will not bother checking if bodies are necessary when composing the request. As 
per Roy Fielding's comment:
"In other words, any HTTP request message is allowed to contain a message body, 
and thus must parse messages with that in mind."
May not be useful, but should be allowed: 
http://tech.groups.yahoo.com/group/rest-discuss/message/9962

Will create method signatures in line with general expectation, though. So, 
requests such as GET will have to call the setBody accessor; requests such as 
POST will have a parameter. The current HttpVerb.hasRequestBody check is not 
needed; will just check for a body that is not null (as opposed to empty, which 
is content length 0).


      was (Author: jmeehan):
    Added patch of initial implementation (which includes DEFT-115), for 
safekeeping and the curious. Need to review that things are actually okay (I 
think they are), review the methods which do and do not have bodies, and see 
about bringing AsynchronousHttpClient under better test.
  
> POST/PUT support in AsynchronousHttpClient
> ------------------------------------------
>
>                 Key: DEFT-117
>                 URL: https://issues.apache.org/jira/browse/DEFT-117
>             Project: Deft
>          Issue Type: New Feature
>            Assignee: Johnathan Meehan
>         Attachments: deft_117.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to