[
https://issues.apache.org/jira/browse/DEFT-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071118#comment-13071118
]
Roger Schildmeijer commented on DEFT-117:
-----------------------------------------
Looks good. codewise +1 (good job!)
some minor comments.
1, removed /** {@inheritDoc} */ from some interface impl.
2, added, asf license header to KnuthMorrisPrattAlgorithm (was my bad,
hopefully we can submit this patch and get DEFT-115 for free :-) )
3, AsynchronousHttpClient.this.method(); => method();
4, unnecessary this. prefix (removed them)
I guess you have some IDE formatting on that made 3 and 4. I manually fixed the
issues above and created a v2 patch. Feel free to take a look at it. (so we
agree)
> POST/PUT support in AsynchronousHttpClient
> ------------------------------------------
>
> Key: DEFT-117
> URL: https://issues.apache.org/jira/browse/DEFT-117
> Project: Deft
> Issue Type: New Feature
> Assignee: Johnathan Meehan
> Attachments: deft_117-v2.patch, deft_117.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
