[
https://issues.apache.org/jira/browse/DEFT-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071399#comment-13071399
]
Johnathan Meehan edited comment on DEFT-115 at 7/26/11 10:33 PM:
-----------------------------------------------------------------
Aside form a stray import of java.util.Arrays in AsynchronousHttpClient and
changes in NEWS, I can see no differences between the current repository and v3
of the patch. This is due to the commit of DEFT-117. Attached patch
(deft115-v4.patch) is the necessary update to NEWS. Could somebody verify this
is correct, so that we can commit the change and resolve this task?
was (Author: jmeehan):
Aside form a stray import of java.util.Arrays in AsynchronousHttpClient and
changes in NEWS, I can see no differences between the current repository and v3
of the patch. This is due to the commit of DEFT-117. Attached patch is the
necessary update to NEWS. Could somebody verify this is correct, so that we can
commit the change and resolve this task?
> Raw byte[] instead of US_ASCII encoded String
> ---------------------------------------------
>
> Key: DEFT-115
> URL: https://issues.apache.org/jira/browse/DEFT-115
> Project: Deft
> Issue Type: Improvement
> Assignee: Roger Schildmeijer
> Attachments: DEFT-115-v2.patch, DEFT-115-v3.patch, DEFT-115.patch,
> deft-115-v4.patch
>
>
> Another good point made by github/williame
> This is how we append data to the read buffer in the (buffered) AS.
> readBuffer.append(new String(buffer.array(), 0, buffer.position(),
> Charsets.US_ASCII));
> It's probably a bad idea to prematurely US_ASCII encode the data at this low
> level. (Encoding should be protocol/client specific). We should consider
> providing raw byte[] instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
