[
https://issues.apache.org/jira/browse/DEFT-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071401#comment-13071401
]
Emmanuel Lecharny commented on DEFT-115:
----------------------------------------
I applied the patch for CHANGES.txt. for some strange reason, it was rejected
when I applied the previous patch.
It's now ok.
> Raw byte[] instead of US_ASCII encoded String
> ---------------------------------------------
>
> Key: DEFT-115
> URL: https://issues.apache.org/jira/browse/DEFT-115
> Project: Deft
> Issue Type: Improvement
> Assignee: Roger Schildmeijer
> Attachments: DEFT-115-v2.patch, DEFT-115-v3.patch, DEFT-115.patch,
> deft-115-v4.patch
>
>
> Another good point made by github/williame
> This is how we append data to the read buffer in the (buffered) AS.
> readBuffer.append(new String(buffer.array(), 0, buffer.position(),
> Charsets.US_ASCII));
> It's probably a bad idea to prematurely US_ASCII encode the data at this low
> level. (Encoding should be protocol/client specific). We should consider
> providing raw byte[] instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
