[
https://issues.apache.org/jira/browse/DEFT-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071407#comment-13071407
]
Michele Zuccalà commented on DEFT-52:
-------------------------------------
Johnathan,
first of all, thanks for your appreciation of my work, I'm happy :)
I tried to keep things as simple as possible because my 'old' implementation
increased memory consumption, and I love Delft, due to its philosophy of speed
with few resources consumed.
I also tried to follow the new rfc6265, which makes obsolete the property
"discard"
Regarding the "max-age", I know that for now, some browsers ignore it.
But effectively we can provide a settter with seconds, and still use the
property "expires", or something like that:)
Regarding the validation may also be done inside the method setCookie ().
This is because the advantage of having an object for cookies(in my opinion),
would be the possibility to check every single set, and generate an exception
when an error occurs. But this is perhaps a little uncomfortable for the
developer.
About your notes:
- I got this name from Tornado's api :).
- do you think could be useful to return the string, with the http header
generated, in the setters ?!?!!?
- right :)
Last thing, I noticed a significant increase of performance by applying my
patch deft-168 (custom etags, and ability to disable automatic etag generation).
What do you use for your benchmarks?!
I use a simple (on linux)
ab -c 5-t 5 http://localhost:8080/
launched almost 3 times.
thanks
> Cookies
> -------
>
> Key: DEFT-52
> URL: https://issues.apache.org/jira/browse/DEFT-52
> Project: Deft
> Issue Type: New Feature
> Assignee: Johnathan Meehan
> Attachments: deft-52.patch, deft-52_alt.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
