[ 
https://issues.apache.org/jira/browse/DEFT-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13076125#comment-13076125
 ] 

Michele ZuccalĂ  commented on DEFT-153:
--------------------------------------

>- The current parse of "version" will return "Unfinished" rather than 
>"Unfinished request" as it based on spaces, so 
> inital text would have to chage to something like "UnfinishedRequest". 

You are right Johnathan, but in order to make a patch less intrusive(and at 
this moment I not fully understand the fundament of deft) I've 'simply' added 
the method PUT in the existing logic 

> I was wondering why there is new constructor in HttpRequest: 
I've thinked that in some circustances (and this is one, in my opinion) can be 
useful.
In my code, for example, if I use the HttpRequest(String requestLine, 
Map<String, String> headers)  constructor:
- I split requestLine twice
- PartialHttpRequest is knows that not contains valid url, etc etc.. then 
parsing parameters for example.. is superfluous


> Problems with PUT request
> -------------------------
>
>                 Key: DEFT-153
>                 URL: https://issues.apache.org/jira/browse/DEFT-153
>             Project: Deft
>          Issue Type: New Feature
>          Components: Core
>            Assignee: Johnathan Meehan
>             Fix For: 0.4.0
>
>         Attachments: deft-153_preview.patch
>
>
> Hi,
> It seems that PUT requests that contain a large body are truncated.
> Temporarily, I resolved with the following workaround in the method 
> HttpRequest.of ()
>     if (requestLine.contains ("POST") | | requestLine.contains ("PUT")) {
>          int ContentLength = Integer.parseInt (generalHeaders.get 
> ("content-length"));
>          if (ContentLength> body.length ()) {
>              return new PartialHttpRequest (requestLine, generalHeaders, 
> body);
>         }
>     }
> I hope it can be helpful:)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to