On Sat, 10 Mar 2001, Normal User wrote: > The following is a patch (against the current CVS) that replaces a few > uses of sprintf and strcat with the C++ string and ostringstream classes > (safer, more flexible, type-safe, blah blah...). If you're interested in > accepting this type of patch, let me know, and I'll continue to make them.
Hm. There should have been no uses of sprintf. Wonder how those snuck in. IMHO the sprintf fixes to indexcopy are not worthwhile (they should be snprintf however).. However, the change to the http method is rather nice, should have done that to start with. There is also some code in apt-pkg/acquire-method that could use this to considerable benifit too. Jason
