tags 54982 +patch
thanks
This patch makes apt-get print out recommends and suggests when
installing packages. It does _not_ treat suggests/recommends as
depends.
Index: apt-get.cc
===================================================================
RCS file: /cvs/deity/apt/cmdline/apt-get.cc,v
retrieving revision 1.103
diff -u -r1.103 apt-get.cc
--- apt-get.cc 2001/03/03 23:12:07 1.103
+++ apt-get.cc 2001/08/19 11:59:58
@@ -1386,6 +1386,69 @@
ShowList(c1out,_("The following extra packages will be
installed:"),List);
}
+ /* Print out a list of suggested and recommended packages */
+ {
+ string SuggestsList, RecommendsList, List;
+ for (unsigned J = 0; J < Cache->Head().PackageCount; J++)
+ {
+ pkgCache::PkgIterator I(Cache,Cache.List[J]);
+
+ /* Just look at the ones we want to install */
+ if ((*Cache)[I].Install() == false)
+ continue;
+
+ for (pkgCache::VerIterator V = I.VersionList(); V.end() == false; V++)
+ {
+ for (pkgCache::DepIterator D = V.DependsList(); D.end() == false;
D++)
+ {
+ pkgCache::DepIterator Start;
+ pkgCache::DepIterator End;
+ D.GlobOr(Start,End);
+ do
+ {
+ if (Start->Type == pkgCache::Dep::Suggests) {
+
+ /* A suggests relations, let's see if we have it
+ installed already */
+
+ string target = string(Start.TargetPkg().Name()) + " ";
+ if ((*Start.TargetPkg()).SelectedState ==
pkgCache::State::Install)
+ break;
+ /* Does another package suggest it as well? If so,
+ don't print it twice */
+ if (int(SuggestsList.find(target)) > -1)
+ break;
+ SuggestsList += target;
+ }
+
+ if (Start->Type == pkgCache::Dep::Recommends) {
+
+ /* A recommends relation, let's see if we have it
+ installed already */
+
+ string target = string(Start.TargetPkg().Name()) + " ";
+ if ((*Start.TargetPkg()).SelectedState ==
pkgCache::State::Install)
+ break;
+
+ /* Does another package recommend it as well? If so,
+ don't print it twice */
+
+ if (int(RecommendsList.find(target)) > -1)
+ break;
+ RecommendsList += target;
+ }
+ if (Start == End)
+ break;
+ Start++;
+ } while (1);
+ }
+ }
+ }
+ ShowList(c1out,_("Suggested packages:"),SuggestsList);
+ ShowList(c1out,_("Recommended packages:"),RecommendsList);
+
+ }
+
// See if we need to prompt
if (Cache->InstCount() == ExpectedInst && Cache->DelCount() == 0)
return InstallPackages(Cache,false,false);
--
Tollef Fog Heen
You Can't Win
