Your message dated Mon, 20 Aug 2001 22:46:30 -0600 (MDT)
with message-id <[EMAIL PROTECTED]>
and subject line Fixed in apt 0.5.4
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Darren Benham
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 8 Jun 2001 04:45:44 +0000
>From [EMAIL PROTECTED] Thu Jun 07 23:45:44 2001
Return-path: <[EMAIL PROTECTED]>
Received: from sydney4.au.ibm.com (drongo.ozlabs.ibm.com)
[::ffff:202.135.142.205]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 158E9X-0007dr-00; Thu, 07 Jun 2001 23:45:43 -0500
Received: by drongo.ozlabs.ibm.com (Postfix, from userid 1036)
id DF0261B6D3; Fri, 8 Jun 2001 14:45:29 +1000 (EST)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Date: Fri, 8 Jun 2001 14:40:54 +1000
To: [EMAIL PROTECTED]
Subject: apt no_proxy parsing is broken
X-Mailer: VM 6.92 under Emacs 20.7.2
From: "Martin Schwenke" <[EMAIL PROTECTED]>
Reply-To: "Martin Schwenke" <[EMAIL PROTECTED]>
Message-Id: <[EMAIL PROTECTED]>
Delivered-To: [EMAIL PROTECTED]
Package: apt
Version: 0.5.3
apt only matches successfully against the first host/domain listed in
the no_proxy environment variable.
Here's a fix:
--------8<---------8<-------- CUT HERE --------8<---------8<--------
--- strutl.cc.orig Tue Feb 27 15:14:22 2001
+++ strutl.cc Fri Jun 8 14:03:21 2001
@@ -893,7 +893,7 @@
continue;
// Match the end of the string..
- if ((Host.size() >= (unsigned)(Cur - List.begin())) &&
+ if ((Host.size() >= (unsigned)(Cur - Start)) &&
Cur - Start != 0 &&
stringcasecmp(Host.end() - (Cur - Start),Host.end(),Start,Cur) == 0)
return true;
--------8<---------8<-------- CUT HERE --------8<---------8<--------
I'm a little surprised that the string isn't split at commas using
something a little higher level. strtok_r(3) should do a reliable
job, especially since the code is more C than C++ anyway. Otherwise,
there should be something in the STL...
Regards,
Martin
--
Martin Schwenke <[EMAIL PROTECTED]>
IBM OzLabs Linux Development Team
Canberra, Australia
---------------------------------------
Received: (at 100046-done) by bugs.debian.org; 21 Aug 2001 04:46:46 +0000
>From [EMAIL PROTECTED] Mon Aug 20 23:46:46 2001
Return-path: <[EMAIL PROTECTED]>
Received: from cast-ext.ab.videon.ca [206.75.216.34]
by master.debian.org with smtp (Exim 3.12 1 (Debian))
id 15Z3R3-0000yO-00; Mon, 20 Aug 2001 23:46:46 -0500
Received: (qmail 1390 invoked from network); 21 Aug 2001 04:46:39 -0000
Received: from unknown (HELO wakko.deltatee.com) ([24.108.173.63])
(envelope-sender <[EMAIL PROTECTED]>)
by cast-ext.ab.videon.ca (qmail-ldap-1.03) with SMTP
for <[EMAIL PROTECTED]>; 21 Aug 2001 04:46:39 -0000
Received: from localhost
([127.0.0.1] helo=wakko.deltatee.com ident=jgg)
by wakko.deltatee.com with smtp (Exim 3.16 #1 (Debian))
id 15Z3Qt-0003KS-00; Mon, 20 Aug 2001 22:46:31 -0600
Date: Mon, 20 Aug 2001 22:46:30 -0600 (MDT)
From: Jason Gunthorpe <[EMAIL PROTECTED]>
X-Sender: [EMAIL PROTECTED]
To: [EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED]
Subject: Fixed in apt 0.5.4
Message-ID: <[EMAIL PROTECTED]>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Delivered-To: [EMAIL PROTECTED]
apt (0.5.4) unstable; urgency=low
* M68k config.guess patch. Closes: #88913
* Bi-yearly test on OpenBSD and Solaris
* Doc updates. Closes: #89121, #89854, #99671, #98353, #95823, #93057,
#97520, #102867, #101071, #102421, #101565, #98272, #106914,
#105606, #105377
* Various cosmetic code updates. Closes: #89066, #89066, #89152
* Add "pre-auto" as an option for DSelect::Clean (run autoclean after
update).
* More patches from Alfredo for Vendors and more SHA-1 stuff
* Fix for AJ's 'desire to remove perl-5.005' and possibly other
similar situations. Closes: #56708, #59432
* no_proxy and ftp. Closes: #89671
* Philippe Batailler's man page patches.
* Fix for display bug. Closes: #92033, #93652, #98468
* Use more than 16bits for the dep ID. Some people ran out..
Closes: #103020, #97809, #102951, #99974, #107362, #107395, #107362,
#106911, #107395, #108968
* Reordered some things to make dante and FTP happier. Closes: #92757
* James R. Van Zandt's guide.sgml updates. Closes: #90027
* apt-ftparchive copes with no uncompressed package files + contents.
* French man pages from philippe batailler - well sort of. They
don't build yet..
* run-parts. Closes: #94286
* 'apt-cache policy' preferences debug tool.
* Whatever. Closes: #89762
* libstdc++ and HURD. Closes: #92025
* More apt-utils verbage. Closes: #86954
* Fliped comparision operator. Closes: #94618
* Used the right copyright file. Closes: #65691
* Randolph's G++3 patches.
* Fixed no_proxy tokanizing. Closes: #100046
* Strip Config-Version when copying status to available. Closes: #97520
* Segfault with missing source files. Closes: #100325
* EINTR check. Closes: #102293
* Various changes to the locking metholodgy for --print-uris.
Closes: #100590
* Lame LD_LIBRARY_PATH thing. Closes: #98928
* apt-cache search searchs provide names too now. Closes: #98695
* Checksum and long lines problem. Closes: #106591
* .aptignr and empty files are just a warning. Closes: #97364
