Except... Surely iCountFiles equals the number of files? Except in your code it is NOT - it is the current index into the files list.
Surely sFileList is a string which contains a list of files? Except in your code it does NOT - it stores the file name for the current index you have iterated too. Just goes to show doesn't it? Longer names aren't always clearer... Personally I prefer i instead of a misleading iCountFiles. On the string front though I would insist on a variable describing the string stored (eg sFileName using your naming terminology). My 2c. David. > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] Behalf Of Traci Sumpter > Sent: Friday, 24 September 2004 2:01 PM > To: NZ Borland Developers Group - Delphi List > Subject: RE: [DUG] DiamondBack Sneak Peek (Delphi 9) > > > except 5 months down the track when it would be a lot easier to unserstand > > procedure DoSomethingorOther; > var > sFileList : string; > iCountFiles : Integer; > begin > for iCountFiles := 0 to Pred(someList.Count) do > begin > sFileList := someList.Items[iCountFiles]; > doSomething(sFileList); > end; > end; > > > > This means I can look at this short bit of code and can make assumptions > that I am going through a list of Files and doing something with it. > > > what does the other version of code allow you to make assumtions about.. > > Assume Ass out of you and me... I know > > > > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] Behalf Of James Sugrue > Sent: Friday, 24 September 2004 1:25 p.m. > To: NZ Borland Developers Group - Delphi List > Subject: RE: [DUG] DiamondBack Sneak Peek (Delphi 9) > > > I would have though i and j would be fine for loops and s for strings. > x and y for anything to do with co-ords as well. > > > I think the following is fine: > > procedure DoSomethingorOther; > var > s : string; > i : Integer; > begin > for i := 0 to Pred(someList.Count) do > begin > s := someList.Items[i]; > doSomething(s); > end; > end; > > > On Fri, 2004-09-24 at 12:41, [EMAIL PROTECTED] wrote: > > > Good practice (not always =) VCL source > > > > True, the VCL also uses _with_. > > > > Each to there own - but globally condemned is a bit rich > > > > > for multitudes of good reasons. > > > > name some then > > > > > > What did you search on in google. > > _______________________________________________ > > Delphi mailing list > > [EMAIL PROTECTED] > > http://ns3.123.co.nz/mailman/listinfo/delphi > > _______________________________________________ > Delphi mailing list > [EMAIL PROTECTED] > http://ns3.123.co.nz/mailman/listinfo/delphi > > _______________________________________________ > Delphi mailing list > [EMAIL PROTECTED] > http://ns3.123.co.nz/mailman/listinfo/delphi > _______________________________________________ Delphi mailing list [EMAIL PROTECTED] http://ns3.123.co.nz/mailman/listinfo/delphi
