On Apr 28, 2011, at 8:07 PM, [email protected] wrote: > ACK (minor typo needs fixing before commit): > > * clean application (minor whitespace [non] issue) > > * Rakefile lines 124/125/126 - typo - you forgot to specify the :mock > namespace (e.g. Rake::Task["mock:fixtures:clean"].invoke) so gives an error > > * The rake mock:setup/clean/reset stuff is very nice and long overdue - can > we automate this during install? (e.g. add it in 'rake package' for example) > > * Code 502 'Backend error' - previously you used to get a full stack trace in > the 'details' field - i don't know if its better without it but this is a > matter of opinion. You could argue that its better without it since it > doesn't give you any new information (e.g. you know the problem happened in > 'buckets' method since thats what you requested - but imo more information is > always better for debugging. >
Thanks! I fixed Rakefile and pushed the patchset to SVN. Re 520: I probably forgot to add this information here, thanks!. -- Michal > > marios > > On 27/04/11 14:07, [email protected] wrote: >> Hi, >> >> this patchset combine my previous error handling DSL patch and fix all >> tests/issues >> so far. (all our test suites are green). >> >> Also I recently realized, that we don't have mechanism to 'reset' mock data >> in mock dir. >> So I updated Rakefile and nwo there are couple tasks for dealing with mock >> data (setup, clean, reset) >> >> All error pages were updated to be more verbose for users (well HTML pages >> are helpfull just for developers, >> which is another reason I increased verbosity). So no you can see backtrace, >> HTTP status code explanation, >> request and response headers and of course status code. >> >> Since we already discussed fir revision and so far it was 'acked' verbaly >> ;-) I just resending rebased patch >> with this additions. For those who look on my previous patch, first patch in >> this set is not interesting. >> >> -- Michal >> > ------------------------------------------------------ Michal Fojtik, [email protected] Deltacloud API: http://deltacloud.org
