On Jul 12, 2011, at 1:03 AM, David Lutterkort wrote: > On Mon, 2011-07-11 at 17:43 +0200, [email protected] wrote: >> From: Michal Fojtik <[email protected]> >> >> >> Signed-off-by: Michal fojtik <[email protected]> >> --- >> .../deltacloud/drivers/vsphere/vsphere_driver.rb | 64 >> ++++++++++++++------ >> 1 files changed, 46 insertions(+), 18 deletions(-) > > As much as I hate making the driver stateful, ACK. > > It would be great if we could store information about the VM in the > task, but I haven't seen anything in the docs that would allow that. > >> diff --git a/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb >> b/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb >> index daf34f1..64bfa34 100644 >> --- a/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb >> +++ b/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb >> @@ -19,39 +19,39 @@ require 'rbvmomi' >> >> module Deltacloud::Drivers::VSphere >> >> + MAPPER_STORAGE_ROOT = File::join("/var/tmp", >> "deltacloud-vsphere-#{ENV["USER"]}") > > The mock driver sets kinda a bad precedent here - but since we want this > state to persist across server restarts, we should put it > into /var/lib/deltacloud and claim that directory in the RPM specfile.
Fair point. I'll add this directory in deltacloud-core-vsphere directory. > > This also means we need our own user that deltacloudd runs under (and > that owns /var/lib/deltacloud) In Fedora I use 'nobody' in init.d script. Maybe it would be a good idea to create our own user. Eventually we can sync with Aeolus guys to use the same user. > > David > > ------------------------------------------------------ Michal Fojtik, [email protected] Deltacloud API: http://deltacloud.org
