On Fri, 2011-08-19 at 15:42 +0300, mar...@redhat.com wrote:
> Patch1/3: 
>   Replace 'blob' with 'blob_id' in html create blob operation (POST), API 
> docs and in the new blob html form itself. 
>   Thanks to Chris Lalancette for bringing up this API compatibility issue 
> (http://mail-archives.apache.org/mod_mbox/incubator-deltacloud-dev/201108.mbox/%3C20110818141451.GL2848@localhost.localdomain%3E).
> 
> Patch2/3: 
>   Commit 68191e462dac8b1aaa4ba15e261a83a130888755 added the :new operation to 
> collection and removed the explicit routes from server.rb for getting 'new' 
> html forms, like for creating a new blob. These were replaced by 'new' 
> operations under the collections themselves. For blobs, the 'new_blob' 
> operation had a typo - was called 'new_bucket'. 
>   However, after fixing this I still had to define an explicit 'get 
> /api/buckets/:bucket/new_blob' route for getting the 'new_blob' form. There 
> is already a route 'get /api/buckets/:bucket/:blob' for getting blob details 
> and this caused a name clash; the route 'get /api/buckets/:bucket/new_blob' 
> was triggering the retrieval of details about the blob called 'new_blob' 
> rather than giving the html form.
> 
> Patch 3/3
>   Fixes creation of new blob form to work with the new jquery mobile 
> interface. The blob metadata was not getting captured correctly due to the 
> extra <div data-role => :fieldcontain> wrappers so I removed these. Also, 
> there is apparently an issue with jquery, ajax and uploading of files  - 
> after a couple hours of frustrated head-meet-wall I found this: 
> http://forum.jquery.com/topic/jquery-mobile-seems-to-clobber-ability-to-upload-files-via-forms
>   So I disabled ajax for this particular form and now functionality is 
> restored,
> 
> marios

I've committed these patches for you, with a small change to make the
new blob form URL more unique, and less likely to clash with the name of
an existing blob.

I thought I'd be able to build rc3 after that, but then got sidetracked
shaving another yak - patch series is coming.

David




Reply via email to